From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 697A2C4332F for ; Fri, 25 Nov 2022 15:05:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b8zrNmU3GUf6+pOcrWSsHG6o0DFTq3W7QkQYy963Lks=; b=Kt2pAeDZQfgIEC Smg+ieDoP73Yg5fSU5ij7B7j0xZ9BRDwHZcQ0ax8/ry4KxPn75yxYUt6B0MHtk2xMP6nrVDSyQXob q8EAYUvDy63lNKPmOkZg8jYaASt1NSmMd/wr7aLU5A+Bj9gpqHW75Pdae3zDnWmS5eULjAVwL8150 KRnR2iS4zcgt6OImnESru9EYfGLXdZwBy3+7JU4qQjfOVOAl0u/qeRbUQgkvzPNmpW71bHxkRgn0G vc+AWKbzFFUbCoORx/CuYTXXeuletNUvd3oXJDZVTbHAruBieIjdsOFvFw7CLGqIRKbcVhHEHrQfz XXI7/b53f7RVM1+NWT2Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyaF6-00HJnA-T4; Fri, 25 Nov 2022 15:03:53 +0000 Received: from mail-lj1-x233.google.com ([2a00:1450:4864:20::233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyaCs-00HIWR-26 for linux-arm-kernel@lists.infradead.org; Fri, 25 Nov 2022 15:01:36 +0000 Received: by mail-lj1-x233.google.com with SMTP id bn5so5480418ljb.2 for ; Fri, 25 Nov 2022 07:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=94PbW/ltOKOm/qJBLJVRn1IDNTKIsX6g0SVX2b46Dbk=; b=qq6Hx88tkfo7+D1qphcXIKQi6NGKUNKUlyVhxeckYhjG19NgOYegoyzQHAX1t/16Xn odjqfnFXNiFAoOJ/yr9uWiYnsUOW/QHtIseSSgCZd5S4nKI74bwnidIaUspAmcwQCGiW wzD4U7rVQFe2A7ULy073mjTZvk8vBicCulhBsMWn+2k6aUrQirSqWtxkxMaFUOyUE3iL KgQe1FH1wAnSUDazZkqc7T5ODIJVyHexjGAg26hctQM5PS3V4u9rF6PLB8ntX86PI6VA MqUteFpo5cuSwpc9XlgAwW7MJc0uGiRg56reQElNeaCmNzckPcLLAyflk5MPiLvwPKWT jNFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=94PbW/ltOKOm/qJBLJVRn1IDNTKIsX6g0SVX2b46Dbk=; b=nX/UIPskdQU7nd2G3I6nj0NJFAADzg7Naw9LYhwvjOEY10BjmfJ87zWTTMZ7O5cBSL TdPJaQ5Otc9bt97s/IUj4cCFoOhnQtxTwTsL2l4rUXLMPmg1BGcOBaC2HROe03fonXOd dWvdRldjCcoVHLn6X2IJwR4iPUQlaDdWUx/ZL2jZgPjKmWQZAGKAXn8ua8EcGX5XhULI M0DUC6vjycPHEZL9dGIj/F4fPQa+wE0URWjL28pBiObvBcwyFThLbTPj1ysW9ciPJ2cg hu4nZakcCmy2Dm3GgFzIYl1WFKegakyNtSYFookFHkh1oOhoyrrcVHcp+4EDJWts67q/ l9lQ== X-Gm-Message-State: ANoB5pmVMZLPDGUkJWnYyZ6dOD6nwwiNPzyUbGUiLjK1gVjjrEPOXYAy xEKYvsh8N5FUDJb9QVq2J48hgw== X-Google-Smtp-Source: AA0mqf6N/acKSsSzIeuCEG7rXhNpwGx/2OgTNX8bK8JIQT+L8rh+ICXSSLrw1JdPH6Z3K+/GqZMBWw== X-Received: by 2002:a05:651c:10af:b0:277:3046:3d1c with SMTP id k15-20020a05651c10af00b0027730463d1cmr11681896ljn.422.1669388488347; Fri, 25 Nov 2022 07:01:28 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id u27-20020ac258db000000b0049adf925d00sm555433lfo.1.2022.11.25.07.01.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Nov 2022 07:01:27 -0800 (PST) Message-ID: <016293da-92b1-16e9-9a8d-ecab34c2f0c6@linaro.org> Date: Fri, 25 Nov 2022 16:01:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 3/4] dt-bindings: soc: samsung: exynos-sysreg: add dedicated SYSREG compatibles to Exynos5433 Content-Language: en-US To: Sam Protsenko Cc: Lee Jones , Rob Herring , Krzysztof Kozlowski , Alim Akhtar , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Sriranjani P , Chanho Park References: <20221125112201.240178-1-krzysztof.kozlowski@linaro.org> <20221125112201.240178-3-krzysztof.kozlowski@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221125_070134_186640_264508C3 X-CRM114-Status: GOOD ( 16.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/11/2022 15:57, Sam Protsenko wrote: > On Fri, 25 Nov 2022 at 08:47, Krzysztof Kozlowski > wrote: >> >> On 25/11/2022 15:22, Sam Protsenko wrote: >>> On Fri, 25 Nov 2022 at 05:22, Krzysztof Kozlowski >>> wrote: >>>> >>>> Exynos5433 has several different SYSREGs, so use dedicated compatibles >>>> for them. >>>> >>>> Signed-off-by: Krzysztof Kozlowski >>>> >>>> --- >>>> >>>> Cc: Sriranjani P >>>> Cc: Chanho Park >>>> Cc: Sam Protsenko >>>> --- >>> >>> Hi Krzysztof, >>> >>> Just curious: what is the rationale for adding those more specific >>> sysregs? AFAIR, e.g. in Exynos850, different SysReg instances have >>> pretty much the same register layout. >>> >> >> On Exynos5433 all these blocks have different registers. Are you saying >> that Exynos850 has four (or more) sysregs which are exactly the same? >> Same registers? Why would they duplicate it? >> > > Ah, no, you are right. Just checked it, they are different. Just first > couple of registers are similar between blocks, that's why I memorized > it wrong. > > So as I understand, adding those new compatibles follows "describe HW, > not a driver" rule? Because AFAIU, right now it'll fallback to > "syscon" compatible anyway. Yes, they describe hardware. Of course all of these sysregs are similar as they are just bunch of SFR/MMIO-region, but they have different roles/features. For example some other devices (users) of syscon/sysreg should reference specific device, not any sysreg. On several other architectures we use specific compatibles, so I think for Samsung we should do the same. Different case was for Exynos 3/4/5 where there was only one SYSREG. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel