* [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock
@ 2012-09-28 10:39 Sangsu Park
2013-01-15 3:31 ` Tushar Behera
0 siblings, 1 reply; 7+ messages in thread
From: Sangsu Park @ 2012-09-28 10:39 UTC (permalink / raw)
To: linux-arm-kernel
Remove I2S0 clock from peril since peril doesn't have I2S0 clock for EXYNOS4.
Audio Subsystem block has I2S0 clk.
Signed-off-by: sangsu <sangsu@sangsu-P560.(none)>
---
arch/arm/mach-exynos/clock-exynos4.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm/mach-exynos/clock-exynos4.c
b/arch/arm/mach-exynos/clock-exynos4.c
index 6a45c9a..fa8a134 100644
--- a/arch/arm/mach-exynos/clock-exynos4.c
+++ b/arch/arm/mach-exynos/clock-exynos4.c
@@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
.ctrlbit = (1 << 18),
}, {
.name = "iis",
- .devname = "samsung-i2s.0",
- .enable = exynos4_clk_ip_peril_ctrl,
- .ctrlbit = (1 << 19),
- }, {
- .name = "iis",
.devname = "samsung-i2s.1",
.enable = exynos4_clk_ip_peril_ctrl,
.ctrlbit = (1 << 20),
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock
@ 2012-10-05 7:37 Sangsu Park
2012-10-08 2:15 ` Sangbeom Kim
0 siblings, 1 reply; 7+ messages in thread
From: Sangsu Park @ 2012-10-05 7:37 UTC (permalink / raw)
To: linux-arm-kernel
Remove I2S0 clk from peril since peril clock doesn't have I2S0 clk for EXYNOS4.
Audio Subsystem block has I2S0 clk.
Signed-off-by: Sangsu Park <sangsu4u.park@samsung.com>
---
arch/arm/mach-exynos/clock-exynos4.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/arch/arm/mach-exynos/clock-exynos4.c
b/arch/arm/mach-exynos/clock-exynos4.c
index 6a45c9a..fa8a134 100644
--- a/arch/arm/mach-exynos/clock-exynos4.c
+++ b/arch/arm/mach-exynos/clock-exynos4.c
@@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
.ctrlbit = (1 << 18),
}, {
.name = "iis",
- .devname = "samsung-i2s.0",
- .enable = exynos4_clk_ip_peril_ctrl,
- .ctrlbit = (1 << 19),
- }, {
- .name = "iis",
.devname = "samsung-i2s.1",
.enable = exynos4_clk_ip_peril_ctrl,
.ctrlbit = (1 << 20),
--
1.7.9.5
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock
@ 2012-10-08 1:31 Sangsu Park
0 siblings, 0 replies; 7+ messages in thread
From: Sangsu Park @ 2012-10-08 1:31 UTC (permalink / raw)
To: linux-arm-kernel
ping
On 5 October 2012 4:37 PM, Sangsu Park < sangsu4u.park@samsung.com> wrote:
> Remove I2S0 clk from peril since peril clock doesn't have I2S0 clk for
EXYNOS4.
> Audio Subsystem block has I2S0 clk.
>
> Signed-off-by: Sangsu Park <sangsu4u.park@samsung.com>
> ---
> arch/arm/mach-exynos/clock-exynos4.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/clock-exynos4.c b/arch/arm/mach-
> exynos/clock-exynos4.c
> index 6a45c9a..fa8a134 100644
> --- a/arch/arm/mach-exynos/clock-exynos4.c
> +++ b/arch/arm/mach-exynos/clock-exynos4.c
> @@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
> .ctrlbit = (1 << 18),
> }, {
> .name = "iis",
> - .devname = "samsung-i2s.0",
> - .enable = exynos4_clk_ip_peril_ctrl,
> - .ctrlbit = (1 << 19),
> - }, {
> - .name = "iis",
> .devname = "samsung-i2s.1",
> .enable = exynos4_clk_ip_peril_ctrl,
> .ctrlbit = (1 << 20),
> --
> 1.7.9.5
Best regards,
Sangsu Park.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock
2012-10-05 7:37 [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock Sangsu Park
@ 2012-10-08 2:15 ` Sangbeom Kim
2012-10-23 10:30 ` Kukjin Kim
0 siblings, 1 reply; 7+ messages in thread
From: Sangbeom Kim @ 2012-10-08 2:15 UTC (permalink / raw)
To: linux-arm-kernel
On Friday, Oct 05, 2012 at 4:37 PM, Sangsu Park wrote:
> Remove I2S0 clk from peril since peril clock doesn't have I2S0 clk for EXYNOS4.
> Audio Subsystem block has I2S0 clk.
>
> Signed-off-by: Sangsu Park <sangsu4u.park@samsung.com>
Peril control bit 19 is reserved.
Acked-by: Sangbeom Kim <sbkim73@samsung.com>
Thanks,
Sangbeom.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock
2012-10-08 2:15 ` Sangbeom Kim
@ 2012-10-23 10:30 ` Kukjin Kim
0 siblings, 0 replies; 7+ messages in thread
From: Kukjin Kim @ 2012-10-23 10:30 UTC (permalink / raw)
To: linux-arm-kernel
Sangbeom Kim wrote:
>
> On Friday, Oct 05, 2012 at 4:37 PM, Sangsu Park wrote:
> > Remove I2S0 clk from peril since peril clock doesn't have I2S0 clk for
> EXYNOS4.
> > Audio Subsystem block has I2S0 clk.
> >
> > Signed-off-by: Sangsu Park <sangsu4u.park@samsung.com>
>
> Peril control bit 19 is reserved.
>
> Acked-by: Sangbeom Kim <sbkim73@samsung.com>
>
Applied.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock
2012-09-28 10:39 Sangsu Park
@ 2013-01-15 3:31 ` Tushar Behera
2013-01-16 1:08 ` Sangsu Park
0 siblings, 1 reply; 7+ messages in thread
From: Tushar Behera @ 2013-01-15 3:31 UTC (permalink / raw)
To: linux-arm-kernel
On 09/28/2012 04:09 PM, Sangsu Park wrote:
> Remove I2S0 clock from peril since peril doesn't have I2S0 clock for EXYNOS4.
> Audio Subsystem block has I2S0 clk.
>
> Signed-off-by: sangsu <sangsu@sangsu-P560.(none)>
> ---
> arch/arm/mach-exynos/clock-exynos4.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/arch/arm/mach-exynos/clock-exynos4.c
> b/arch/arm/mach-exynos/clock-exynos4.c
> index 6a45c9a..fa8a134 100644
> --- a/arch/arm/mach-exynos/clock-exynos4.c
> +++ b/arch/arm/mach-exynos/clock-exynos4.c
> @@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
> .ctrlbit = (1 << 18),
> }, {
> .name = "iis",
> - .devname = "samsung-i2s.0",
> - .enable = exynos4_clk_ip_peril_ctrl,
> - .ctrlbit = (1 << 19),
> - }, {
> - .name = "iis",
> .devname = "samsung-i2s.1",
> .enable = exynos4_clk_ip_peril_ctrl,
> .ctrlbit = (1 << 20),
>
After this clock has been removed, I2S0 registration fails on EXYNOS4
based boards (clk_get for iis clock fails). The alternate clock from
Audio subsystem block is missing.
--
Tushar Behera
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock
2013-01-15 3:31 ` Tushar Behera
@ 2013-01-16 1:08 ` Sangsu Park
0 siblings, 0 replies; 7+ messages in thread
From: Sangsu Park @ 2013-01-16 1:08 UTC (permalink / raw)
To: linux-arm-kernel
On 1/15/2013 12:32 PM, Tushar Behera wrote:
> On 09/28/2012 04:09 PM, Sangsu Park wrote:
> > Remove I2S0 clock from peril since peril doesn't have I2S0 clock for
EXYNOS4.
> > Audio Subsystem block has I2S0 clk.
> >
> > Signed-off-by: sangsu <sangsu@sangsu-P560.(none)>
> > ---
> > arch/arm/mach-exynos/clock-exynos4.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/arch/arm/mach-exynos/clock-exynos4.c
> > b/arch/arm/mach-exynos/clock-exynos4.c
> > index 6a45c9a..fa8a134 100644
> > --- a/arch/arm/mach-exynos/clock-exynos4.c
> > +++ b/arch/arm/mach-exynos/clock-exynos4.c
> > @@ -613,11 +613,6 @@ static struct clk exynos4_init_clocks_off[] = {
> > .ctrlbit = (1 << 18),
> > }, {
> > .name = "iis",
> > - .devname = "samsung-i2s.0",
> > - .enable = exynos4_clk_ip_peril_ctrl,
> > - .ctrlbit = (1 << 19),
> > - }, {
> > - .name = "iis",
> > .devname = "samsung-i2s.1",
> > .enable = exynos4_clk_ip_peril_ctrl,
> > .ctrlbit = (1 << 20),
> >
>
> After this clock has been removed, I2S0 registration fails on EXYNOS4
> based boards (clk_get for iis clock fails). The alternate clock from
> Audio subsystem block is missing.
>
Yes, you're right.
I2S0 clock doesn't belong to peril clock.
Audio Subsystem has its own clock and also I2S0 clock.
That work might be missed. I'll do that work soon.
Thanks.
> --
> Tushar Behera
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-01-16 1:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-05 7:37 [PATCH] ARM: EXYNOS: Remove wrong I2S0 clock from peril clock Sangsu Park
2012-10-08 2:15 ` Sangbeom Kim
2012-10-23 10:30 ` Kukjin Kim
-- strict thread matches above, loose matches on Subject: below --
2012-10-08 1:31 Sangsu Park
2012-09-28 10:39 Sangsu Park
2013-01-15 3:31 ` Tushar Behera
2013-01-16 1:08 ` Sangsu Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).