From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C1E2C67861 for ; Mon, 8 Apr 2024 07:56:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OV4ItdrB47WoPzNheF05LYvjCQ0xI5VtOeNaP2DXwgU=; b=qs40Mgdwctst0A VRmJCuplrkJ9mOsdCXxUsctmufWUU5xbpCp7yPcu8KhcId3lwIcwAx17Y4L4HBmD4Gl/S6ItxsYMm O/sZuszbVDUgVAlMlqLpxHluAh7R7VgQdVOE+qeYpRGzt6DvfoJL74rRGOGEK14aAmBp9xGRnf8LM wldS6ve1XL7/qoD6QfDaSpYV0rlPILQ3VMNMTAFF0Vk3Ud8cEy1OSw73yv61kN/B01DKdC7P0QSa2 00nB4ynLU7YYt0Mw+l7L6u3xqHXt23PmuELPWn+b+n5e7N2heqa7kFau5ND4FOUCQEmnI3loyN9Ug 4Jf5XireOpuZVABGGXyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtjr3-0000000EmWP-2Ulr; Mon, 08 Apr 2024 07:55:50 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rtjqu-0000000EmQh-3ew2 for linux-arm-kernel@lists.infradead.org; Mon, 08 Apr 2024 07:55:47 +0000 Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-516d47ce662so4351529e87.1 for ; Mon, 08 Apr 2024 00:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712562938; x=1713167738; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=uGVKRsfzElZhuiOUBPoS8tlbXX9PErhVKCskk8TAVI8=; b=Scuw/DTZ/ptxKsC3iWcY52h2Mmorilb+oEpxUQwNBr6iKGOIgARQiaNcYbHjlRnGo0 tIJddjVL8aY+hZa/DaZWRjg6/V+9AOXFXoXVeuG7GeMKTVc0gLjL1s+RX4oa0yvUnlEY DDWcaaiGDps9XhxK+MS84chkSFWiIophhPqiZKo6AUXnAzpnoBjkB1N8X2UET5IiLv7c VVEtHQsb29hiJjyJWgiTbvOhMQlM0mVxQg53k8wfChhh28VyS4mbu22xihOHAARXNfud mRpdtkBXKLQ5vMeR/ifqkfzi8ulCgWAPU5tocSIanXXNdc6n/X7fa2C3F2t8RCYLodq7 j13Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712562938; x=1713167738; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uGVKRsfzElZhuiOUBPoS8tlbXX9PErhVKCskk8TAVI8=; b=Zt79hUAqy+7qdO3NPCthNf459K7tnYJ+9Q7D2CKd4bog1NHRQRXTZSfXbVdYEaBHGD OX8vWAZ4H0HtN49r11c6Nox2/0J6heHUH1AbpFJ0IEb6oCxJkzCqHjSB/IAsqdqys3Nc fmM7owIsnaC4fTiPcAqb2Ykp15sGPkXg7OgZLvnpERJJQ1cFAk6qsw7F834AyplGPE9M KrHdJSqBVsyAdYgGPp3U2IDNuY0ZLywy5fq7YroYCkysRsTYQJMdBrApayowj37wsiSL KK+WCrpQoQzyCKiwSp+QMjjbCK6u8uRPrIGR+7jf3DBUPCmQi5StJegw15czOX+xBrLe U4sg== X-Forwarded-Encrypted: i=1; AJvYcCVuCcN5v0ypmKW+17+0t169m+xZWLkY9wEkQJPspV5DYvlA1GSQv5LQV1nJN33coX8WXkXY7uyuloWNJSVcbz51i9HmA3WGlZPN1hpxe2ER2Hj98k4= X-Gm-Message-State: AOJu0Yz3jD2KVsGYoiOrcXOCxZtD0eRGBnw7WVhsRCWvdhnIM2rbGz+s 9ymLkDjFe/0UTyRHYm/n4WWwA8ttp/uo/z07UB3cbenohilKCtuS7IpydmsibnY= X-Google-Smtp-Source: AGHT+IG5fj7ZFdIyyAiLxezuDJ3duVyM4elViQE59ai+tbpBGEttaDRgy40oJg3eCLOBiZ24ZzBUmg== X-Received: by 2002:ac2:489b:0:b0:516:a6b2:f9eb with SMTP id x27-20020ac2489b000000b00516a6b2f9ebmr5761546lfc.69.1712562938010; Mon, 08 Apr 2024 00:55:38 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.16]) by smtp.gmail.com with ESMTPSA id z16-20020a17090665d000b00a4e9cb0b620sm4109828ejn.158.2024.04.08.00.55.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Apr 2024 00:55:37 -0700 (PDT) Message-ID: <01734d96-bed2-4f7e-bbba-7068f14c822b@linaro.org> Date: Mon, 8 Apr 2024 09:55:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] ASoC: dt-bindings: imx-audio-spdif: convert to YAML To: Shengjiu Wang , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shengjiu.wang@gmail.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <1712561233-27250-1-git-send-email-shengjiu.wang@nxp.com> Content-Language: en-US From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <1712561233-27250-1-git-send-email-shengjiu.wang@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240408_005541_759194_8E7E74E3 X-CRM114-Status: GOOD ( 21.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/04/2024 09:27, Shengjiu Wang wrote: > Convert the imx-audio-spdif binding to YAML. > > When testing dtbs_check, found below compatible strings > are not listed in document: > > fsl,imx-sabreauto-spdif > fsl,imx6sx-sdb-spdif > > So add them in yaml file to pass the test. > > Signed-off-by: Shengjiu Wang > --- > changes in v2: > - change file name to imx-spdif.yaml How does your compatible look like? fsl,imx-audio-spdif, so use that. > - remove | > - add anyof for spdif-in and spdif-out requirement > - change example name to sound > > diff --git a/Documentation/devicetree/bindings/sound/imx-spdif.yaml b/Documentation/devicetree/bindings/sound/imx-spdif.yaml > new file mode 100644 > index 000000000000..beb214b51a50 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/imx-spdif.yaml > @@ -0,0 +1,70 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/imx-spdif.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX audio complex with S/PDIF transceiver > + > +maintainers: > + - Shengjiu Wang > + > +properties: > + compatible: > + oneOf: > + - items: > + - enum: > + - fsl,imx-audio-spdif> + - enum: > + - fsl,imx-sabreauto-spdif > + - fsl,imx6sx-sdb-spdif This does not make much sense. You have mixed fallback with specific compatible. I suggest you to fix your DTS and submit proper bindings. > + - enum: > + - fsl,imx-audio-spdif > + > + model: > + $ref: /schemas/types.yaml#/definitions/string > + description: User specified audio sound card name > + > + spdif-controller: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of the i.MX S/PDIF controller > + > + spdif-out: > + type: boolean > + description: > + If present, the transmitting function of S/PDIF will be enabled, > + indicating there's a physical S/PDIF out connector or jack on the > + board or it's connecting to some other IP block, such as an HDMI > + encoder or display-controller. > + > + spdif-in: > + type: boolean > + description: > + If present, the receiving function of S/PDIF will be enabled, > + indicating there is a physical S/PDIF in connector/jack on the board. > + > +required: > + - compatible > + - model > + - spdif-controller > + > +anyOf: > + - required: > + - spdif-in > + - required: > + - spdif-out > + - required: > + - spdif-out > + - spdif-in Do you need the last required block? > + > +additionalProperties: false > + > +examples: > + - | > + sound { That's a random change... Instead of sending two patches per day, please carefully address the feedback. > + compatible = "fsl,imx-audio-spdif"; > + model = "imx-spdif"; > + spdif-controller = <&spdif>; > + spdif-out; > + spdif-in; > + }; Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel