From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17D98C433EF for ; Wed, 18 May 2022 07:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PhGsRXg17h4/wIaE0+zW1V+45l1MY9CcQoY7Yum5HaU=; b=A1HYVYEnCsPlnP sViEvXSSvfdG5xVwqPZZdJTT0UflExObisgfScD1ipsvE/gzOfWRZNvTwe0DDXeGrquOGgs4Yr9hg jPK1pqD2WBL4v/nWpCEUKQ0F7QDNx3eMLAXQAVWnxVZWy1kq1MQTMEZOebffjoY3Z9oQvEY/WoYCn xWXJWAKy8H1BqLdLxnVjTE/wzVq9d+ov9ub4DmY8p1xC4Kv6Aw6+hPDmw20cx6kgMN6IVZPAmdCTF zjF8YO76mCV7OtZ5SSBMj/bXHdVY2xlzOQmXea41gAw+jyTKmonGohwhrQjzr6Chrm50JR7gE6C5m PhgYjrlbxUML0QpaHMkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrDy7-0002Nr-Sf; Wed, 18 May 2022 07:19:40 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nrDy5-0002MO-6y for linux-arm-kernel@lists.infradead.org; Wed, 18 May 2022 07:19:38 +0000 Received: by mail-lf1-x134.google.com with SMTP id u23so2082862lfc.1 for ; Wed, 18 May 2022 00:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=uE38ie4dSRzW9FDj6U1cSKtlpjyoAmfqSD8WeGqIZ6w=; b=V4tVnXW4I9FGwv3pHQXWH7Sx8fdLQJwrMstJPHl9bZRUUYOg2pcGBpvWAR+dvhZaUJ dqmWA2BlaNO3fm+y75NRnNuQyxlnntvgL1ujn80JTsUEXmH+5rBDJ/4GlLB0JtH9XvUA kPCVtHBTX9rsDDOu4JfQ2Y/gMoBwvuYRwVYcHxO4ZnW1LabVY7w9weZE/IAE1bfyH3Ea qNS0Bs1SqwJfcCWeEuf0HDdyAM+WdyWOEjb6g4y1S/LJkRh24jBpAtnRleUXIjQ7ftq6 iNrbhJD3wgUAD8gLTWCFvF12RdQeYlc3uGh1Y3wex7Zj7s79ZZU2FZFFn+Z3l5bGtRkS VR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=uE38ie4dSRzW9FDj6U1cSKtlpjyoAmfqSD8WeGqIZ6w=; b=4RoY1jZPqVeos28TxgARfzepxWpE7a6L/BT53mF5OPiilVijPoahF15S9ExASFt6vD 4pJSE/O4VoKb0u7ICRQzdTpLc8Rd5NZniaSeGM2QnmwdRLCDhRB+eN1fw18Lvei/3tV6 2+0320bNYZfiLlJl2T2c/R793WtFhE/YAYHVoPIkV371hiNIJamYSoUxWRsaZvCwzRb+ x7PZy4mp/X1w00JQNXW2JKtcq52Ezljue5kAo8M8qN4/W18x9CAMxFoNj31xx4DSML6g JhZfEhKuHaEMNcnqTj2rJUR9TzbMYrbmNhgB/HJTbzb3x16VFLzSi7TsD1sPFoRpLSbh MomA== X-Gm-Message-State: AOAM532DPSqt6lLJI+5maWr4JUSqqTAZqjbzVUz3Rsx1yZ3HwuZHQwjZ xV0n161i5nbwjv6KWFeKAaUVqw== X-Google-Smtp-Source: ABdhPJzvx8mjcJx30Zvd3j2WPSo0iXGfy8QxdtkLmD+nJl8zb+xMYGpxRy5mCBgHUmVpkdiN9sT7QA== X-Received: by 2002:a05:6512:3183:b0:473:dffc:18ac with SMTP id i3-20020a056512318300b00473dffc18acmr18907162lfe.217.1652858374048; Wed, 18 May 2022 00:19:34 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id h21-20020ac250d5000000b00477b7264806sm125962lfm.9.2022.05.18.00.19.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 00:19:33 -0700 (PDT) Message-ID: <018b97c2-efab-699d-653d-c220a98f5ec3@linaro.org> Date: Wed, 18 May 2022 09:19:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCHv2 6/6] thermal: exynos: Add runtime power management for tmu Content-Language: en-US To: Anand Moon , Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , Linux PM list , linux-samsung-soc@vger.kernel.org, linux-arm-kernel , Linux Kernel References: <20220515064126.1424-1-linux.amoon@gmail.com> <20220515064126.1424-7-linux.amoon@gmail.com> <79b727f8-0631-5a96-fbc6-6e5d637bab7d@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220518_001937_306776_0F5BA6C3 X-CRM114-Status: GOOD ( 13.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 17/05/2022 20:45, Anand Moon wrote: > Hi Krzysztof, > > On Sun, 15 May 2022 at 15:18, Krzysztof Kozlowski > wrote: >> >> On 15/05/2022 08:41, Anand Moon wrote: >>> Add runtime power management for exynos thermal driver. >> >> First of all - why? Second, I do not see it being added. Where are the >> runtime callbacks? >> > > To control runtime control PMU, did I miss something? Controlling runtime PM by itself is not a goal. What does it change if it is enabled? > I looked into imx thermal driver # drivers/thermal/imx_thermal.c > to enable run-time power management for exynos driver. So you have runtime PM enabled and then what happens? Where is the power saving? Since you did not implement the callbacks, all this should be explained in commit msg. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel