From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34FFAC48BEB for ; Thu, 22 Feb 2024 09:00:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MCzzSFppp9r4xWAcRcyJMRC+wXVHvkPm2uYHEr1RUhs=; b=tTnB6KRtIb1tGB q9tG7e1lQawGV+3KluWiXlizhG2ubOjdI7k+MbZNpJkHtEB7Qn8MI4t+QW/vasExJXTQOtFA1UuhX 4pRD+4acVVc4M6qN+iPwT0FdUIuHv3foRjs2+XC7I/QV8yxxWkk5OiCxxb54iBHi/9ClhkqJb2QNE NwYQtt+2lZ9KkhfPw5RcwpiWOqqTMWWqBWeRgQBY6tGrmnBbjmGjxPH36/AZp/xb6xW8960PBag3C 7njiPN+ghN7TXqkf9sYCtlUkCVbanrOogEXTBD6/5DZetsEXA1OsPV/PfvI35dvSoFthLh4ihNnVH A1V8DpNMjQ5BqkGpzzLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd4w7-0000000496R-2wht; Thu, 22 Feb 2024 09:00:11 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rd4w3-0000000495B-3YsB for linux-arm-kernel@lists.infradead.org; Thu, 22 Feb 2024 09:00:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1708592407; x=1740128407; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=oPOojqwxGfrh4JaotqSISs3NqDyQRk3Qk5jS0FwNjQo=; b=OtWETloWMIW2EDMxEXanhNfgt40mjFHBVAnJXPB8aMEn4ekcb60bjJ6C K7K8Jpnktfhj0lLBoRg1EqWtX5q43DjYL7G24Ff2yf/zlTehUw3QObvxU zGlE7dKFOf6FBpUCe8QZmug92Ji13VZ2aj2w2qCAozcBsrQxiDU/iRYW6 uV6nq4q0UJSpPqBBDLAeBbRcBXxncSksMyRvs3TSEqdrj3XALzHZY+nLD eQ79yKRmyMFBxYiZDcFV+pmw0IECJ11Jy0GNan93EnUNdhMxG4m4b/HqW 665LcjCG3+7rjQswxImC2WepZpI+uHATGUvZm+Vrq0JoxxdN7/hO0eICL g==; X-CSE-ConnectionGUID: WQFa/OZsSpi2YH7CWy0HHQ== X-CSE-MsgGUID: MNmR9WRDRsy0isEsIEw3lQ== X-IronPort-AV: E=Sophos;i="6.06,177,1705388400"; d="scan'208";a="183919684" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Feb 2024 02:00:05 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 22 Feb 2024 01:59:32 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (10.10.215.250) by email.microchip.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 22 Feb 2024 01:59:32 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eLaJzB0wzoqzfM74TSMFjiBejefPfGigLwzJmJOo07yMpyx6+WRpX0sjGKQdf15ymj6eVDXdz+bUHcolA85chvk+kBYRq+6eGYoYTW8pMdLrZR9AUXD2RnbvQnXWK/TALL8ZpK+GHV6qoB/IUNDa0/Ki2sD1z8QImyfInXG8CIdXFQlqSrPS/knL4A8ekbioB6FOzQ9jN27QBEc8W+S5w9JdYBkCpn+6HiJcYpAdSpGa2MNVgPNn5Qyi7qmcHZsDYBOJviIr0B3LmIktARk4ikxVB3d6DobDEfEKlQKhxNYCkyqBE7T+5QY1RstVHS8bFtsnp7o399Z9uFmiJ1YTWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oPOojqwxGfrh4JaotqSISs3NqDyQRk3Qk5jS0FwNjQo=; b=ZS5szEE80fvp1g+pbo7MozSO9huHKQ4Bqn/cniabEfK24SPC/gLLU3cx/Sk6khfPj48l6ybYQMIyMaWlAVWXhOIhlw2R3f289GQDVBodI8AnWxsgBMhlqqLVWUyN0mPpFtSAwUGaTQGgSmLT5dnRLAyEiQnUSeMJKEDtHsQ5JFixPAu2knneCEM5+tZGe3r4lINXxRY92MUt+YTkypxG76Ccpl3jCwFmCrmfJ0sJlVZvtyjpsUHWQ5VtEGo6iwTo/XOvDbLmzdGI87mSe0IpMlpPHxjH+yz8pr25FDXAjp2uRSldrjimvl3XzKiDxoq7zXUUcqvIYjEqNqAj4NuzHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchip.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oPOojqwxGfrh4JaotqSISs3NqDyQRk3Qk5jS0FwNjQo=; b=qbZpFu+oSMdmC4ruTsHd+CZIqsq34zLvn3p/jrYn/PUckXE853vnXt0edltAih5dNulskRSItkFO+BWGIRSJ1KWWIWvAJq/TU2WhMH4eReeYhitZpO/uZb25XZDIyhZ+tl9L/iBtTlW/fcLhwE9yw22uDOQfds13q5jI+fMi0fbTNfx7/H9dePCZeQuxgIZCLoIKHnFPfAoUkbjZYJaRP+HYwNkV1mjYxnTUS1HLgaGZm3WbdVMGRVbSVQKY6/vq4WWHQDNyAs+1M1Iy2KiNH6fxULj4u2JcA6SsXLuMhR85UY2DHe9fW7G9NskiDQhqkxIYlfqkqHKcu45tBtx/2g== Received: from PH7PR11MB6451.namprd11.prod.outlook.com (2603:10b6:510:1f4::16) by SJ2PR11MB8566.namprd11.prod.outlook.com (2603:10b6:a03:56e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.21; Thu, 22 Feb 2024 08:59:28 +0000 Received: from PH7PR11MB6451.namprd11.prod.outlook.com ([fe80::80b9:80a3:e88a:57ee]) by PH7PR11MB6451.namprd11.prod.outlook.com ([fe80::80b9:80a3:e88a:57ee%3]) with mapi id 15.20.7270.036; Thu, 22 Feb 2024 08:59:28 +0000 From: To: Subject: Re: [PATCH v3] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema Thread-Topic: [PATCH v3] dt-bindings: interrupt-controller: Convert Atmel AIC to json-schema Thread-Index: AQHaZUKaRz7vhpmmVUKPKDUtfUx3wLEWD3SAgAAA54A= Date: Thu, 22 Feb 2024 08:59:28 +0000 Message-ID: <01916920-5ad3-4f6b-a53d-649dccec6999@microchip.com> References: <20240222035158.195265-1-dharma.b@microchip.com> <20240222-stiffly-squeeze-b4ec2b49a4fe@spud> In-Reply-To: <20240222-stiffly-squeeze-b4ec2b49a4fe@spud> Accept-Language: en-GB, en-US Content-Language: en-GB X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=microchip.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH7PR11MB6451:EE_|SJ2PR11MB8566:EE_ x-ms-office365-filtering-correlation-id: 594d33fe-1ece-41d1-c2a1-08dc338493bd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VpX6b1HAMzBfscjRYOb+66JjoXmoJiNn7I8a8hQHX+FbyYTFR47HJifW3F+CJ4QO9/S03wtQMm2L+fTkFyQWrVNhGm4/xBc1IyCeFp3RPGPiUEzXqlAi/Vo7fTz65X8kSRd2O35vquNi6m/Nb92ip6x9mbQ0oA9Z9js9dO1BC75kxh8lV+gFHgrM3dapXKPoPzIZMelRGGi+vyM4NjBPtKgBBnhel1FLOjElhxMo2W09lKXfPGsvsqhmh8jmMvVqIevX/UOtbHorTRjd1zPVK8VQRcM8Vr2YVj/hVN3ENrzC7r6GL7hy8+XsoLIA3i07fqXP6FcM4ibfvi9EnHYFV0UkmA15pi80QVRrYPedJL2q+oBA6jUv6zOd/LeePAx0+9dSudfiIH2YvPpF7MJWz8vllf14+yJsxciGucS3rBlrDF3Lyl+fpJyDOQUwzTwc6+8Ui8mxoDsQLHaKBm8R5qbJHCjTEkLTgHAGVCLo+ClNzRYLxKD6KNZ4mUVnrXBi38yJgL342XNZGyplEKHhwPcGIVV+oDBEUCr2ci7tezNViYujfFuE+8GxJsRrjByWtsI/7/+JrAf5Du6pCFEXRMeGvdc3neCIDbUhMlSdG5A= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH7PR11MB6451.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(230273577357003)(38070700009);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?R2hYZm9HVFFoZEFDaU9UcllXNXdjTFplVklkVzRxcXNBQmxpVlNZNkZnQVRD?= =?utf-8?B?V2MrQldiR0xjNzRpd2tlS1VicitUMjZnWWJRdlZnNjh2cFVYdjVub0tCUEdL?= =?utf-8?B?bHArQlZienlhRHdqTnBzdFN3N1RaR1ZPSzJQakhPVFAxTGUydnpKeTNyZUx4?= =?utf-8?B?T1VtQ0tQTEhHcHdkMm5PNFAwQmVkTWtmTXA3MCs4NDVYMUxyVnIrSlZFamRw?= =?utf-8?B?VlJLMTM3K1d5ZUg0L25qQ0lwNXVwNVU5VW5odW54V2lXY0lrRkNLL1ovb3R6?= =?utf-8?B?WWdvNzNHRm00dmN6cmJoZnZOb29hOCtlc0h1eTVMUnV0MXA4THBISytNZzRV?= =?utf-8?B?eUpwSmdNeTY4dWNtTWRMcUZNcnVnUWwyc3NxK2U3cmVsM3B4a01FRXIzL3dN?= =?utf-8?B?bFlTa2gvckQ4YnZXRmdRRGRmaFFYbFk1dCtyTy9USjdsUTdMNjR3SWhYbzBl?= =?utf-8?B?MWFjaXcraHJKR0RSWXU4bnlWaXg2TWtNZWo1YmU1Tlh4eENLNmFuTzhHZGhz?= =?utf-8?B?WmlLQ3RUNE5LWElLNzBuMkNDT2VPUWp3aFJ6V1JucVErWExVZzduZEdFcXRP?= =?utf-8?B?dVJibm5rdFJaYWNsSkNmZEFEa1I4VlpZbC9hanV2QXJVaGdPYVJveW1SWHhu?= =?utf-8?B?VXpmKy9TdzVIZDkzZXNNOTVTdTFYK0ZmUlVLSFg0K1RDNGtiOE9oWTVYam1i?= =?utf-8?B?OFBUNXlXU0FKWkE3TzdXYmlZRG9jNS9lNldkbWVhZWhZeU5rZHJ3Y2s3cVlT?= =?utf-8?B?RGJTQ0M3MjVwUkVnOXNmanJncHJDY09MSm9JcUlYRitObVQvYVdYZ0R6eGU0?= =?utf-8?B?VFpGbHpSQStEL2N4ZmhnQTZZdEt6QVowekdnZ1dqQmdXeEMyM0c5WGQ0bjJi?= =?utf-8?B?ck5WVG5NTHVLNFAvcVdJRmRrVTVMbHg4WmRJZGI0SDRJcTJXdVFpMFhQYndk?= =?utf-8?B?NHZOL0tINzJMeHdocmJ4TmFQbUdqVmxXcjFqMU5LeElrSWZZUzFDbmtTRFNS?= =?utf-8?B?TVpndk96cDB3REVVdG5wWUlrLzJ2eTVzQjY1Ulk0S2JKNHVlVis0eDJNWk1U?= =?utf-8?B?emhMTTFwVmNremhLT1ZWOTN5RkxLblJGeWhXNG16MWtPSFl3Z2V4bjJJV2xk?= =?utf-8?B?MnJMVjQ0WFNDWWhjOWpYKzlwdU1pTFR1WExFQ3QxcFBRemgzUHpXanZTSEFQ?= =?utf-8?B?WVZTM0hTNWY0T0JTbWdCQ0xOU0NsWXZvdFZaTGlJUnoyVDc3ZWlkQTlsZGsz?= =?utf-8?B?S2dsWFRaWCtRa0M4ZXVIK2JzYU1ocUNKWjQ0c3Q3aTQ4TzBqcnFFeHdVOG41?= =?utf-8?B?SkNnSVV4cUVEbDhpek9PRDN2RzFPWmNPZlM0dldkSG54QkRTUGlqUlJYMVNq?= =?utf-8?B?TExQTGJiMEhuaXR4dTRGa3dGdjBOb1o0NlF4QmQ2UVN5TDBrb3pab0thSkpI?= =?utf-8?B?cTRLTGNDbEVCQ2FKUjhrbHF3eHIxRFgxdFhkMVBHK2ZOVDVPM0ZKb3V2ekZX?= =?utf-8?B?Nk5jT05JNTZ3emYrRmtCb1EwT1ZzMTgwQ09CVG8zeUhWMGpCRTgrVVl0NVk5?= =?utf-8?B?d0pCMU0yNzhYOEZKTmkxUVU4ajZrakNlcTdWQ3NPbTZiSkZYUXhJVGtZYmlG?= =?utf-8?B?UFBJUHlXOHlEZE9HZXY2aFRXR2xZZE5wUWFydnJiR0J1Q3p3eHhFcXI2cGw5?= =?utf-8?B?OXkzeDBZSGNNdlNObm1jYkZITWM3WmhsaDJ2ZTczYlRrSU1zYjF2cVBkL1l3?= =?utf-8?B?V3h0cFh5TStMa2NMNklUV3lDNFAzUGxZWE9xTEREOUU5emFOYXltVmVXMFJY?= =?utf-8?B?Z0p2a0VRQi9PYWtKdThXbFZGbmN2YU82OHNNWUd2TWtVRGJhcGRwWWRYZGlP?= =?utf-8?B?L3grQVMxT295THJLYnk3RDJ5YUd4Z1NRY0FxK1RQSndJTG1PZDRWeFRmZzI0?= =?utf-8?B?NE1yWk1Cc0ZITU5wem1vMTN2c0pEOVpYUFFtY3NVYUxWV3dTU01MRDgwdHhq?= =?utf-8?B?MUNmaVYwZmYzYXJNaXdzN3BrNU5uMWo3SktpcVlPd0s1ZVRtYlVnQnk5azk0?= =?utf-8?B?c214cDVOZEdHL2VMTWNheTliSXlDRnliN1hGbTZPVDhOalE3N3NBYjJkTlF6?= =?utf-8?Q?ERShl0PWxWNAZyTcpphXeea1Q?= Content-ID: <6EDCC0E2FA5BB548B9DAD647B4E8D203@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB6451.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 594d33fe-1ece-41d1-c2a1-08dc338493bd X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Feb 2024 08:59:28.6775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PZVqIJJfOEQIx4iG9s4ebXJ5o4m/4MKn3h9qmZdWdW5LDrJ6ihAqwtxTmB5ZCG30yS1n2yM/4Bgzu4OmpLCzJw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8566 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_010008_214465_E92D845F X-CRM114-Status: GOOD ( 15.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robh@kernel.org, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, conor+dt@kernel.org, Conor.Dooley@microchip.com, krzysztof.kozlowski+dt@linaro.org, claudiu.beznea@tuxon.dev, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 22/02/24 2:26 pm, Conor Dooley wrote: >> diff --git a/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml >> new file mode 100644 >> index 000000000000..0d51bd78bf2b >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/interrupt-controller/atmel,aic.yaml >> @@ -0,0 +1,89 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id:http://devicetree.org/schemas/interrupt-controller/atmel,aic.yaml# >> +$schema:http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Advanced Interrupt Controller (AIC) >> + >> +maintainers: >> + - Nicolas Ferre >> + - Dharma balasubiramani >> + >> +description: >> + The Advanced Interrupt Controller (AIC) is an 8-level priority, individually >> + maskable, vectored interrupt controller providing handling of up to one >> + hundred and twenty-eight interrupt sources. >> + >> +allOf: >> + - $ref: /schemas/interrupt-controller.yaml# >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: atmel,at91rm9200-aic >> + then: >> + properties: >> + atmel,external-irqs: >> + minItems: 1 >> + maxItems: 7 >> + else: >> + properties: >> + atmel,external-irqs: >> + minItems: 1 >> + maxItems: 1 > When there's property restrictions being applied, move the allof down > to... > >> + >> +properties: >> + compatible: >> + enum: >> + - atmel,at91rm9200-aic >> + - atmel,sama5d2-aic >> + - atmel,sama5d3-aic >> + - atmel,sama5d4-aic >> + - microchip,sam9x60-aic >> + >> + reg: >> + maxItems: 1 >> + >> + interrupt-controller: true >> + >> + "#interrupt-cells": >> + const: 3 >> + description: | >> + The 1st cell is the IRQ number (Peripheral IDentifier on datasheet). >> + The 2nd cell specifies flags: >> + bits[3:0] trigger type and level flags: >> + 1 = low-to-high edge triggered. >> + 2 = high-to-low edge triggered. >> + 4 = active high level-sensitive. >> + 8 = active low level-sensitive. >> + Valid combinations: 1, 2, 3, 4, 8. >> + Default for internal sources: 4 (active high). >> + The 3rd cell specifies irq priority from 0 (lowest) to 7 (highest). >> + >> + interrupts: >> + maxItems: 1 >> + >> + atmel,external-irqs: >> + $ref: /schemas/types.yaml#/definitions/uint32-array >> + description: u32 array of external irqs. > ...here. Both work, but seeing the restrictions before you see any of > the properties is not the most understandable. Understood, I will move it here. > > Cheers, > Conor. > >> +required: >> + - compatible >> + - reg >> + - interrupt-controller >> + - "#interrupt-cells" >> + - atmel,external-irqs >> + >> +unevaluatedProperties: false >> + >> +examples: >> + - | >> + interrupt-controller@fffff000 { >> + compatible = "atmel,at91rm9200-aic"; >> + reg = <0xfffff000 0x200>; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + atmel,external-irqs = <31>; >> + }; >> +... >> >> base-commit: 4f5e5092fdbf5cec6bedc19fbe69cce4f5f08372 >> -- >> 2.25.1 -- With Best Regards, Dharma B. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel