From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58BBAC433B4 for ; Wed, 28 Apr 2021 08:29:32 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2CCC61426 for ; Wed, 28 Apr 2021 08:29:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2CCC61426 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tcT07S2HnLRs+YnYoY9Y7GJQy7aut+A9310aKOg1ZFE=; b=EhQMreuEA9fZVpvUluKmpgQGY KKwZLKl805w5h0He5LTc4Sn4RnaEHGSPRhLZx/owbGDJg66JpTgQh2eqZY8pG6q26Gri5TrPHB729 JQFMgf8/bUWBO6ITc8Xr/yXlh3Aj6cowa/whk31UP+82zfv7AiZEJtwf6S/QexSWA4mZWa04gLd2Y Y8GUrT4W3S3ZEWi/SpY/cPIWMtm5DkfaCWHioRPJcOHKZO98MM/Qr8QMbQwF4w7l/tHuiRTfjcXxr 9af648a1GJjtZw+7nxKWYrTDF8U7+C/qm2sdJ+gLnVxwP2UoPBBjsHj08sNo+aDYKrh+wkPVPv/56 Fcapsu6cw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lbfXo-0037G5-BD; Wed, 28 Apr 2021 08:27:41 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbfXm-0037Fm-BH for linux-arm-kernel@desiato.infradead.org; Wed, 28 Apr 2021 08:27:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=6qfmZdcpH0atvAKrSvWIjHVKLVpCR1abzdfU5QijpYs=; b=l5XyZxbqR+DrP7Yig3rHaWjQtT ryNf2KzRXirTjLyKJWtnxKRVUq9JGRW2GmoYYlxBSq909iBKNFXPDMypzrK/EIkSV4N2E6NyzJqgA nhlYxJbdkRvBFFWCIa4QW6JFRl3LZBm5fGjLpb2BzKb/lwYL+XXYKuC6KNCUiI98QXNET7Zz2//WP QuBEbE/m84hR5rLSDij63G+u93cEVgYrXH5TE3N2uxV4cxq9Vv+8BERCPXQoB7U4Y0kO0eEMmZz3g 3hCkJD1d722zIDiUyYyzq233dCEC5D7e9usFJ1R8zdlF3V6LrqzG6G5fzK15ZdL6aRcT0oB65dTXQ rdFiYsbw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lbfXj-00HHit-SU for linux-arm-kernel@lists.infradead.org; Wed, 28 Apr 2021 08:27:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D023061428; Wed, 28 Apr 2021 08:27:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619598454; bh=MMdojTNsABdHbx90yhpxY/qSAQ0sMQ1zeneARF2DHr4=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=dx+sIiSpWRqddOtUTc+JhzpKDPpbLGDkvs06tkwI7Yw8y3HamdWE5plk9jwEs5j2z Tm/1DpIKdz/3GH/LhLtT0pLNxVQPRCoLmPgBNJScH69Emi3IWiqMF4NEMKM3fjwBC9 BqjJeCTbPR9hZczow28fzc92gFyeQkvkWnq8+mZsr08lPJ5SDQu3yOxDRHe88cxQO8 252VpD1qJM58PgiiPzqtk0kLyNPHH96i8tmxmWnlVdgicI0Qqw2MBPZ+LngZaozBsv qt+puDwUSSzTYbu1SUoQ6pG5e9ITDmsOSFio8Uw8uTz/pEb7z7g2j33u14HI1IgIkK k2f+4ZFQ+vvCA== Subject: Re: [PATCH 58/78] media: exynos-gsc: use pm_runtime_resume_and_get() To: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Ezequiel Garcia , Hans Verkuil , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Sylwester Nawrocki References: <9c7d683907b9f9cf4a99f57f978671ec7f5a1dbc.1619191723.git.mchehab+huawei@kernel.org> <20210427113055.745d0560@coco.lan> <20210427114235.45a7b2a4@coco.lan> <5f6088c7-c839-f097-737f-b4234c413eac@samsung.com> <20210428091302.64af1e5d@coco.lan> <20210428091707.3c99d124@coco.lan> From: Sylwester Nawrocki Message-ID: <01a14e06-b7f2-7246-ad12-4a13a96622a0@kernel.org> Date: Wed, 28 Apr 2021 10:27:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210428091707.3c99d124@coco.lan> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210428_012736_002197_24975415 X-CRM114-Status: GOOD ( 13.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28.04.2021 09:17, Mauro Carvalho Chehab wrote: > Em Wed, 28 Apr 2021 09:13:02 +0200 > Mauro Carvalho Chehab escreveu: > >> Em Tue, 27 Apr 2021 13:50:44 +0200 >> Sylwester Nawrocki escreveu: >> >>> On 27.04.2021 11:42, Mauro Carvalho Chehab wrote: >>> I think if the device is brought into suspended state (e.g. by >>> disabling clocks as above) the pm_runtime_set_suspended() call >>> should be there. IOW a following sequence: >>> >>> pm_runtime_disable(dev); >>> if (!pm_runtime_status_suspended(dev)) >>> /* put device into suspended state (disable clocks, >>> voltage regulators, assert GPIOs, etc. */ >>> pm_runtime_set_suspended(dev); >> >> Not sure if this would work, as the clock framework would try >> to do things like calling clk_pm_runtime_put(). It's done in multiple drivers this way. clk_pm_runtime_put() operates on different device - the clock supplier, not the consumer device. We just need to disable runtime PM for GSC as the last step, to avoid any possible v4l2 m2m device_run() call with runtime PM disabled. >> Perhaps an alternative would be to just return an error if it >> can't resume PM runtime, e. g.: [...] > Nah, forget about that. Despite the platform driver having a return code, > support for it bogus: Yes, we can't really stop remove() from driver level so as much complete resource release is being done as possible. Regards, Sylwester _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel