From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8EAFAEB64DD for ; Wed, 9 Aug 2023 13:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:From:References:CC:To: Subject:Date:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RRJWk4tZqf3LShyabbyXQBamm9J8z7sSmYKrwjNIKzA=; b=Rw44Zp+SqM4OmQXvJ+dgzaau98 m4uARFRpEyRFH6lZnJgO/5zrhzOyro/h6NlupGbw/GuGqfFt72Y3J+tkd/YAkECh6ZzWSa1+Rmr7r yLeZF9gNJeL9BwVJyLJcQQ+OX1VijSOngEUNRh1Bz1WW4RnYJUfMdeqFVI9XNpFvNSr6ZSbbEvu6a oXcEH4F8+VwDS+5DSc0GUelEXBAS7O4eCGCa4tQwQK5T7fE9lCyScqhAS+QDpdRkjSNSHjwVCyPW1 xeN0nUbjUhPlGb1lpXRKQSy4ODt5meQat6TbE0wgNQ/Z6zf+Ndv5DMSmMe9KTsxzA9JH1S13+jmR+ IDAtSaxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTj6D-004yu8-0T; Wed, 09 Aug 2023 13:19:41 +0000 Received: from smtp2.axis.com ([195.60.68.18]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTj6A-004yrc-1b for linux-arm-kernel@lists.infradead.org; Wed, 09 Aug 2023 13:19:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1691587179; x=1723123179; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=WXFlV4I7SADXiSgWdW2XHqolRiqvSTrR54BxtWYUzJ8=; b=fFSRpkGqrMwJL0hVf4rZDXxQgq8PCO4gW39N5S6ce3j3Vcpa/j3S9yWN 21xjmdble7UDGV/2jr3xL7Qv1Pr38h4grY9Y4yD+MF1VciWnj9gRAcbow xhXBhw8oeMHcij7Ee+SVwxWowwQbUtp2UrITsYeLc/qn1ySAtFKdSRS01 uJCwmLHyCTjrtZv3QHNWRfz3gBgRDG2jPz3VhpfmgrmYMwU5uptdM0YPR 3VWVZ5C0ID/2VGme7Ll9FJ3yrXbK7klIeaQ3oNTswGSQ/S5f3A0Mwb8YO wHrSSmqEYMuUyQ0D0hNYptqXlAP8QV/yJfgT5HdFRKwd/DpTw2U1CR7Ge Q==; ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dfXQBMN3dvoAAOu7pv7cSKTVCO0T0x159iK1r8DKgpDBRHLVhW1K1YukLIIoMx5nSuYyErhx4+tYYIig4CnBdF3eIlLIFvDDSlc3uP2Sta7w0aDiKd/FF168DvLdjTb1CsxYCcfDPGXGLij1NvhHTMIyKeKKM6p5x+khdGcYaK84BZmm7x5rDb36i9/BaNCF/avHnUhWW0q1edmq8XTChofFsIUVrBay9y/ebrrw6ZVbZQ8c/lq2d5urOxWPXN09NyGgk7sLBR50JvW8s22hGGV+DgChe7M2VPiDAvP/77IH3Mkdkq+nnTJPfeSGABmbsUly/Tyka+On1Dk9xwviIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WXFlV4I7SADXiSgWdW2XHqolRiqvSTrR54BxtWYUzJ8=; b=VhCMcosoEEaznYEIKCEGB9CxFjGGZtZ1XQZa0Jsnrv5qXQaEcWpPEh4NJapRFybnFoTYviGie0tjs4BvXjxOVGb+cijU7tweHQAShvFKiszHQmol9WfwmfZ96ScOwfj4KlSH5pdHXqRktX80abm7+IijpJKFKFETqyvLRf8Ni6bzKs7EZqhFgj6X5lLqvqI3rE46YrIXfo+zvLhSpOw7cqf5fkxUoqSAlC6ltGBSobr4dCjxsJahWJYll1v5oyrQ8BjqGL7F2gbr8oEG5pw7YqlE6G3oxwjE0nrz97gzDiSAbpzi2P7LWBqUJgyj/fI6sgHFqakwIeloIOR83ENOBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=axis.com; dmarc=pass action=none header.from=axis.com; dkim=pass header.d=axis.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis365.onmicrosoft.com; s=selector2-axis365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WXFlV4I7SADXiSgWdW2XHqolRiqvSTrR54BxtWYUzJ8=; b=V2XIOQO2EtHRbRYoOm0IP8/TialO0bA04X55WbtDmxZL81r/uW0wATuwm1qnOwUZyNypVbqkBgDN7Th4LJsfDGHIFrSRC4LRo/vLulEl2LGQhJ2F31MYAIEtnK9JuI6UOiD9h6nPOUZUp5AwvVQb5XztXpWh8Qpw9tkKeJ3NUT8= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=axis.com; Message-ID: <01a3c57a-bef4-9a9e-3f8b-0231653232a8@axis.com> Date: Wed, 9 Aug 2023 15:19:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support To: Krzysztof Kozlowski , Alim Akhtar , Greg Kroah-Hartman , Jiri Slaby CC: , , , , References: <20230803-samsung_tty_pm_ops-v1-1-1ea7be72194d@axis.com> <9967fa81-f3f4-04c4-a837-d507a19989cc@linaro.org> Content-Language: en-GB From: Anton Eliasson In-Reply-To: <9967fa81-f3f4-04c4-a837-d507a19989cc@linaro.org> X-ClientProxiedBy: MM0P280CA0051.SWEP280.PROD.OUTLOOK.COM (2603:10a6:190:b::35) To AS1PR02MB10348.eurprd02.prod.outlook.com (2603:10a6:20b:473::13) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS1PR02MB10348:EE_|PAVPR02MB10009:EE_ X-MS-Office365-Filtering-Correlation-Id: 365b516d-c897-458b-b189-08db98db4339 X-LD-Processed: 78703d3c-b907-432f-b066-88f7af9ca3af,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7YSY0D2gMfox+TdkK8YfxKyIk5MjyaoibMaAVNK1zo0QiaUgKMwspWLRbIno3WX8B2Co6vCpEl4Z8uP9Rr+FnicyNoktk7nLvgQi/XeeZSMh7AKuZ7t/iW2NYI9J5r/Oa+ixbE073xTG3atvxBR4ujHC+5RyQ9pAvK/qgWCDwbbtv3+PdUJQakePA1oz6J2gVWs+kpCgDPXu/s5lJz7Lj0JeTZM9YREoUjGdRjTHzeVG4PMFmU9XM1kW9Rxiacni2IlLQ+mB+PwGRffOVfb9m9eLlKmlQODvDJMnCifZ3i7e9JxcS1eHAyzq2eMCDgmYGuOgN/HHcku7cjuIlFBC5XlCsmCElcgle0VhWMz/d5ft6h0XYeuvR+l7VBl/zwok4YwCZm7g8vtMVuFIFLx24PG6oX8f9WPGuFVvqh0ksI1Px6LzAC9yX09f1s+1ZzJFm2EIVt1QbIiFIoeIh66GiXEAmopCSzomMl6ioN7PzSU6gshda1QYqm0eIJuNmrpRBM4VlDJRzVSEs6TPR+umwj3APu3CFOiIQHJJxFmNUPizbXmXB4QbP4LEoGUKTs1N0y0RJAklx7VFC+Sru03TRwkCb6h08bTUUWo/7ZL+DoSVqbHvKatNeB79j4LWwGB2yJpfGNE7SjMWLYS6aqBslw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS1PR02MB10348.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(39860400002)(136003)(366004)(346002)(376002)(1800799006)(186006)(451199021)(86362001)(31696002)(31686004)(44832011)(5660300002)(2906002)(4744005)(41300700001)(8936002)(66476007)(66556008)(8676002)(316002)(38100700002)(110136005)(83380400001)(36756003)(2616005)(478600001)(4326008)(66946007)(53546011)(6506007)(26005)(6486002)(6512007)(107886003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MENLQzJaYVhabmxYVysxUXF6eTVzT2p5Tzl5WUFvVllwYS9XTkhlSFNtWThT?= =?utf-8?B?OUFWSXBGOHAyZ3QvZElheVo5b1dvbXhFcUw3Y1RpL1ZlNUQ1VDdkUjJNanBh?= =?utf-8?B?YVFaUURRc2YzVGFZQ1hKb0g4Q1RLcG9EYnhWeTdGYzRJSTdQOXpaWndLd3Q3?= =?utf-8?B?bVFUcFpSYXF6c2NLUTd1ZVVIRlVWSFMyaXZpRTdWVVEzNjVWRERNdCtpYTNO?= =?utf-8?B?QU9vcTdSaFp1QWlMMEFZNi9XODZTM3E5RmhMZ0pWVXc4dUZWbnBvZ2hMVDNI?= =?utf-8?B?Z2JEbnlqTFM1RWg3VXBwakZ0NisrVkQ3cTlwUXNDUVZrNnZ0WEVnQXZoaysx?= =?utf-8?B?SHMxUmhPTDJ2ZjdQWE5hVHBZdXFIY2pjeiszczNHVVl3YnFPd2RKL05xM1o5?= =?utf-8?B?dC9URFl4WmM0SnpoZys3R0V6SDBNdGhIOC9Mbyt5L0tIYnJQMEw4WTVBeWZ3?= =?utf-8?B?Vjc3SGt0WHNRQ2hxenZ3TjNkaUR2Rzc2aXlQOU9ocHNEQzR0a2xGeDd4WkRo?= =?utf-8?B?blJkSWN1dXhiK0dTb1lvMzhrNE9Ca2tIVFNiVnBnV3RmUStoSllzQmE1RkxI?= =?utf-8?B?RksrL1BrRVlwa0R4cFNQREtLWXNWc2xhUXp3ZE1ULzliaEJMRGVzbmlpYXBv?= =?utf-8?B?cW1TVGFaRjcyNm0wSFhhYXlCblc5R3UrN3lmNFZXdXFMVVJ5UzRpMVVldjJy?= =?utf-8?B?QXMyRlNPelFUc3JPZUhzNmZqRGk2R0NKbEpabWpQRS9aaEFIR2VuTVhDNTN1?= =?utf-8?B?K0FSZkIwdUh3cWo1bDFCR2RZV1ZDVHdzNUlpOFhJZ0lQYmdLOTQ3bmZFOWJr?= =?utf-8?B?T2VtVytKMG56VkNyZ3ZPb3pucXdkdGdaSnFhallIWkhPSlN5T2gxVlJ4N0gx?= =?utf-8?B?Nmw5WFV3RmJwS0pWYXVOWm8ydnpBWG84WE1CaUZWYjBXeUJ1N1ZlbGRNUTN6?= =?utf-8?B?RUFwcVhTL1F5QlNOR0k4dUN0Z0hEQVE1UEpvelh0MUV1SFgzUFlkcmUrL3lI?= =?utf-8?B?VDJkY1hYTFIrWnc3NDlmcGdUbk4xV2IxL2JRRitzMVo3QUpoVVQwTTZEL1JI?= =?utf-8?B?dzZNbzlnRkZ5am1mUTlVaW5lUEtBSXlkUzZ6ZDM2ZDlNbHh1bWtGSjVta2VV?= =?utf-8?B?SmxCTDZqRlpzaEx6YmxDa0NTNXVpdXNzQ0tsSjl0ZnNCWlYvQkpIbXQvd1JZ?= =?utf-8?B?c1J5SWVELy9LYThXVHpMQmNNdzJUSTJyeFNQaWZadUVwOUNMTVhXaTBYZW5q?= =?utf-8?B?dWUwMlBpN2RBT1hwUG5ONVl5ZWpBQy9NVTFFRlZtcVovaUpGSURKcWoyNktZ?= =?utf-8?B?M3BxeGJNVjJxUGxFK1BZZEVKNFBpNG9seklMenZXcTNsaGVPak8wWThoZ05j?= =?utf-8?B?UWFOcWJFRFA1SFpyRC9HcjFBcjZScGEwdUFINURsREVrdmJuV2tNbGx0VDE4?= =?utf-8?B?dWM5ZHRTc003N3E0anh3UU1UZDN5cEhxQTYvWWE2enF1T0UyN0xSZXdIVEZD?= =?utf-8?B?dGZpZW9BQ1Q5elJiVWFJd2ZhVUduL251anhjbGlIOFdBc0o5MXcvNWwrekd6?= =?utf-8?B?VzJMWW9WajNxdzM4Wm16UTVxS0c3QzBacTZHOGNCMFVVVGIvb2trZVJQbXpV?= =?utf-8?B?UVFiTGs3Z2drQ3RPU1JySEtDczZkWkdjaHpTUElySk5vMW0zTlBBVjJJMDYw?= =?utf-8?B?R0c1eHRhRzN6TUpFUUxscEEvRUtZODg0WVJZQjM5eTFUOS9BcW1jdmJoUmYv?= =?utf-8?B?SkNoTTE0S0RwcWNPaCs5S1hTcHdCaVlVMXNoUFVhS2QyT2Z3YnU4S2I5bHZM?= =?utf-8?B?c1N0YllkeVdhUXhYSWVBM2NmbmJZcVc2ZHhKQkNzQzFHcE1ZdjlCcGJQVGdM?= =?utf-8?B?Wk10ZGJYNjQ5MXJmZk5Xd1V4VnZuNUhIUXNFTWlJNnlsTndveTV4Um9zQWRN?= =?utf-8?B?NjZZcmE2K1lWQVpHVVJxNGFRWStHdUU2cXJVbFhBdUlxem9HK2cvTjZTVCtD?= =?utf-8?B?S0YrdUhyUmsyaG9KQ05BSE1VM3dpTmZmcDNWcXFPbnE4Q3R5UnpTU1grY0pX?= =?utf-8?B?ZnRGQ0FiRldpaEJoTXUrNE11YXFMWGZ1Q3VLN0tIMnB1UEpramwxTTZBK2sy?= =?utf-8?Q?vsTc=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 365b516d-c897-458b-b189-08db98db4339 X-MS-Exchange-CrossTenant-AuthSource: AS1PR02MB10348.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2023 13:19:29.7367 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 78703d3c-b907-432f-b066-88f7af9ca3af X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lkYY0BYsQDOwbglbbnm6A/YklOmoEPpmnE8tmNcvq8up2JwdkOE7YB5NNZ1FWe6X X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR02MB10009 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230809_061939_127672_C7B0844B X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/08/2023 15.50, Krzysztof Kozlowski wrote: > On 03/08/2023 13:26, Anton Eliasson wrote: >> At least freeze, restore and thaw need to be set in order for the driver >> to support system hibernation. The existing suspend/resume functions can >> be reused since those functions don't touch the device's power state or >> wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and >> SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers. >> > Looks sensible, although you should also test the other sleep methods, > e.g. suspend to idle. > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > Yes, s2idle still works. Standby / Power-On Suspend and s2ram we don't have support for so I can't test it. Thanks for the review! Anton Eliasson _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel