From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB64BC25B74 for ; Fri, 10 May 2024 19:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N7e6dyTgOchQat1Zz7DqHoEMnVQLpgD3Vmxw8Dh0DgE=; b=p52/JerAIpLKAiuOz0uH3eGbmp yKtC7uBmQxE861+ZZbve95jHH3mOIdCEMkhMDAo7wiZwwFCngUwZtmOm+vc/7+VY0OPGFHEWj9/GA lqKkfY7eiEMNQsAdA6oS3BHPQgdwirbSKegJ2PaN7wx0uiRXrrMre0LxOBywjwbIp0EY31a7Hyqy7 kn0Pfg/Cpf2yj4FEVRTmqMRTL6gCs6DT/M01WBB4izdHb8ei74V/lxHhC0Oa+Hnbi7OSd3CTB60dL GZq9tnxuLST6sGQ8i74vd7wJ9TQJ/Pb3YF2K399sh9YwVKuht38rSTaY3U+aXrhj2URKMtoEVC4c7 gcH0Ducw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5VV4-00000006ClU-335v; Fri, 10 May 2024 19:01:46 +0000 Received: from mout.gmx.net ([212.227.15.15]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s5VV1-00000006Ckf-2Efg; Fri, 10 May 2024 19:01:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1715367694; x=1715972494; i=wahrenst@gmx.net; bh=r0K6LUzeSfFM3cfAryelCHAy7vdffcHD56EhNe6U6Fc=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=TF7n/g/xGCdXYQrjRdgg1eTRWR39nlDmazQkPk1hdgRMWid7k2VfJClTmTKFSpFI yXQk8do7L3xXOB9jfHZgSh3rNfmiBb2QUIXz07D4EgIDOwu9tOh18lPd/A2MuxWsJ YMaQOJIEIcmHCT40Se32E5DvR0NiHUGx+iDLoOm30OkFBMKSzn2D6U5skg6jzNwm8 M3OOi/XxysQQn1/rKv7P8OrBxeaj7ia54nJk4lmxqWGkekShLgWojmX4jniVWToNG fSThpJfP6Q0k74GmU1/ojU1LqQHVS4cAdFJMqdKI07lEO0FqdOnCNFw3yNmMGxMbO 3vNcghzvrCLniwezwQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.126] ([37.4.248.43]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N9MpS-1si3Ks12CC-016NY0; Fri, 10 May 2024 21:01:34 +0200 Message-ID: <01a7a263-9de3-468c-b438-c16f2c73872c@gmx.net> Date: Fri, 10 May 2024 21:01:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: mmc: Add support for BCM2712 SD host controller To: Andrea della Porta , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Ulf Hansson , Adrian Hunter , Kamal Dasu , Al Cooper , Eric Anholt , devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org References: <1f0c4fa62d6849753e2138cce5498693cfc3a230.1715332922.git.andrea.porta@suse.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: <1f0c4fa62d6849753e2138cce5498693cfc3a230.1715332922.git.andrea.porta@suse.com> X-Provags-ID: V03:K1:VVVD62vh/QTwMPK7v84RK80zkzw/ZcaJNUYdmqwHzZHVl9s9ji7 A6OlGA+19sAZuEiEd4SpvmYckNwKP03ZuCStO5U2fmMXGMNG0QhIHa8ODlRHVqKW42CKh52 hgShO3qEqgNRUDdwrGsp19eQkjDX/dKou0BSoh/OYICHvGSTZHtwFRSFWy9uDwHoXctzhZS Tf4QXtNR0A0J1q9eBZuHQ== UI-OutboundReport: notjunk:1;M01:P0:JsqNtMBpAPQ=;WrE82vYxBS55rqDrrooFi6unvXR EVZjm4eXXeBxDQYx9R/kFrTZkdcVoWDx3LwaJ8+dgJh1PA/nMCAYyTrNwGzu2SayDpTebyC/o E4dZJwpzxA39NQ30/Kbty8XfqRPx/MbHe9NA9oS7GE/nMoGwkgaywx+I0Wk3LlU5/q/A10Nw6 Vc9MF9JIH7Ex4HKSUu+5yO5jh/aQHG8qfHZk/W4jd5YGmQZEfCbrx7ThibyboCJxQQqUVB+if 4pN2vL2Z6ikCm5LfzIiAxWHz96zJny9wt9D13Q6jML2XjcnnUd6MTqZxTij00A1XGsYmS08LZ A0wkiHUXb5Q1GMHKktqP44jiaHRwdsTRb65/IUlcCdNLVwK53r/OidANRNmPAZBEDEvbR2wP3 r2kHKPDsESbBlLZrOG+DmYRgZCPsBS9u5iBc25v2d7uAIAPn/P0CiBZQrG1OYHYkwuI4cK08E sOt+4ZKREHJQeK+rU8up2x27RinAkzGGPOvpH/ZqEnCIRAZYHwYp/fvt6X1aWr2//wjRcfoBg 66VsDiiuNj4/u2SlxGagz63VnWdowCJ/0qKIlEtCfdDhbSwGd3nHVAaE0/jIr9r4TzArXgjhi d5MdH0T1epNqZmXBpmgsHBMPt0EgOgisuACFwDY1xUHwwT81HTrb8uuj6qWcEVNwxdACFPGr2 2AH+Ll09Rq1fx4GcuVMAotUw3q5XoFivxljYUZmTzpF+FbJUPZteiu1FSXg0Zx/BRd5UjdUIS ve5VJ5h4tmJ0Gg8QTctizR0n/gDczdj/inbtheAsIORhtjY9sTVIPgOQHDJT+yzjLMbUm/jnV GKkOFK4DbZLk9a0y8qOHrkBN8IZM6I7OzutXowqQDOKfA= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240510_120143_886256_6154C7C9 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrea, please drop E. Anholt from the recipients. AFAIK she is not interested in kernel development anymore. Am 10.05.24 um 16:35 schrieb Andrea della Porta: > The BCM2712 has an SDHCI capable host interface similar to the one found > in other STB chipsets. Add the relevant compatible string and relative > example. > > Signed-off-by: Andrea della Porta > --- > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 23 +++++++++++++++++++ > 1 file changed, 23 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > index cbd3d6c6c77f..404b75fa7adb 100644 > --- a/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > +++ b/Documentation/devicetree/bindings/mmc/brcm,sdhci-brcmstb.yaml > @@ -13,6 +13,10 @@ maintainers: > properties: > compatible: > oneOf: > + - items: > + - enum: > + - brcm,bcm2712-sdhci > + - const: brcm,sdhci-brcmstb > - items: > - enum: > - brcm,bcm7216-sdhci > @@ -114,3 +118,22 @@ examples: > clocks = <&scmi_clk 245>; > clock-names = "sw_sdio"; > }; > + > + - | > + #include > + soc { > + #address-cells = <2>; > + #size-cells = <2>; Would be nice to have a short explanation in the commit message why this is necessary. > + > + mmc@1000fff000 { > + compatible = "brcm,bcm2712-sdhci", > + "brcm,sdhci-brcmstb"; > + reg = <0x10 0x00fff000 0x0 0x260>, > + <0x10 0x00fff400 0x0 0x200>; > + reg-names = "host", "cfg"; > + mmc-ddr-3_3v; > + interrupts = ; > + clocks = <&clk_emmc2>; > + clock-names = "sw_sdio"; > + }; > + }; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel