From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7676C433EF for ; Wed, 22 Sep 2021 03:02:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7052F6058D for ; Wed, 22 Sep 2021 03:02:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7052F6058D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7ykLmL6D75IehfkTDg5MdwAUrlfyHOjE1cLjoKrVlCU=; b=Bcf85VOvLMtw24 S7Cr6LPOm922pUz4NWHLEPRfaXnvxpETzf1tFO8koC9xBXnHnqz81d9rfE3bjHkk+NqOKAnlnYI0M C9onhA8QoWG04xmi8HMfAvXjLshnPQw+zCGLoZf6LQIJt0P/+Iq7xGxss+RzAGYRK8kj0dBDvfxXm qb4Qy7jdhVLZ04S528CApwj4M32q4aqxHZBDWhTP01rihUEICoTS3yQeT5Kn3cXWkyVCfNcPK4PaY 4MTl1i/UPohbpeZEfanhKu6K0Ggm1VIqW2TZPeh8qkMjSyOmq+ucvQZjHZm4pQZ7RbvXzy5OMavJr h44aoyk7kaG+4Jebp+1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSsUz-006lYT-Mk; Wed, 22 Sep 2021 03:00:42 +0000 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSsSH-006kMR-MG for linux-arm-kernel@lists.infradead.org; Wed, 22 Sep 2021 02:57:55 +0000 Received: by mail-pl1-x633.google.com with SMTP id w6so806402pll.3 for ; Tue, 21 Sep 2021 19:57:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=SliVJPZt2b3dJnLTZ6YsWgFb3zQafl+TYC6vZjNtaQU=; b=SvINqgjec0iZ/Ok1+nrm4TPKBWBIaYsvLFtrF345dI60t2AqZr6MXVdsJY5S4nXV1S 24eF3zA1lwJu7kgBDQghBKDCUXBBPwPKmv0TLdz/fo4QQq4cKCyjz0GEQZwdcdDc17cx LZDVPz8ijgQZb4GgaEKKyufL9QDy9SFI9vSxoCgH6JHfxi3Fnv3iHai/bd8sX0QesTJk Zc6Tv6Box+VJgEPUUUrU+izX9j1A8dofZ8oU8JCLGAbkdKnWoM4qF9HoXlTE9V3jSbYy yBpK0zKxeDz0lnJpE67DBHRF0jqPjRY2gkr0+B1ERSOh20pIEqUSg7a2BjXoUZlX8I8R G8jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=SliVJPZt2b3dJnLTZ6YsWgFb3zQafl+TYC6vZjNtaQU=; b=W5JuIMkXvoho8Grb96S1qNDHzvjRzOXtnHEeLG1Y0Bnbf/VcdvTsSzl0mKU43Gh4zu jBJriwxtPLZ6vnUrf0rxtxA0oDKUcxdb0z/rDMZnGZoZboJQ7+qAZfTYXOLF+gsDnTY+ 5t0RKi8ZdPuUHQk8+5IJjgl7MzW8tgqJyzVTO+l36Gepb/XsIOQkbwn9WaVZ7RFCz1K+ uNDqPrTqpUpgVUA3+hhJZogtJHGGfraMeSeVEtB5okeqIo/7veFbnYmUOHuk1/9RAMj6 PCwsBnU1rWb5NI1MvIz5MJP53eCyOU/ZR4cHSQMtLUkFuZtu1vgwdXuoML5rjw4lOvmX rvrQ== X-Gm-Message-State: AOAM531MDGliqwj7ENfIuaUh/ZI58aAtCyClOsqhF2S9ImbpMw4Grr5E xoQlefPshEo+xWPopwh8XjE= X-Google-Smtp-Source: ABdhPJxrsVWeQ0Qomw0S4n+YgNSH9IYgVxa933+ey+i3PMdzy27PEXfucLysVyYtDUE0s9IyHWNVgA== X-Received: by 2002:a17:90a:db17:: with SMTP id g23mr8764791pjv.193.1632279472748; Tue, 21 Sep 2021 19:57:52 -0700 (PDT) Received: from [192.168.1.121] (99-44-17-11.lightspeed.irvnca.sbcglobal.net. [99.44.17.11]) by smtp.gmail.com with ESMTPSA id v8sm3709063pjh.24.2021.09.21.19.57.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Sep 2021 19:57:52 -0700 (PDT) Message-ID: <01b708d2-f211-8217-f686-0f7bf9fc8129@gmail.com> Date: Tue, 21 Sep 2021 19:57:49 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH v2] ARM: imx6: mask all interrupts before calling stby-poweroff sequence Content-Language: en-US To: Shawn Guo , Oleksij Rempel Cc: Sascha Hauer , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Fabio Estevam , linux-imx@nxp.com References: <20210817122500.31953-1-o.rempel@pengutronix.de> <20210922023740.GD10217@dragon> From: Florian Fainelli In-Reply-To: <20210922023740.GD10217@dragon> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210921_195753_797117_125CDDD9 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/21/2021 7:37 PM, Shawn Guo wrote: > On Tue, Aug 17, 2021 at 02:25:00PM +0200, Oleksij Rempel wrote: >> Any pending interrupt can prevent entering standby based power off state. >> To avoid it, mask all interrupts. >> >> Fixes: 8148d2136002 ("ARM: imx6: register pm_power_off handler if "fsl,pmic-stby-poweroff" is set") >> Signed-off-by: Oleksij Rempel >> --- >> arch/arm/mach-imx/pm-imx6.c | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c >> index 9244437cb1b9..63887ade411a 100644 >> --- a/arch/arm/mach-imx/pm-imx6.c >> +++ b/arch/arm/mach-imx/pm-imx6.c >> @@ -59,8 +59,11 @@ >> #define MX6Q_SUSPEND_OCRAM_SIZE 0x1000 >> #define MX6_MAX_MMDC_IO_NUM 33 >> >> +#define GIC_DIST_ENABLE_CLEAR 0x180 >> + >> static void __iomem *ccm_base; >> static void __iomem *suspend_ocram_base; >> +static void __iomem *gic_raw_dist_base; >> static void (*imx6_suspend_in_ocram_fn)(void __iomem *ocram_vbase); >> >> /* >> @@ -592,6 +595,7 @@ static int __init imx6q_suspend_init(const struct imx6_pm_socdata *socdata) >> static void __init imx6_pm_common_init(const struct imx6_pm_socdata >> *socdata) >> { >> + struct device_node *np; >> struct regmap *gpr; >> int ret; >> >> @@ -615,10 +619,29 @@ static void __init imx6_pm_common_init(const struct imx6_pm_socdata >> if (!IS_ERR(gpr)) >> regmap_update_bits(gpr, IOMUXC_GPR1, IMX6Q_GPR1_GINT, >> IMX6Q_GPR1_GINT); >> + >> + np = of_find_compatible_node(NULL, NULL, "arm,cortex-a9-gic"); >> + gic_raw_dist_base = of_iomap(np, 0); >> +} >> + >> +static void imx_gic_mask_all(void) >> +{ >> + int i; >> + >> + if (WARN_ON(!gic_raw_dist_base)) >> + return; >> + >> + for (i = 0; i < 4; i++) >> + writel_relaxed(~0, gic_raw_dist_base + GIC_DIST_ENABLE_CLEAR + 4 * i); > > Is it possible to have a helper function in GIC driver, that we can > simply call into? Cannot you call gic_cpu_if_down(0) which would presumably have the same effect? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel