From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E02C2C4338F for ; Wed, 25 Aug 2021 10:51:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B0102610E5 for ; Wed, 25 Aug 2021 10:51:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B0102610E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To:Cc:To:Subject: Message-ID:From:Date:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qVQYIzERzd8E1sZ4OcqT9KQ+6yCycspz1dJdJsVVMuY=; b=3V1rVQPeJqj7em JHkm/fCF2rcUI4wXpPbWL7+WEACX9B0zFJETxq6BYnL/XteS7NVoOnnOkZB6t8M4v9h83by+mDayh aLuyiu1dc4xIiyhajOstHUZvdYsYjAITWH1on6bZ9rKp6J9JIXXBPskvb9Sk+kqmPjtQzaH2n0I5R 2TIGDuMC4rXxUNTWlzvCSCqFseZL/Q5QHsH84z0VSN6Lbc+KN10bIHzqhWldKEcmSFJpPDvqOKcnw A2cYQBduYamrkXhajX1nSOCqY58M/5wryuikv3n751cVHWOb3SjF3wEXci3YiMA9iwfZ6KfxVvDhn hu9XyDtBVD8snM1KkE4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIqTW-006e8m-9e; Wed, 25 Aug 2021 10:49:42 +0000 Received: from out1.migadu.com ([2001:41d0:2:863f::]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIqTJ-006dzN-NN for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 10:49:34 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1629888555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OrNb43ZzSHz1Ze2clgfxoPvFEQ2+7dJpVKQAD7qnx7I=; b=JKJ+QuQRviHy0cvSQpODpDsx4XmJTCduVHWkLrogEUa5j0E32QweP4vlygptiilpSTY0HG cz/r4rtJnIzLPTZRGkRagjPtQQiBon98aJkvRiyk9Hs1qczUNRnUt2+5wOdyiw4NUXJPgS plz7/cZvZBubgOHFxQ/VISrgOtQSs0M= Date: Wed, 25 Aug 2021 10:49:14 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: yajun.deng@linux.dev Message-ID: <01d7cf96c63c05097ef28789e2e27d6f@linux.dev> Subject: Re: [PATCH linux-next] arm64: PCI: Introduce pcibios_free_irq() helper function To: "Will Deacon" Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com In-Reply-To: <20210825100500.GC24546@willie-the-truck> References: <20210825100500.GC24546@willie-the-truck> <20210825071612.21543-1-yajun.deng@linux.dev> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: yajun.deng@linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_034929_940968_9BF24B60 X-CRM114-Status: UNSURE ( 7.52 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org August 25, 2021 6:05 PM, "Will Deacon" wrote: > [+Lorenzo] > > On Wed, Aug 25, 2021 at 03:16:12PM +0800, Yajun Deng wrote: > >> Introduce pcibios_free_irq() to free irq in pci_device_probe() and >> pci_device_remove() that in drivers/pci/pci-driver.c. > > Please can you describe the problem you're solving? > pcibios_alloc_irq() will be called in pci_device_probe(), but there hasn't pcibios_free_irq() in arm64 architecture correspond it. pcibios_free_irq() is an empty function in drivers/pci/pci-driver.c.So pcibios_alloc_irq() and pcibios_free_irq() don't correspond. >> Signed-off-by: Yajun Deng >> --- >> arch/arm64/kernel/pci.c | 10 +++++++++- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c >> index 1006ed2d7c60..40da5aff4548 100644 >> --- a/arch/arm64/kernel/pci.c >> +++ b/arch/arm64/kernel/pci.c >> @@ -25,10 +25,18 @@ >> int pcibios_alloc_irq(struct pci_dev *dev) >> { >> if (!acpi_disabled) >> - acpi_pci_irq_enable(dev); >> + return acpi_pci_irq_enable(dev); > > This means we'll now fail device probe if we can't enable the GSI. Is that a > problem? > Oh, It would be better that hasn't return. > Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel