From: neidhard.kim@lge.com (Kim, Jong-Sung)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: PL011: clear pending interrupts
Date: Mon, 12 Mar 2012 20:28:56 +0900 [thread overview]
Message-ID: <01e201cd0043$5010cea0$f0326be0$@lge.com> (raw)
In-Reply-To: <20120312101100.GA8649@n2100.arm.linux.org.uk>
> On Mon, Mar 12, 2012 at 08:32:21AM +0000, Russell King - ARM Linux wrote:
> > On Mon, Mar 12, 2012 at 09:25:50AM +0100, Linus Walleij wrote:
> > > diff --git a/drivers/tty/serial/amba-pl011.c
> > > b/drivers/tty/serial/amba-pl011.c index 6800f5f..ff3fed0 100644
> > > --- a/drivers/tty/serial/amba-pl011.c
> > > +++ b/drivers/tty/serial/amba-pl011.c
> > > @@ -224,6 +224,11 @@ static int pl011_fifo_to_tty(struct
uart_amba_port
> *uap)
> > > uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag);
> > > }
> > >
> >
> > What if we really do end up receiving some characters here?
> >
> > > + /* RXIS but RXFE? Just clear the interrupt */
> > > + if(unlikely(fifotaken == 0))
> > > + writew(UART011_RTIS | UART011_RXIS,
> > > + uap->port.membase + UART011_ICR);
>
> BTW, I don't see why we need any of this stuff.
Actually, I meant my patch applied alone, not with your patch. My thought
was the problem we're trying to handle is undocumented and is not guaranteed
not to happen again.
next prev parent reply other threads:[~2012-03-12 11:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 8:25 [PATCH] serial: PL011: clear pending interrupts Linus Walleij
2012-03-12 8:32 ` Russell King - ARM Linux
2012-03-12 10:11 ` Russell King - ARM Linux
2012-03-12 10:48 ` Linus Walleij
2012-03-12 11:28 ` Kim, Jong-Sung [this message]
2012-03-12 11:22 ` Kim, Jong-Sung
2012-03-12 11:28 ` Russell King - ARM Linux
2012-03-12 9:27 ` James Courtier-Dutton
2012-03-12 10:03 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01e201cd0043$5010cea0$f0326be0$@lge.com' \
--to=neidhard.kim@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).