From: Nikolay Borisov <nborisov@suse.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: linux-arm-kernel@lists.infradead.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH 2/3] arm64: dts: allwinner: a64: Add hwspinlock node
Date: Tue, 11 Feb 2020 10:09:48 +0200 [thread overview]
Message-ID: <01e31d57-48ef-fd39-7c16-45401c70bb63@suse.com> (raw)
In-Reply-To: <20200211075543.ytsxizbysdosnx4p@gilmour.lan>
On 11.02.20 г. 9:55 ч., Maxime Ripard wrote:
> Hi,
>
> On Mon, Feb 10, 2020 at 07:01:42PM +0200, Nikolay Borisov wrote:
>> Add a node describing the hwspinlock on A64.
>>
>> Signed-off-by: Nikolay Borisov <nborisov@suse.com>
>> ---
>> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> index 27e48234f1c2..01de89fc09cc 100644
>> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
>> @@ -1182,5 +1182,14 @@
>> interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
>> clocks = <&osc24M>;
>> };
>> +
>> + hwspinlock: spinlock@1c18000 {
>
> Nodes are supposed to be ordered by ascending physical address
>
>> + compatible = "allwinner,sun50i-a64-hwspinlock";
>> + reg = <0x01c18000 0x1000>;
>> + clocks = <&ccu CLK_BUS_SPINLOCK>;
>> + resets = <&ccu RST_BUS_SPINLOCK>;
>> + #hwlock-cells = <1>;
>> + status = "disabled";
>
> Is there a reason to disable it?
I wondered about that - on the one hand we can safely leave it always
enabled, on the other hand all devices are are disabled in the dtsi.
>
> Also, my understanding was that hwspinlocks were meant to be used by
> client drivers, so surely we must tie them to other device nodes too,
> right?
Perhaps but at this point I'm not sure to which device specifically.
>
> Maxime
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-11 8:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 17:01 [PATCH 0/3] Add support for hwspinlock on A64 SoC Nikolay Borisov
2020-02-10 17:01 ` [PATCH 1/3] hwspinlock: sunxi: Implement support for Allwinner's " Nikolay Borisov
2020-02-10 18:57 ` Bjorn Andersson
2020-02-10 19:06 ` Nikolay Borisov
2020-02-10 20:05 ` Bjorn Andersson
2020-02-11 7:46 ` Maxime Ripard
2020-02-11 8:08 ` Nikolay Borisov
2020-02-11 12:34 ` Maxime Ripard
2020-02-11 13:17 ` Nikolay Borisov
2020-02-12 12:06 ` Maxime Ripard
2020-02-12 14:32 ` Nikolay Borisov
2020-02-12 19:10 ` Maxime Ripard
2020-02-10 17:01 ` [PATCH 2/3] arm64: dts: allwinner: a64: Add hwspinlock node Nikolay Borisov
2020-02-11 7:55 ` Maxime Ripard
2020-02-11 8:09 ` Nikolay Borisov [this message]
2020-02-11 12:36 ` Maxime Ripard
2020-02-10 17:01 ` [PATCH 3/3] dt-bindings: hwlock: Document A64 hwspinlock bindings Nikolay Borisov
2020-02-10 18:59 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01e31d57-48ef-fd39-7c16-45401c70bb63@suse.com \
--to=nborisov@suse.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maxime@cerno.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).