From: David Lechner <dlechner@baylibre.com>
To: "Antoniu Miclaus" <antoniu.miclaus@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: at91_adc: change at91_ts_sample to return void
Date: Mon, 2 Feb 2026 09:11:58 -0600 [thread overview]
Message-ID: <01eb6fc5-4a71-4877-8a62-ef397a1036c9@baylibre.com> (raw)
In-Reply-To: <20260202115733.21382-1-antoniu.miclaus@analog.com>
On 2/2/26 5:57 AM, Antoniu Miclaus wrote:
> The return value of at91_ts_sample() is never checked by its caller.
> Change the return type to void to make this explicit. The error
> conditions are already logged via dev_err() which provides sufficient
> visibility into hardware issues.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
Reviewed-by: David Lechner <dlechner@baylibre.com>
next prev parent reply other threads:[~2026-02-02 15:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 11:57 [PATCH v2] iio: adc: at91_adc: change at91_ts_sample to return void Antoniu Miclaus
2026-02-02 15:11 ` David Lechner [this message]
2026-02-22 18:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01eb6fc5-4a71-4877-8a62-ef397a1036c9@baylibre.com \
--to=dlechner@baylibre.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=jic23@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox