From: Marek Vasut <marex@denx.de>
To: Adam Ford <aford173@gmail.com>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
linux-clk@vger.kernel.org, Fabio Estevam <festevam@gmail.com>,
Abel Vesa <abelvesa@kernel.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Jacky Bai <ping.bai@nxp.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Lucas Stach <l.stach@pengutronix.de>,
Michael Turquette <mturquette@baylibre.com>,
NXP Linux Team <linux-imx@nxp.com>, Peng Fan <peng.fan@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK
Date: Tue, 28 Feb 2023 07:48:07 +0100 [thread overview]
Message-ID: <01f83ee3-51e0-4c7b-8abd-1a8e40abcdf2@denx.de> (raw)
In-Reply-To: <3378fb83-d88d-4854-c096-b459672eef08@denx.de>
On 2/28/23 07:43, Marek Vasut wrote:
> On 2/28/23 03:44, Adam Ford wrote:
>> On Mon, Feb 27, 2023 at 1:37 PM Marek Vasut <marex@denx.de> wrote:
>>>
>>> On 2/27/23 19:59, Marco Felsch wrote:
>>> [...]
>>>
>>>>> @@ -344,6 +384,18 @@ &i2c3 {
>>>>> pinctrl-0 = <&pinctrl_i2c3>;
>>>>> status = "okay";
>>>>>
>>>>> + wm8960: codec@1a {
>>>>> + #sound-dai-cells = <0>;
>>>>> + compatible = "wlf,wm8960";
>>>>> + reg = <0x1a>;
>>>>
>>>> The compatible should be the first property followed by the reg
>>>> property.
>>>
>>> See my reply to the mx8mn sound-sai-cells patch , I am not sure here.
>>> The rest is fixed in V6.
>>>
>>>>> + clocks = <&audio_blk_ctrl
>>>>> IMX8MP_CLK_AUDIOMIX_SAI3_MCLK1>;
>>>>> + clock-names = "mclk";
>>>>> + wlf,shared-lrclk;
>>>>> + wlf,hp-cfg = <3 2 3>;
>>>>> + wlf,gpio-cfg = <1 3>;
>>>>> + SPKVDD1-supply = <®_audio_pwr>;
>>>>> + };
>>>>> +
>>>>> pca6416: gpio@20 {
>>>>> compatible = "ti,tca6416";
>>>>> reg = <0x20>;
>>>
>>> [...]
>>>
>>>>> @@ -668,6 +730,18 @@ MX8MP_IOMUXC_UART3_TXD__UART1_DCE_RTS 0x140
>>>>> >;
>>>>> };
>>>>>
>>>>> + pinctrl_sai3: sai3grp {
>>>>> + fsl,pins = <
>>>>> +
>>>>> MX8MP_IOMUXC_SAI3_TXFS__AUDIOMIX_SAI3_TX_SYNC 0xd6
>>>>> +
>>>>> MX8MP_IOMUXC_SAI3_TXC__AUDIOMIX_SAI3_TX_BCLK 0xd6
>>>>> +
>>>>> MX8MP_IOMUXC_SAI3_RXD__AUDIOMIX_SAI3_RX_DATA00 0xd6
>>>>> +
>>>>> MX8MP_IOMUXC_SAI3_TXD__AUDIOMIX_SAI3_TX_DATA00 0xd6
>>>>> +
>>>>> MX8MP_IOMUXC_SAI3_MCLK__AUDIOMIX_SAI3_MCLK 0xd6
>>>>> +
>>>>> MX8MP_IOMUXC_SAI3_RXFS__GPIO4_IO28 0xd6
>>>>
>>>> What is gpio04-io28 used for?
>>>
>>> Apparently unused, dropped.
>>
>> Isn't that the headphone detect GPIO?
>>
>> I think simple-audio-card,hp-det-gpio can reference it.
>
> Per the schematics of the MX8MP EVK, the pin is not connected on the
> board-to-board connector EVK side, right ?
Er, correction, that's AUD_NINT, which is WM8960 GPIO1 .
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-28 6:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 17:43 [PATCH v5 1/5] clk: Introduce devm_clk_hw_register_gate_parent_data() Marek Vasut
2023-02-27 17:43 ` [PATCH v5 2/5] clk: imx: imx8mp: Add audiomix block control Marek Vasut
2023-02-27 17:46 ` Fabio Estevam
2023-02-27 17:43 ` [PATCH v5 3/5] dt-bindings: clock: " Marek Vasut
2023-02-27 17:47 ` Fabio Estevam
2023-02-27 18:53 ` Marco Felsch
2023-02-27 17:43 ` [PATCH v5 4/5] arm64: dts: imx8mp: Add SAI, SDMA, AudioMIX Marek Vasut
2023-02-27 17:47 ` Fabio Estevam
2023-02-27 17:43 ` [PATCH v5 5/5] arm64: dts: imx8mp: Add analog audio output on i.MX8MP EVK Marek Vasut
2023-02-27 18:59 ` Marco Felsch
2023-02-27 19:33 ` Marek Vasut
2023-02-28 2:44 ` Adam Ford
2023-02-28 6:43 ` Marek Vasut
2023-02-28 6:48 ` Marek Vasut [this message]
2023-02-28 11:29 ` Adam Ford
2023-02-28 21:55 ` Marek Vasut
2023-02-27 17:46 ` [PATCH v5 1/5] clk: Introduce devm_clk_hw_register_gate_parent_data() Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f83ee3-51e0-4c7b-8abd-1a8e40abcdf2@denx.de \
--to=marex@denx.de \
--cc=abelvesa@kernel.org \
--cc=aford173@gmail.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=luca.ceresoli@bootlin.com \
--cc=m.felsch@pengutronix.de \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).