linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] s5pc110: Reduce the iodesc length of systimer
Date: Thu, 08 Jul 2010 20:05:30 +0900	[thread overview]
Message-ID: <020201cb1e8d$7d90ba50$78b22ef0$%kim@samsung.com> (raw)
In-Reply-To: <20100708023647.GA8320@july>

Kyungmin Park wrote:
> 
> From: Kyungmin Park <kyungmin.park@samsung.com>
> 
> It's enough to use 4KiB.
> 
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>

Where is submitter(kmpark at infradead.org)'s Signed-off-by?
I know submitter and author in here are same...but e-mail.
So added 'From' in your patch.

It would be helpful to me if you use same e-mail in a patch.

Also, the commit message needs to be more descriptive.

> ---
> diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c
> index 411a4a9..07b86d2 100644
> --- a/arch/arm/mach-s5pv210/cpu.c
> +++ b/arch/arm/mach-s5pv210/cpu.c
> @@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata = {
>  	{
>  		.virtual	= (unsigned long)S5P_VA_SYSTIMER,
>  		.pfn		= __phys_to_pfn(S5PV210_PA_SYSTIMER),
> -		.length		= SZ_1M,
> +		.length		= SZ_4K,
>  		.type		= MT_DEVICE,
>  	}, {
>  		.virtual	= (unsigned long)VA_VIC2,
> 

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2010-07-08 11:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-08  2:36 [PATCH] s5pc110: Reduce the iodesc length of systimer Kyungmin Park
2010-07-08 11:05 ` Kukjin Kim [this message]
2010-07-08 11:40   ` Kyungmin Park
2010-07-08 12:34     ` Kukjin Kim
2010-07-08 17:31     ` Andrew Morton
2010-07-08 11:17 ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='020201cb1e8d$7d90ba50$78b22ef0$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).