From mboxrd@z Thu Jan  1 00:00:00 1970
From: kgene.kim@samsung.com (Kukjin Kim)
Date: Thu, 08 Jul 2010 21:34:32 +0900
Subject: [PATCH] s5pc110: Reduce the iodesc length of systimer
In-Reply-To: <AANLkTilA5_kKf_CYE98ul1znzF1AT_mektC2TrFd9vyv@mail.gmail.com>
References: <20100708023647.GA8320@july>
	<020201cb1e8d$7d90ba50$78b22ef0$%kim@samsung.com>
	<AANLkTilA5_kKf_CYE98ul1znzF1AT_mektC2TrFd9vyv@mail.gmail.com>
Message-ID: <020701cb1e99$edb8c550$c92a4ff0$%kim@samsung.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Kyungmin Park wrote:
> 
> Hi Andrew,
> 
> Can you explain Mr. Kim request?
> As your suggestion, If the sender and signed-off are different, add
> the From filed at body.
> 
Yes I know, didn't see my posing?
In this case, my suggestion is just use same e-mail in a patch.

> I think no need to add duplicated signed-off since it's same person.
> 
Maybe you misunderstood my comments.

> Thank you,
> Kyungmin Park
> 
> 
> On Thu, Jul 8, 2010 at 8:05 PM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> > Kyungmin Park wrote:
> >>
> >> From: Kyungmin Park <kyungmin.park@samsung.com>
> >>
> >> It's enough to use 4KiB.
> >>
> >> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> >
> > Where is submitter(kmpark at infradead.org)'s Signed-off-by?
> > I know submitter and author in here are same...but e-mail.
> > So added 'From' in your patch.
> >
> > It would be helpful to me if you use same e-mail in a patch.
> >
> > Also, the commit message needs to be more descriptive.
> >
> >> ---
> >> diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c
> >> index 411a4a9..07b86d2 100644
> >> --- a/arch/arm/mach-s5pv210/cpu.c
> >> +++ b/arch/arm/mach-s5pv210/cpu.c
> >> @@ -41,7 +41,7 @@ static struct map_desc s5pv210_iodesc[] __initdata =
{
> >> ? ? ? {
> >> ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)S5P_VA_SYSTIMER,
> >> ? ? ? ? ? ? ? .pfn ? ? ? ? ? ?= __phys_to_pfn(S5PV210_PA_SYSTIMER),
> >> - ? ? ? ? ? ? .length ? ? ? ? = SZ_1M,
> >> + ? ? ? ? ? ? .length ? ? ? ? = SZ_4K,
> >> ? ? ? ? ? ? ? .type ? ? ? ? ? = MT_DEVICE,
> >> ? ? ? }, {
> >> ? ? ? ? ? ? ? .virtual ? ? ? ?= (unsigned long)VA_VIC2,
> >>
> >


Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.