From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Tue, 23 Oct 2012 22:27:41 +0900 Subject: [PATCH 4/4] ARM: EXYNOS: Kconfig: Remove dependencies on particular SoCs from DT machines In-Reply-To: <1349701345-2681-5-git-send-email-t.figa@samsung.com> References: <1349701345-2681-1-git-send-email-t.figa@samsung.com> <1349701345-2681-5-git-send-email-t.figa@samsung.com> Message-ID: <020a01cdb122$2d888ae0$8899a0a0$%kim@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Tomasz Figa wrote: > > MACH_EXYNOS{4,5}_DT are used for whole SoC lines, so they should depend > on ARCH_EXYNOS{4,5} rather than on particular SoCs. > > Signed-off-by: Tomasz Figa > Signed-off-by: Kyungmin Park > --- > arch/arm/mach-exynos/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig > index 6ea95f0..2e82ce7 100644 > --- a/arch/arm/mach-exynos/Kconfig > +++ b/arch/arm/mach-exynos/Kconfig > @@ -404,7 +404,6 @@ comment "Flattened Device Tree based board for EXYNOS > SoCs" > config MACH_EXYNOS4_DT > bool "Samsung Exynos4 Machine using device tree" > depends on ARCH_EXYNOS4 > - select SOC_EXYNOS4210 > select USE_OF > select ARM_AMBA > select HAVE_SAMSUNG_KEYPAD if INPUT_KEYBOARD > @@ -419,7 +418,6 @@ config MACH_EXYNOS4_DT > config MACH_EXYNOS5_DT > bool "SAMSUNG EXYNOS5 Machine using device tree" > depends on ARCH_EXYNOS5 > - select SOC_EXYNOS5250 > select USE_OF > select ARM_AMBA > help > -- > 1.7.12 Hmm...your comment is correct, but we need to think again its selecting order, between ARCH name, SoC and board. In addition, in case of MACH_XXX_DT depending on SoC is rather to be supposed... Thanks. Best regards, Kgene. -- Kukjin Kim , Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.