linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: chanho.min@lge.com (Chanho Min)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: timer-sp: ensure interrupt is cleared at sp804_clockevents_init
Date: Wed, 17 Sep 2014 11:58:04 +0900	[thread overview]
Message-ID: <021401cfd223$337d9430$9a78bc90$@min@lge.com> (raw)
In-Reply-To: <20140917010923.GB10233@codeaurora.org>

> > +	/* Ensure interrupt is cleared */
> > +	writel(1, clkevt_base + TIMER_INTCLR);
> >  	setup_irq(irq, &sp804_timer_irq);
> >  	clockevents_config_and_register(evt, rate, 0xf, 0xffffffff);
> 
> Or just flip the order of clockevents_config_and_register() and
> setup_irq()? We've done this in other clockevents drivers.
It won't fix this issue. clockevents_config_and_register will do nothing
if the higher rated device is registered. if pending interrupt is existed,
interrupt will be triggered as soon as setup_irq is done.

      reply	other threads:[~2014-09-17  2:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-17  0:42 [PATCH] ARM: timer-sp: ensure interrupt is cleared at sp804_clockevents_init Chanho Min
2014-09-17  1:09 ` Stephen Boyd
2014-09-17  2:58   ` Chanho Min [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='021401cfd223$337d9430$9a78bc90$@min@lge.com' \
    --to=chanho.min@lge.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).