linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kgene.kim@samsung.com (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: EXYNOS4: add support for i2c PMICs on Universal_C210	board
Date: Fri, 04 Mar 2011 10:53:05 +0900	[thread overview]
Message-ID: <022f01cbda0e$ea1d30d0$be579270$%kim@samsung.com> (raw)
In-Reply-To: <1299164371-23398-1-git-send-email-m.szyprowski@samsung.com>

Marek Szyprowski wrote:
> 
> This patch adds basic definitions for MAX8952 & LP3974 (MAX8998
> compatible) PMICs for UniversalC210 board. Power consumers for the
> device drivers will be added later. These two PMICs occupy I2C5 bus.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  arch/arm/mach-exynos4/Kconfig               |    2 +
>  arch/arm/mach-exynos4/mach-universal_c210.c |  413
> +++++++++++++++++++++++++++
>  2 files changed, 415 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-exynos4/Kconfig b/arch/arm/mach-exynos4/Kconfig
> index ad03840..d58cbb5 100644
> --- a/arch/arm/mach-exynos4/Kconfig
> +++ b/arch/arm/mach-exynos4/Kconfig
> @@ -116,8 +116,10 @@ config MACH_UNIVERSAL_C210
>  	select S3C_DEV_HSMMC2
>  	select S3C_DEV_HSMMC3
>  	select S3C_DEV_I2C1
> + 	select S3C_DEV_I2C5
   ^
Used 1 white space + tab here.
As you know, just 1 tab is enough :)

>  	select S5P_DEV_ONENAND
>  	select EXYNOS4_SETUP_I2C1
> + 	select EXYNOS4_SETUP_I2C5
   ^
Same as above.

>  	select EXYNOS4_SETUP_SDHCI
>  	help
>  	  Machine support for Samsung Mobile Universal S5PC210 Reference

Thanks for your re-working.
Ok, will apply with above fixing.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

  reply	other threads:[~2011-03-04  1:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-15 10:59 [PATCH] ARM: S5PC210: add support for i2c PMICs on Universal_C210 board Marek Szyprowski
2011-02-15 11:35 ` Russell King - ARM Linux
2011-02-15 12:50   ` [PATCH v2] " Marek Szyprowski
2011-03-03  2:21     ` Kukjin Kim
2011-03-03 14:59       ` [PATCH v3] ARM: EXYNOS4: " Marek Szyprowski
2011-03-04  1:53         ` Kukjin Kim [this message]
2011-03-03  2:40   ` [PATCH] ARM: S5PC210: " Kyungmin Park
2011-03-05 11:21     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='022f01cbda0e$ea1d30d0$be579270$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).