From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F6F7C4706F for ; Tue, 26 Dec 2023 19:02:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tcviIGcT59G4rTuL/6olNkvYLkzULM9v2Ir40TRy+z4=; b=mvWvtYd/yxoPk6 kexONOZ/9VNKJU0FhGUE5gQqokUBbWzJ48eFp14raBYX2LO7erC5bcq3m9/LufCNXrtHuawEeY300 /MqFMxUssIP0H+oqOOPc8G2yPAX34f6naSrtBx4k56qe1KFggIZcPbGtyDpBuES37eXOmTFlni352 S6LtNoJwQAoaS85zprrFX5SE0JGqzEpzPhd3WZWCdhGv0vgidq6CaO/jEEc8+Q54u8StTm1ReyuEZ HtEwcS5SqrMMwwEVTm98wRJJrZ+zeFUxizJeqAPDMYucryGeKXoLhOum4lsBwtGb/Vv8fAnO7K+VD Unwnt9V2rUd8smM2TrHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rICgl-00DOlI-36; Tue, 26 Dec 2023 19:02:03 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rICgj-00DOkw-0e for linux-arm-kernel@lists.infradead.org; Tue, 26 Dec 2023 19:02:02 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a271a28aeb4so65498366b.2 for ; Tue, 26 Dec 2023 11:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1703617316; x=1704222116; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mv/k4E8tNQsDocRbC/Q62jxBeX63xNG+uOzrvraohns=; b=qT1VKTW6OWNcQMpOr6WY4oNa0KxpKzCj/RsIuiGYvGwvG7hE29LXmAAFp/fO8p0X/H YvuWdDDd1pxjcIrGBi4JnGloaAGEYlB8R1YCgCyX19Dy60y6jl+bimBrvLmo/9Fe2fO2 ZO2YDwA9AYKv/sforgeUBytjwmFNjbP36NpQi7thpYHBr3fOQX1ZJdzwBi26MaaTUqXi 54QB31evFI4PwqHWk3Dr+vpstxFvzkgVRxBv7SjXgMOKjx8JQ8Q5NhduuIfcO3LL0HkI ubSHqWmRtBLyy+zG5J5iPrwnx0I0i3R1iaP+ETBMHHOMDGDCYGrQQJNtq6v9h5xEsJSu Bddw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703617316; x=1704222116; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mv/k4E8tNQsDocRbC/Q62jxBeX63xNG+uOzrvraohns=; b=jZ8509wZXBJoydO3a+Qs21AirZHny53QYqBnM9G2FAG5HsOqV2x9Z7W2nJ+2ZXqVBD N/lgena4bIxL5/oepEFt46zEc7qjoAM2ToldZzjplgqj55wC13ylhBiVw6vPKcxbhsSE No2A/2LFrjH+VvmB6IVb8jRUz7SnksJA65UeXUSPdTbl4q/vHzvL88ToDvym8pRimCva x8iJd+a022AHhIMvffFSxQf90cP4fo15xghaw2tKiGjo/hy+GeEZUQqR+nnD+ue0Ckw0 j2DNLlQGb9Px7D5jJixXrXf5//juv/n7K1m/PXY3og6LNPn74hoqfn7GTtVn1GuvF7u3 qAug== X-Gm-Message-State: AOJu0YzdT2ll0KQjTtkyKsdUPJ391oAJjUyvF9SEBQR/MqcUxrdUATKF Qc2JPr3ynUVEN/9LCJAVuEzT6erQnCKoOA== X-Google-Smtp-Source: AGHT+IHsHiD6Zn3OsjK2DGYYWjTYRSHvI51xN7TxWZ3bS/xX57kGlz8kaVDKsTPlumPpdg/oqCnyfQ== X-Received: by 2002:a17:906:150:b0:a19:a19b:78a8 with SMTP id 16-20020a170906015000b00a19a19b78a8mr4096990ejh.107.1703617315124; Tue, 26 Dec 2023 11:01:55 -0800 (PST) Received: from [192.168.0.22] ([78.10.206.178]) by smtp.gmail.com with ESMTPSA id p18-20020a170906b21200b00a26f69ca8d0sm1759085ejz.71.2023.12.26.11.01.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Dec 2023 11:01:54 -0800 (PST) Message-ID: <0233cf48-93cb-4f19-ad1d-e3e1835c1fef@linaro.org> Date: Tue, 26 Dec 2023 20:01:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 15/16] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string Content-Language: en-US To: Frank Li Cc: bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, manivannan.sadhasivam@linaro.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org References: <20231224183242.1675372-1-Frank.Li@nxp.com> <20231224183242.1675372-16-Frank.Li@nxp.com> <6a61f325-a58b-4aa6-9a0a-7a3086f63829@linaro.org> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231226_110201_285338_0001AEDA X-CRM114-Status: GOOD ( 14.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 26/12/2023 17:12, Frank Li wrote: > On Mon, Dec 25, 2023 at 08:16:17PM +0100, Krzysztof Kozlowski wrote: >> On 24/12/2023 19:32, Frank Li wrote: >>> Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string. >>> Add reg-name: "atu", "dbi2", "dma" and "app". >>> Reuse PCI linux,pci-domain as controller id at endpoint. >>> >>> Signed-off-by: Frank Li >>> --- >>> >> >> ... >> >>> +# reuse PCI linux,pci-domain as controller id at Endpoint >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - fsl,imx95-pcie-ep >>> + then: >>> + properties: >>> + linux,pci-domain: true >> >> Same comment: why do you need? Don't ignore my feedback. You responded >> you will fix it, but it is still here... > > DTB_CHECK report error after I remove it. linux,pci-domain is only define > in pci, not pci-ep. Ah, thank you, indeed. > > So I add comments about this. linux,pci-domain was resued ad controller id. However maybe there is reason why it is not for endpoints. The description is saying it is valid only for host bridge, so maybe it should not be used for endpoint case? > > If include pci.yaml, there are too much other properties was involved, but > not used by pci-ep. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel