From mboxrd@z Thu Jan 1 00:00:00 1970 From: kgene.kim@samsung.com (Kukjin Kim) Date: Thu, 20 Mar 2014 13:16:21 +0900 Subject: [PATCH 55/62] ARM: samsung: select CRC32 for SAMSUNG_PM_CHECK In-Reply-To: <1395257399-359545-56-git-send-email-arnd@arndb.de> References: <1395257399-359545-1-git-send-email-arnd@arndb.de> <1395257399-359545-56-git-send-email-arnd@arndb.de> Message-ID: <023801cf43f3$2682bd50$738837f0$@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Arnd Bergmann wrote: > > The Samsung pm_check code uses the crc32 library code, which can > be built as a loadable module, in which case we get a link error > building the kernel. > > A better solution is to use 'select CRC32', which is what all > other users of this code do, as it ensures it is always built-in. > Agreed. > Signed-off-by: Arnd Bergmann > Cc: Tomasz Figa > Cc: Kukjin Kim Acked-by: Kukjin Kim Thanks, Kukjin > Cc: Ben Dooks > --- > arch/arm/plat-samsung/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig > index c72d612..98f223c 100644 > --- a/arch/arm/plat-samsung/Kconfig > +++ b/arch/arm/plat-samsung/Kconfig > @@ -445,7 +445,8 @@ config S3C_PM_DEBUG_LED_SMDK > > config SAMSUNG_PM_CHECK > bool "S3C2410 PM Suspend Memory CRC" > - depends on PM && CRC32 > + depends on PM > + select CRC32 > help > Enable the PM code's memory area checksum over sleep. This option > will generate CRCs of all blocks of memory, and store them before > -- > 1.8.3.2