From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09168CA0EE8 for ; Wed, 17 Sep 2025 12:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:In-Reply-To:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=owWadpSv9H77ZxbKoBmofshhPRj3pGK/wIU+s8/EQVc=; b=iIFA8YXwy4O6Rrl4jy5tIFSme/ azsjqTiQJVgORmhegupmEw/G4Q8reaD7lytOz32iTIK/gXseo4UJrBfiwLndNG8ZroZk3pHo9jJBE 1jWigtZ3vvB3y/Jr65PltiG0HFbjY78YOiEiOOc+vYPiY6t4NODvUYhPDsUBYeOqesaFZVaIeQuWm DmgtMhBD5SftpJ7TRrKPCOFUO9aVh/IbWVerBsGaYf9e/XgFnRsQ4cjVtVLKUzPFiVtrbY+3lFnOQ tMu6K+pq+V/KQ82kfLFtRVlzW7zgwUCit5HzxiFftkl60xOmUOaiDv5Ihe+y/DYqGItWIgZYw5AOs TJ5q2T7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uyqyz-0000000BEp3-3po8; Wed, 17 Sep 2025 12:09:57 +0000 Received: from mailout3.samsung.com ([203.254.224.33]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uyqyx-0000000BEnY-0wZN for linux-arm-kernel@lists.infradead.org; Wed, 17 Sep 2025 12:09:56 +0000 Received: from epcas5p4.samsung.com (unknown [182.195.41.42]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20250917120943epoutp03d8d480172bd81ec1c9a0ca003b7f3ecc~mEJ-MkGub2628026280epoutp03f for ; Wed, 17 Sep 2025 12:09:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20250917120943epoutp03d8d480172bd81ec1c9a0ca003b7f3ecc~mEJ-MkGub2628026280epoutp03f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1758110983; bh=owWadpSv9H77ZxbKoBmofshhPRj3pGK/wIU+s8/EQVc=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=WBNlnGOyvhvdURAbgVsc8eIroy5H8a2SRO75EfKSBc741Nklz9GuHlXwKhGkpBx7i NJ4PocbRepuBeZmxh6sDk2lkIC6+IfkVvFVtbwTWIqq00H9tVxmPrUcs4OBKvjsIBT IH6udZJYiSGrQ0QhlT51XCv96TJuZCZo1e68KdI4= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPS id 20250917120942epcas5p357c123d3099e83bb132f2cf79da872fb~mEJ_a0QgV0694206942epcas5p3J; Wed, 17 Sep 2025 12:09:42 +0000 (GMT) Received: from epcas5p1.samsung.com (unknown [182.195.38.93]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4cRcyY23SNz3hhT4; Wed, 17 Sep 2025 12:09:41 +0000 (GMT) Received: from epsmtip2.samsung.com (unknown [182.195.34.31]) by epcas5p2.samsung.com (KnoxPortal) with ESMTPA id 20250917120940epcas5p2ccd8cbd489fe1634d9b176f1e8c01e79~mEJ85vD6F3174731747epcas5p26; Wed, 17 Sep 2025 12:09:40 +0000 (GMT) Received: from FDSFTE196 (unknown [107.116.189.214]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20250917120937epsmtip29e2450f342f91ad1dce9599cf91c9426~mEJ6DjSln1850718507epsmtip2N; Wed, 17 Sep 2025 12:09:37 +0000 (GMT) From: "Inbaraj E" To: "'Rob Herring'" Cc: , , , , , , , , , , , , , , , , , , , In-Reply-To: <20250829174638.GA1054721-robh@kernel.org> Subject: RE: [PATCH v3 1/7] dt-bindings: media: nxp: Add support for FSD SoC Date: Wed, 17 Sep 2025 17:39:35 +0530 Message-ID: <024f01dc27cb$f167d370$d4377a50$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIBSJFzUA8Lz5NCh/Whmc1GwVh24gH1qTvqAkLBkWsB/yoSjrQbSRSA Content-Language: en-in X-CMS-MailID: 20250917120940epcas5p2ccd8cbd489fe1634d9b176f1e8c01e79 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P cpgsPolicy: CPGSC10-541,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250828085926epcas5p1b82576210280fb44c6c7f02851da71c6 References: <20250828085911.81266-1-inbaraj.e@samsung.com> <20250828085911.81266-2-inbaraj.e@samsung.com> <20250829174638.GA1054721-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250917_050955_578398_B6766885 X-CRM114-Status: GOOD ( 18.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, Thanks for the review > > + description: > > + Syscon used to hold and release the reset of MIPI D-PHY > > Reset? Sounds like you should be using the reset binding. The Tesla FSD Soc does not have a dedicated reset controller. Instead, we are using the system controller which is MMIO Space handled by syscon driver, to assert or de-assert the D-PHY reset. So, I prefer to use syscon. > > > + > > phy-supply: > > description: The MIPI D-PHY digital power supply > > > > @@ -93,7 +91,8 @@ properties: > > properties: > > data-lanes: > > description: > > - Note that 'fsl,imx7-mipi-csi2' only supports up to 2 data lines. > > + Note that 'fsl,imx7-mipi-csi2' only supports up to 2 data > > + lines. > > Reformatting should be a separate patch. Sure, I'll add new patch in next patchset. > > > minItems: 1 > > items: > > - const: 1 > > @@ -115,7 +114,6 @@ required: > > - interrupts > > - clocks > > - clock-names > > - - power-domains > > - ports > > > > additionalProperties: false > > @@ -124,20 +122,73 @@ allOf: > > - if: > > properties: > > compatible: > > - contains: > > - const: fsl,imx7-mipi-csi2 > > + const: fsl,imx7-mipi-csi2 > > 'contains' was correct. It is more future proof when there is another SoC that > is backwards compatible with imx7. Sure, I'll add new patch in next patchset. > > > then: > > + properties: > > + clocks: > > + items: > > + - description: The peripheral clock (a.k.a. APB clock) > > + - description: The external clock (optionally used as the pixel > > + clock) > > + - description: The MIPI D-PHY clock > > + clock-names: > > + items: > > + - const: pclk > > + - const: wrap > > + - const: phy > > + tesla,syscon-csis: false > > + fsl,num-channels: false > > blank line Will remove in nextpatchset. > > > required: > > + - power-domains > > - phy-supply > > - resets > > - else: > > + > > + - if: > > + properties: > > + compatible: > > + const: fsl,imx8mm-mipi-csi2 > > + then: > > properties: > > clocks: > > - minItems: 4 > > + items: > > + - description: The peripheral clock (a.k.a. APB clock) > > + - description: The external clock (optionally used as the pixel > > + clock) > > + - description: The MIPI D-PHY clock > > + - description: The AXI clock > > clock-names: > > - minItems: 4 > > + items: > > + - const: pclk > > + - const: wrap > > + - const: phy > > + - const: axi > > + tesla,syscon-csis: false > > + fsl,num-channels: false > > phy-supply: false > > resets: false > > blank line > > > + required: > > + - power-domains > > + > > + - if: > > + properties: > > + compatible: > > + const: tesla,fsd-mipi-csi2 > > + then: > > + properties: > > + clocks: > > + items: > > + - description: The peripheral clock (a.k.a. APB clock) > > + - description: The DMA clock > > Wouldn't this be the same as the "AXI clock"? According to v4.3 manual it is DMA clock. > > > + clocks-names: > > + items: > > + - const: pclk > > + - const: aclk > > + phy-supply: false > > + resets: false > > + power-domains: false > > blank line Sure will remove in next patchset. > > > + required: > > + - tesla,syscon-csis > > + - fsl,num-channels > > > > examples: > > - | > > -- > > 2.49.0 > > Regards, Inbaraj E