From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9371CC77B6F for ; Tue, 11 Apr 2023 17:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=A9VG6RuXCAbqrFlNwP596kzXC44crMsWrKfVHHZ9IRA=; b=Oh9y5RV1r7kHux 8fjaDrP++Jg7Ua5J0BQlWqQ3xPlIuYqjV6ZZ7ZwStREemsJMprR+5/jiHEgu4tVPJ19lyI2xAKYXg cxZZhD+YRIwY6RKp2GujLdT87olBJGdP2e65Ju/yVRbqOgnTkUa06xJDuAPhxTQKB2uJy6bhkPwM8 Sje2VVIv1awCXSvNBCHbzjjyMGinqudU+92MGsLKX5B4BA9ybWMbPjGvGwIgx+RjtaK+HszEsyp1P z58ogk8nkUAJAB9lpPhhdTFIYZNlPclZOcy30ueOidYpZIQTyg1jdBquRl/ZJuFex1tQQ3i/OMgnc hMBBdGrU7iJ3gu7Ohl1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmHcR-000h3J-09; Tue, 11 Apr 2023 17:17:23 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmHcO-000h2t-0F for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 17:17:21 +0000 Received: by mail-ej1-x631.google.com with SMTP id qb20so21801237ejc.6 for ; Tue, 11 Apr 2023 10:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681233438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f3NLFlTFXQ8L7LUpA/rzLmOr+Nhbuct/tCMEekGX4hs=; b=lzVj3UtqYZAKqhPsvbMZAll1i6qMP3h0Bv0VSeLWKTmnxmU7/bkWc79ZZy1OyLymhW sFbBjEjXIxxh+o9KdXMpQ0d7iNJ5pBjVmWv2W2QlE4uXdOjKxiogylN+f3o5Tqwa7uxd lBmIK2SNX3+HJMoFESkDG+b6LnrqWK9du/pPUbkZmjYcq7XXWTJe8fi3s8lWMHy0ODg+ NFJrxry6ihOKl3rq5vRT6jrg3zo0RPagu4plQ4Q+oeF5fT8sAD/O8oYwkMDW/ngc3NJV vsYNnoHySoWH+SxTeomH92DnHSo3IREXr1PGec5he7AoY+qOLg2W2H/o/ygosHazHlvD eROQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681233438; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f3NLFlTFXQ8L7LUpA/rzLmOr+Nhbuct/tCMEekGX4hs=; b=68TyD0H09Nibfb5k3VkT9g7gwAVUEgys/HEBp3YWftj/EQ8dfkjODwmIZdIGTJ/VsW hFEGKS9PAZEvgSVkUF3kSn8VbcUO3ubZY99CrGI/514mfqMy9hisevTGuHqsGZTURYDp hMez+dMtkcRYHRwZyHLolH9CZ8Ef2zS+Io3QEJWUdWLC1v0lB8oQJDi4kHatWOTGMLQu HqIJ6TcvB8mF5IRAf7lJrtxjf9HhzZovKUYPa4Eqxhh1yxHjJVOURiEZ81C8xc93jOy6 wEywTi6Kl9o+XazEjui0Q7xWp2t74tAFuam3mqnUv4I3NGBCKa+dwJP71AuKgsAqCNFv fdNw== X-Gm-Message-State: AAQBX9elYcgEIVp1VDdlpn97BYzgT304fvQQcLBDHiC+Qpopy5XX6j74 TNz1NvmvnIFs3D6J4f0XU49kSQ== X-Google-Smtp-Source: AKy350Zsgz8RMXWnUNnhZD32QceyI5jdgByDvpV3hdoOpev7un4pmMzNwZvhVrgMQleDzMz7EHI6qw== X-Received: by 2002:a17:907:a44:b0:930:3916:df1d with SMTP id be4-20020a1709070a4400b009303916df1dmr14552079ejc.0.1681233438190; Tue, 11 Apr 2023 10:17:18 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:f1da:c117:3657:c8a? ([2a02:810d:15c0:828:f1da:c117:3657:c8a]) by smtp.gmail.com with ESMTPSA id ss25-20020a170907c01900b0093e261cc8bcsm6354397ejc.58.2023.04.11.10.17.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 10:17:17 -0700 (PDT) Message-ID: <0255ff85-71e2-2174-2188-82899b6e9678@linaro.org> Date: Tue, 11 Apr 2023 19:17:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] dt-bindings: firmware: arm,scmi: support parameter passing in smc/hvc Content-Language: en-US To: Nikunj Kela , sudeep.holla@arm.com Cc: cristian.marussi@arm.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230409181918.29270-1-quic_nkela@quicinc.com> <20230409181918.29270-2-quic_nkela@quicinc.com> <5d264f46-b9e8-62ec-9bce-9d666fd1eaa8@linaro.org> <74551421-56df-73d3-3f4d-1708768e207a@quicinc.com> From: Krzysztof Kozlowski In-Reply-To: <74551421-56df-73d3-3f4d-1708768e207a@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_101720_113873_97CDC564 X-CRM114-Status: GOOD ( 28.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/04/2023 19:33, Nikunj Kela wrote: > > On 4/10/2023 10:20 AM, Krzysztof Kozlowski wrote: >> On 09/04/2023 20:19, Nikunj Kela wrote: >>> Currently, smc/hvc calls are made with smc-id only. The parameters are >>> all set to zeros. This patch defines two optional device tree bindings, >>> that can be used to pass parameters in smc/hvc calls. >>> >>> This is useful when multiple scmi instances are used with common smc-id. >>> >>> Signed-off-by: Nikunj Kela >>> --- >>> .../devicetree/bindings/firmware/arm,scmi.yaml | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>> index 5824c43e9893..08c331a79b80 100644 >>> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml >>> @@ -115,6 +115,22 @@ properties: >>> description: >>> SMC id required when using smc or hvc transports >>> >>> + arm,smc32-params: >>> + $ref: /schemas/types.yaml#/definitions/uint32-array >>> + description: >>> + An optional parameter list passed in smc32 or hvc32 calls >>> + default: 0 >>> + minItems: 1 >>> + maxItems: 6 >>> + >>> + arm,smc64-params: >>> + $ref: /schemas/types.yaml#/definitions/uint64-array >>> + description: >>> + An optional parameter list passed in smc64 or hvc64 calls >>> + default: 0 >>> + minItems: 1 >>> + maxItems: 6 >> These do not look like hardware properties and the fact that you need >> two properties for the same also points that you tied it to specific SW >> interface. > > This is certainly not the H/W property but then smc-id is also not H/W > property either Yep, maybe it should be also removed? > > but that gets passed via DTB. I could use the same property for both > however I wasn't sure > > which datatype should be used, uint32-array/uint64-array. Moreover, I > thought if users are > > passing parameters, they better know which SMC convention they are using > hence used two > > explicit properties. Does not solve my concern. > >> Why this should be board-specific? Actually better question - why this >> should be fixed per board? Doesn't my software want to have different >> parameters, depending on some other condition? > > Not sure I follow, I didn't say this is board specific. But putting it in DTS which is customized per board is then board specific. > People can use > the parameters to pass > > whatever their S/W demands. SMC/HVC calls are made by passing parameters > which is what this patch is enabling. I cannot follow your paragraphs. You cut middle of sentence. Anyway, if this is to match whatever their SW demands, it is not Devicetree property. > >> >> You also did not provide any DTS user for this, so difficult to judge >> usefulness. > > The work is still on going and we will push the dts in few months, > however that shouldn't stop > > making changes in advance. With a proper DTS maybe it would be easier to convince us why SW interface should be put to Devicetree... but sure, we can skip DTS and answer is - this looks like SW property and not a DT. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel