* [PATCH] infiniband: cxgb4: use %pR format string for printing resources
@ 2016-02-01 16:42 Arnd Bergmann
2016-02-01 16:45 ` Steve Wise
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-02-01 16:42 UTC (permalink / raw)
To: linux-arm-kernel
The cxgb4 prints an MMIO resource using the "0x%x" and "%p" format
strings on the length and start, respective, but that
triggers a compiler warning when using a 64-bit resource_size_t
on a 32-bit architecture:
drivers/infiniband/hw/cxgb4/device.c: In function 'c4iw_rdev_open':
drivers/infiniband/hw/cxgb4/device.c:807:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
(void *)pci_resource_start(rdev->lldi.pdev, 2),
This changes the format string to use %pR instead, which pretty-prints
the resource, avoids the warning and is shorter.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This is an old warning I see rarely on ARM randconfig builds.
diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
index 8024ea4417b8..ebd60a20f148 100644
--- a/drivers/infiniband/hw/cxgb4/device.c
+++ b/drivers/infiniband/hw/cxgb4/device.c
@@ -801,10 +801,9 @@ static int c4iw_rdev_open(struct c4iw_rdev *rdev)
rdev->lldi.vr->qp.size,
rdev->lldi.vr->cq.start,
rdev->lldi.vr->cq.size);
- PDBG("udb len 0x%x udb base %p db_reg %p gts_reg %p "
+ PDBG("udb %pR db_reg %p gts_reg %p "
"qpmask 0x%x cqmask 0x%x\n",
- (unsigned)pci_resource_len(rdev->lldi.pdev, 2),
- (void *)pci_resource_start(rdev->lldi.pdev, 2),
+ &rdev->lldi.pdev->resource[2],
rdev->lldi.db_reg, rdev->lldi.gts_reg,
rdev->qpmask, rdev->cqmask);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] infiniband: cxgb4: use %pR format string for printing resources
2016-02-01 16:42 [PATCH] infiniband: cxgb4: use %pR format string for printing resources Arnd Bergmann
@ 2016-02-01 16:45 ` Steve Wise
0 siblings, 0 replies; 2+ messages in thread
From: Steve Wise @ 2016-02-01 16:45 UTC (permalink / raw)
To: linux-arm-kernel
> Subject: [PATCH] infiniband: cxgb4: use %pR format string for printing resources
>
> The cxgb4 prints an MMIO resource using the "0x%x" and "%p" format
> strings on the length and start, respective, but that
> triggers a compiler warning when using a 64-bit resource_size_t
> on a 32-bit architecture:
>
> drivers/infiniband/hw/cxgb4/device.c: In function 'c4iw_rdev_open':
> drivers/infiniband/hw/cxgb4/device.c:807:7: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> (void *)pci_resource_start(rdev->lldi.pdev, 2),
>
> This changes the format string to use %pR instead, which pretty-prints
> the resource, avoids the warning and is shorter.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> This is an old warning I see rarely on ARM randconfig builds.
Acked-by: Steve Wise <swise@opengridcomputing.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-02-01 16:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-01 16:42 [PATCH] infiniband: cxgb4: use %pR format string for printing resources Arnd Bergmann
2016-02-01 16:45 ` Steve Wise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).