From: k.debski@samsung.com (Kamil Debski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove()
Date: Tue, 28 Jun 2016 11:57:29 +0200 [thread overview]
Message-ID: <025e01d1d123$7c14e620$743eb260$@samsung.com> (raw)
In-Reply-To: <1465847114-7427-1-git-send-email-shuahkh@osg.samsung.com>
HI Shuah,
Which branch do you base your patches on?
I have trouble applying this path
(https://patchwork.linuxtv.org/patch/34577/) and
"s5p-mfc fix null pointer deference in clk_core_enable()"
(https://patchwork.linuxtv.org/patch/34751/)
onto current linuxtv/master.
The top commit of linuxtv/master is :
"commit 0db5c79989de2c68d5abb7ba891bfdb3cd3b7e05
Author: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Date: Thu Jun 16 08:04:40 2016 -0300
[media] media-devnode.h: Fix documentation"
Could you please rebase the two patches mentioned above to the
linuxtv/master?
Best wishes,
--
Kamil Debski
Samsung R&D Institute Poland
> -----Original Message-----
> From: Shuah Khan [mailto:shuahkh at osg.samsung.com]
> Sent: Monday, June 13, 2016 9:45 PM
> To: kyungmin.park at samsung.com; k.debski at samsung.com;
> jtp.park at samsung.com; mchehab at osg.samsung.com
> Cc: Shuah Khan; linux-arm-kernel at lists.infradead.org; linux-
> media at vger.kernel.org; linux-kernel at vger.kernel.org
> Subject: [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove()
>
> s5p_mfc_remove() fails to release encoder and decoder video devices.
>
> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> Changes since v1:
> - Addressed comments from Javier Martinez Canillas and added
> his reviewed by:
>
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> index 274b4f1..f537b74 100644
> --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
> +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
> @@ -1318,6 +1318,8 @@ static int s5p_mfc_remove(struct platform_device
> *pdev)
>
> video_unregister_device(dev->vfd_enc);
> video_unregister_device(dev->vfd_dec);
> + video_device_release(dev->vfd_enc);
> + video_device_release(dev->vfd_dec);
> v4l2_device_unregister(&dev->v4l2_dev);
> s5p_mfc_release_firmware(dev);
> vb2_dma_contig_cleanup_ctx(dev->alloc_ctx[0]);
> --
> 2.7.4
next prev parent reply other threads:[~2016-06-28 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-13 19:45 [PATCH] media: s5p-mfc fix memory leak in s5p_mfc_remove() Shuah Khan
2016-06-28 9:57 ` Kamil Debski [this message]
2016-06-28 13:39 ` Shuah Khan
2016-06-28 15:55 ` Shuah Khan
2016-06-28 19:27 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2016-06-09 1:35 Shuah Khan
2016-06-13 13:42 ` Javier Martinez Canillas
2016-06-13 15:38 ` Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='025e01d1d123$7c14e620$743eb260$@samsung.com' \
--to=k.debski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).