From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] ARM: EXYNOS: mach: Improvements for 4.3
Date: Thu, 23 Jul 2015 16:58:16 +0900 [thread overview]
Message-ID: <028b01d0c51d$553710e0$ffa532a0$@kernel.org> (raw)
In-Reply-To: <55AED996.9090208@samsung.com>
Krzysztof Kozlowski wrote:
>
> On 21.07.2015 14:21, Krzysztof Kozlowski wrote:
> > 2015-07-21 14:13 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> >> 2015-07-21 14:02 GMT+09:00 Kukjin Kim <kgene@kernel.org>:
> >>> Krzysztof Kozlowski wrote:
[...]
> >>>> --
> >>>
> >>> Applied above changes into fixes/non-critical, next/cleanup-samsung,
> >>> next/dt-samsung and next/cpufreq-clk-samsung according to the change.
> >
> > Cc-ed Bartlomiej,
> >
> > One issue found: splitting DTS change for Exynos 5250 cpufreq to
> > separate branch will break bisectability. The commit "ARM: dts:
> > Exynos5250: add CPU OPP and regulator supply property":
> > 1. MUST be put after "clk: samsung: exynos5250: add cpu clock
> > configuration data and instantiate cpu clock" to prevent build
> > failures,
> > 2. should be put before "ARM: Exynos: switch to using generic cpufreq
> > driver for Exynos5250" to prevent lost cpufreq functionality.
> >
> > Doing otherwise would lose bisectability which is really unfortunate
> > when you can simply avoid it. This should remain in the same branch -
> > next/cpufreq-clk-samsung.
>
> Dear Kukjin,
>
> Nothing changed since yesterday... so let me point this in a more clear
> way. The way you divided the patchset causes build errors:
>
> --------------
> HEAD is now at 565872a601c4... ARM: dts: add CPU OPP and regulator
> supply property for exynos5250
>
> ERROR: Failed build: -A arm -c exynos on
> 565872a601c4d91a75b917b1fb40ff27ad7ebb08
>
> LOGS:
> Error: ../arch/arm/boot/dts/exynos5250.dtsi:65.21-22 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [arch/arm/boot/dts/exynos5250-arndale.dtb] Error 1
> make[1]: *** [dtbs] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [sub-make] Error 2
> --------------
>
> This breaks bisectability without any special valid reason.
>
Hi,
I couldn't check e-mail yesterday because of annual health check.
Anyway, I'll look at the error and handle it soon.
Thanks for your check.
Kukjin
next prev parent reply other threads:[~2015-07-23 7:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 2:41 [GIT PULL] ARM: EXYNOS: dts: Improvements for 4.3 Krzysztof Kozlowski
2015-07-16 2:41 ` [GIT PULL] ARM: EXYNOS: mach: " Krzysztof Kozlowski
2015-07-21 5:02 ` Kukjin Kim
2015-07-21 5:13 ` Krzysztof Kozlowski
2015-07-21 5:21 ` Krzysztof Kozlowski
2015-07-21 23:45 ` Krzysztof Kozlowski
2015-07-23 7:58 ` Kukjin Kim [this message]
2015-07-23 8:11 ` Kukjin Kim
2015-07-23 8:18 ` Krzysztof Kozlowski
2015-07-21 4:56 ` [GIT PULL] ARM: EXYNOS: dts: " Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='028b01d0c51d$553710e0$ffa532a0$@kernel.org' \
--to=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).