From: Krzysztof Kozlowski <krzk@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>, Tony Lindgren <tony@atomide.com>
Cc: soc@kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"David S. Miller" <davem@davemloft.net>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Eric Dumazet" <edumazet@google.com>,
"Felipe Balbi" <balbi@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"Johannes Berg" <johannes@sipsolutions.net>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-omap@vger.kernel.org,
"Christian Lamparter" <chunkeey@gmail.com>
Subject: Re: [PATCH v2 3/3] p54spi: convert to devicetree
Date: Fri, 7 Apr 2023 09:10:48 +0200 [thread overview]
Message-ID: <028c7d3a-7013-84ad-d667-0b252a5db076@kernel.org> (raw)
In-Reply-To: <20230404082401.1087835-4-arnd@kernel.org>
On 04/04/2023 10:24, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The Prism54 SPI driver hardcodes GPIO numbers and expects users to
> pass them as module parameters, apparently a relic from its life as a
> staging driver. This works because there is only one user, the Nokia
> N8x0 tablet.
>
> Convert this to the gpio descriptor interface and DT based probing
> to improve this and simplify the code at the same time.
>
> Acked-by: Christian Lamparter <chunkeey@gmail.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> MAINTAINERS | 1 +
> arch/arm/mach-omap2/board-n8x0.c | 18 ------
> drivers/net/wireless/intersil/p54/p54spi.c | 71 ++++++++--------------
> drivers/net/wireless/intersil/p54/p54spi.h | 3 +
> 4 files changed, 30 insertions(+), 63 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 4f57deee1a08..9b08dcea913a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15793,6 +15793,7 @@ M: Christian Lamparter <chunkeey@googlemail.com>
> L: linux-wireless@vger.kernel.org
> S: Maintained
> W: https://wireless.wiki.kernel.org/en/users/Drivers/p54
> +F: Documentation/devicetree/bindings/net/wireless/st,stlc45xx.yaml
> F: drivers/net/wireless/intersil/p54/
This hunk should be rather part of your patch #1.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-04-07 7:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 8:23 [PATCH v2 0/3] p54spi devicetree conversion Arnd Bergmann
2023-04-04 8:23 ` [PATCH v2 1/3] dt-bindings: net: add st,stlc45xx Arnd Bergmann
2023-04-07 7:04 ` Krzysztof Kozlowski
2023-04-04 8:24 ` [PATCH v2 2/3] ARM: dts: omap2: add stlc4560 spi-wireless node Arnd Bergmann
2023-04-07 7:05 ` Krzysztof Kozlowski
2023-04-04 8:24 ` [PATCH v2 3/3] p54spi: convert to devicetree Arnd Bergmann
2023-04-07 7:10 ` Krzysztof Kozlowski [this message]
2023-04-04 11:06 ` [PATCH v2 0/3] p54spi devicetree conversion Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=028c7d3a-7013-84ad-d667-0b252a5db076@kernel.org \
--to=krzk@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=balbi@kernel.org \
--cc=bcousson@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=chunkeey@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).