From: "Macpaul Lin (林智斌)" <Macpaul.Lin@mediatek.com>
To: "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"Jianjun Wang (王建军)" <Jianjun.Wang@mediatek.com>,
"Joying Kuo (郭羽喬)" <Joying.Kuo@mediatek.com>,
"Guoqing Jiang" <guoqing.jiang@canonical.com>,
"Jingming Jiang (江经明)" <ot_jingming.jiang@mediatek.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"TingHan Shen (沈廷翰)" <TingHan.Shen@mediatek.com>,
"Jieyy Yang (杨洁)" <Jieyy.Yang@mediatek.com>,
"Chuanjia Liu (柳传嘉)" <Chuanjia.Liu@mediatek.com>,
"Jianguo Zhang (张建国)" <Jianguo.Zhang@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0
Date: Thu, 24 Jul 2025 05:56:52 +0000 [thread overview]
Message-ID: <02910dd923a9267a82e0ebf22ec0248e71d71e71.camel@mediatek.com> (raw)
In-Reply-To: <20250721095959.57703-1-guoqing.jiang@canonical.com>
On Mon, 2025-07-21 at 17:59 +0800, Guoqing Jiang wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> When test suspend resume with 6.8 based kernel, system can't resume
> and I got below error which can be also reproduced with 6.16 rc6+
> kernel.
>
> mtk-pcie-gen3 112f0000.pcie: PCIe link down, current LTSSM state:
> detect.quiet (0x0)
> mtk-pcie-gen3 112f0000.pcie: PM: dpm_run_callback():
> genpd_resume_noirq returns -110
> mtk-pcie-gen3 112f0000.pcie: PM: failed to resume noirq: error -110
>
> After investigation, looks pcie0 has the same problem as pcie1 as
> decribed in commit 3d7fdd8e38aa ("arm64: dts: mediatek: mt8195:
> Remove suspend-breaking reset from pcie1").
>
> Fixes: ecc0af6a3fe6 ("arm64: dts: mt8195: Add pcie and pcie phy
> nodes")
> Signed-off-by: Guoqing Jiang <guoqing.jiang@canonical.com>
> ---
> arch/arm64/boot/dts/mediatek/mt8195.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> index dd065b1bf94a..50cf01452208 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8195.dtsi
> @@ -1563,9 +1563,6 @@ pcie0: pcie@112f0000 {
>
> power-domains = <&spm
> MT8195_POWER_DOMAIN_PCIE_MAC_P0>;
>
> - resets = <&infracfg_ao
> MT8195_INFRA_RST2_PCIE_P0_SWRST>;
> - reset-names = "mac";
> -
> #interrupt-cells = <1>;
> interrupt-map-mask = <0 0 0 7>;
> interrupt-map = <0 0 0 1 &pcie_intc0 0>,
> --
> 2.34.1
>
Reviewed-by: Macpaul Lin <macpaul.lin@mediatek.com>
Please help to add Cc: stable@vger.kernel.org next time.
Thanks
Macpaul Lin
next prev parent reply other threads:[~2025-07-24 6:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 9:59 [PATCH] arm64: dts: mediatek: mt8195: Remove suspend-breaking reset from pcie0 Guoqing Jiang
2025-07-21 12:13 ` AngeloGioacchino Del Regno
2025-07-24 5:40 ` Macpaul Lin (林智斌)
2025-07-24 5:56 ` Macpaul Lin (林智斌) [this message]
2025-09-09 12:36 ` Matthias Brugger
2025-09-09 12:38 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02910dd923a9267a82e0ebf22ec0248e71d71e71.camel@mediatek.com \
--to=macpaul.lin@mediatek.com \
--cc=Chuanjia.Liu@mediatek.com \
--cc=Jianguo.Zhang@mediatek.com \
--cc=Jianjun.Wang@mediatek.com \
--cc=Jieyy.Yang@mediatek.com \
--cc=Joying.Kuo@mediatek.com \
--cc=TingHan.Shen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoqing.jiang@canonical.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=ot_jingming.jiang@mediatek.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox