From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DD86C4338F for ; Fri, 30 Jul 2021 04:48:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B38760F01 for ; Fri, 30 Jul 2021 04:48:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B38760F01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=NZBPwQ1yzNKLLFzE5bngr3QR6vL4I/GY/TxtgssgKQg=; b=LL9xfohQgvW+eJCTEpKmgi9YN/ zdfUj+AggAUIDOmj3zk1Hab5znSmYO5qupa9vlwq/FTW79b6F3XPNUFP1RG9HyUuB0tmrRJdpUEP3 wTZGuv7ook4GoyG+AM7PoyxGUq/fRt+TAfLLW/Fl2Lgyq1qDwu6qtdX+KfIRnbKf29DfkIJhrT0ur UA+QvGxnOVdMllRfPoux3dCnbZHI7eYeukxdmNYgGLKyRIuhbojhMs0VHv6DW5cpWypaF88ss7g50 S5K5alqumEFyszNpx8WqPs/zOpSdXm7rpj/jL23DlUMhZWVRSX/BI8M7gYEt/6O8XO6XCsXWfPZip Ac4fBrZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9KQ3-00796Q-W9; Fri, 30 Jul 2021 04:46:48 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9KPz-00795G-JI for linux-arm-kernel@lists.infradead.org; Fri, 30 Jul 2021 04:46:45 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1440331B; Thu, 29 Jul 2021 21:46:39 -0700 (PDT) Received: from [10.163.66.9] (unknown [10.163.66.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5AFB73F73D; Thu, 29 Jul 2021 21:46:36 -0700 (PDT) Subject: Re: [PATCH v2 05/10] coresight: trbe: Drop duplicate TRUNCATE flags To: Suzuki K Poulose , coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, tamas.zsoldos@arm.com, al.grant@arm.com, leo.yan@linaro.org, mike.leach@linaro.org, mathieu.poirier@linaro.org, jinlmao@qti.qualcomm.com References: <20210723124611.3828908-1-suzuki.poulose@arm.com> <20210723124611.3828908-6-suzuki.poulose@arm.com> From: Anshuman Khandual Message-ID: <0292cfc7-df67-aa45-4268-2ebc7f53420a@arm.com> Date: Fri, 30 Jul 2021 10:17:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210723124611.3828908-6-suzuki.poulose@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210729_214643_786337_62A8E700 X-CRM114-Status: GOOD ( 25.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/23/21 6:16 PM, Suzuki K Poulose wrote: > We mark the buffer as TRUNCATED when there is no space left > in the buffer. But we do it at different points. > __trbe_normal_offset() > and also, at all the callers of the above function via > compute_trbe_buffer_limit(), when the limit == base (i.e > offset = 0 as returned by the __trbe_normal_offset()). > > So, given that the callers already mark the buffer as TRUNCATED > drop the caller inside the __trbe_normal_offset(). > > This is in preparation to moving the handling of TRUNCATED > into a central place. > > Cc: Anshuman Khandual > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Leo Yan > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-trbe.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index 446f080f8320..62e1a08f73ff 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -253,13 +253,9 @@ static unsigned long __trbe_normal_offset(struct perf_output_handle *handle) > * trbe_base trbe_base + nr_pages > * > * Perf aux buffer does not have any space for the driver to write into. > - * Just communicate trace truncation event to the user space by marking > - * it with PERF_AUX_FLAG_TRUNCATED. > */ > - if (!handle->size) { > - perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED); > + if (!handle->size) > return 0; > - } > > /* Compute the tail and wakeup indices now that we've aligned head */ > tail = PERF_IDX2OFF(handle->head + handle->size, buf); > @@ -361,7 +357,6 @@ static unsigned long __trbe_normal_offset(struct perf_output_handle *handle) > return limit; > > trbe_pad_buf(handle, handle->size); > - perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED); > return 0; > } What about in trbe_handle_spurious() path which used to set the flag via compute_trbe_buffer_limit(), but would not any more after this change. I guess following additional change would be required to preserve the past behaviour. --- a/drivers/hwtracing/coresight/coresight-trbe.c +++ b/drivers/hwtracing/coresight/coresight-trbe.c @@ -685,6 +685,7 @@ static void trbe_handle_spurious(struct perf_output_handle *handle) buf->trbe_write = buf->trbe_base + PERF_IDX2OFF(handle->head, buf); if (buf->trbe_limit == buf->trbe_base) { trbe_drain_and_disable_local(); + perf_aux_output_flag(handle, PERF_AUX_FLAG_TRUNCATED); return; } trbe_enable_hw(buf); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel