From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 887F5C4361B for ; Wed, 16 Dec 2020 14:14:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2BCED23384 for ; Wed, 16 Dec 2020 14:14:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BCED23384 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Th5V+w8S3GUsN2/V65G0HOLCN09btfG2VyLNCZZpLrU=; b=kTNxdXqhZXVVFgCl9RSHhvCNb wsA5QH8CLvibU8VRTDY18A2g0XtSBqwA3DYfFCZAZkhfTMimSlF8fi8FnD08ofnmoW8M2YHD0X+3u /PShIyPdrHOS9dWPq2z9eSpoDGmkyihxQdGFqF6bNl9iG4ULChaQTYfBHWxVi+wPMWk7yrwxNCRKj TGJLBJ/99FUcdmVSaN+7TQRSoWj1vwTc6Tibvm3tpa/LBxbL1yms9rULyQcVoIKa7PwQkHEMPHedz 5/Tdy0ep++pOdBmiegndNeDGbpvW/WR3TxYdyre2NLm/FFlDmeKtrFWKd+5RcLEVySFGfDbqMhfCH Z4Qyrt9xg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpXY6-00060N-7W; Wed, 16 Dec 2020 14:13:02 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kpXY2-0005zl-RJ for linux-arm-kernel@lists.infradead.org; Wed, 16 Dec 2020 14:13:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1608127978; x=1639663978; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=LzxMH1ApuvFBfFKn0bKSmf22K3xfjmIsfppMZOJIQC4=; b=U5fNucD2Tp65fPqqsllLjHzxMsclAb94A0MQG5jMfTx5OR+P6A3LK8Rd z8MnKbeerOtz+eZYbVvUb7sOb0qj8oN6r4C+LKOUJpIZ0P3dEsai5lT3/ tkaRJjkOvLow+wJdLjUss//IeH+XC+ba6lEu1/gppDYBy6atK8AnWIe3J 8UxKu30SWOpnGAUApv0zB2wrgKJBpP4OFVS4swPIyssP0HqWVtgsq9JOu gAbhulGVJpKDWQ19FyXk4YzqmZIhp2OQr6r9gdtsB04o3NKYzcvpVicdX U2xwf68/V4+1qNuu7gE4XFNDooPMvifJzM4ciiTvw1mH13BiaixaKBVKG Q==; IronPort-SDR: WcbwAMd+jOaJg0rIyir8N9kavZYBq2sLK56Ax65jJyuMcx9umup3gbKzCM+7z17u0JAHylP7hR H5kAkmr7d645iPeN8u6xTy1gjPuSJYhvCqaNLbvS3d8IWn19TWLXkiH/kckVVnE8/cw8nJC47Q 90KwR/BeALof3wwwnW7Bfez3gPOon/dK08n/j+olFKF6ndLT3xCgVbunHF84dGdBPj89m8QUJs NFoQLUtioin558bfFN12o7rHWDOuu1YRbC3efaeKpeBQ1JykZHTh3Q9digRb+FcfGadxh44hLG vt0= X-IronPort-AV: E=Sophos;i="5.78,424,1599548400"; d="scan'208";a="37625634" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 16 Dec 2020 07:12:57 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Wed, 16 Dec 2020 07:12:57 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.87.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3 via Frontend Transport; Wed, 16 Dec 2020 07:12:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LYqt7g1f/fEh+UlIQmxVcQ5tSEI6cf6Wr4/tMBpI7p11bof97oQW8jZr34P87zYQze052jBb7tzW+DmeZeTDE4qLQWlqXSv7NssX5IzIxbD1KoHKre6XHw/qmZOCHksapJE+JpVGGEqAnkDkYZPbLOZLPW8xb975JzTtLVYfcBbxi3p6JXn9iDN8zBK7VNtNNhz/as8jm3GjWT68PhhwqE+qfJPE/izdouakds0Q993ujMrUp406vQNl43L8b6/CJzgpKoBTq35znWKwiLYf14PSboqzgwCCEMPCD4JI962SfqHW1NPDK4+W9xTPfgdiwaUqBin325PWMzEGkIBdUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzxMH1ApuvFBfFKn0bKSmf22K3xfjmIsfppMZOJIQC4=; b=UA6VLpxfli0bUYzsgjvomFgtswbF1PeZ3TZZwiEFbiXE/o2uzhSJm0ZO9zisRISheNxXEbSWN1PLmr9IBrq0BA6LJyFMk+6FXX5VUFMa61EoMMJ3eHQOjuENYRgUWI246G5vV2ybB4H5ko/HavwbOZ5E/1Ki4Pdaah8Mc1ukP+1OuzNIX8EtJGBS82x6IopqxKLT/Q8jPnjk4hfP7Lu5nydOz3T6kpz/XsWleTLES3zdJXu4UwlZkJCIBGxo+z7ieMpZavq6ca/e4TwTND6fIvYsRNdFANRwlMvuD8mKjI6Km71skf8VKiqO9Xvsjpj+xoGGJ1fwP2Xnmx9MBd7VVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microchip.com; dmarc=pass action=none header.from=microchip.com; dkim=pass header.d=microchip.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector2-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LzxMH1ApuvFBfFKn0bKSmf22K3xfjmIsfppMZOJIQC4=; b=f4aU59W013FIchogFHosEZG0Sknkuvt2u7IA75ViAh1YCndyD1DIoqy3vJzie68HhPif8RTzjeLnxhF6RAEUu5SDjGSnep1Zddpc5Zi2i9rEm0ylKIJU1/qYcto5MqnvCCf5wwLAHYPh2KKWz4xqRvBUe6Hn6WzAk2ElhlM3jHU= Received: from DM6PR11MB3420.namprd11.prod.outlook.com (2603:10b6:5:69::31) by DM6PR11MB4722.namprd11.prod.outlook.com (2603:10b6:5:2a7::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.12; Wed, 16 Dec 2020 14:12:56 +0000 Received: from DM6PR11MB3420.namprd11.prod.outlook.com ([fe80::eded:bdb6:c6f1:eb3e]) by DM6PR11MB3420.namprd11.prod.outlook.com ([fe80::eded:bdb6:c6f1:eb3e%4]) with mapi id 15.20.3654.025; Wed, 16 Dec 2020 14:12:56 +0000 From: To: Subject: Re: [PATCH 3/3] power: reset: at91-sama5d2_shdwc: add support for sama7g5 Thread-Topic: [PATCH 3/3] power: reset: at91-sama5d2_shdwc: add support for sama7g5 Thread-Index: AQHW07WM8svOvDAvX0CwyDsoq7Wrnw== Date: Wed, 16 Dec 2020 14:12:55 +0000 Message-ID: <02a1a3f5-1663-105a-2fff-9d5961d70792@microchip.com> References: <1608123453-1423-1-git-send-email-claudiu.beznea@microchip.com> <1608123453-1423-4-git-send-email-claudiu.beznea@microchip.com> <20201216134532.GH2814589@piout.net> In-Reply-To: <20201216134532.GH2814589@piout.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 authentication-results: bootlin.com; dkim=none (message not signed) header.d=none;bootlin.com; dmarc=none action=none header.from=microchip.com; x-originating-ip: [82.76.227.226] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1fb8dc35-15c7-41d9-ad31-08d8a1ccaf5c x-ms-traffictypediagnostic: DM6PR11MB4722: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-bypassexternaltag: True x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qBkAwYYx/486cHRddjLTXnrNcM8OxVuQy8HAspBxO18NQu8AUEg3FiwaSM8bO34NFiTvlYsPP1emUEtoVVdaq4yP/27JJh04mdk4t+qph7iiTqLfyg6FZgOZSXnE1M8wl8YJDzcM5AhNrqZLf6ojQhGiAkGb2yPOjwfd1qhYb5yYhnQXORoAFl8MODtKKT3X2eppMwVY9JIcURnFYYnzasj4dUIyopMFtBqQOgBhOtlvAgKM69pMjOzKMRdlndcwSpiSJHXMGc1Sy465ztdIU1pGRP7q3Lr+KdLgnVTZTkswAi3mGdz+xP/GLNGfLMuoRVvQS8TbqH/A6isivO2OZVBXhBYvQdjX48IR0eHRomFKRP1A7rAtVTIRFrUlQPWKHsKr4lYlVuoi4uN868xdMMeiC+A6VCB9ivBQ6VGON2q+agKtTTabXQh8tzCT3htBJBtjKi1kmKBcCgMUstzg7bYlDWKbv7CT6d6tA6S51Qf80YamHn9s+sDGmk0yfPxockqZgNLWJoRMvhU7evO3YA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3420.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39860400002)(396003)(136003)(366004)(346002)(8936002)(66476007)(66446008)(66556008)(4326008)(54906003)(83380400001)(26005)(6486002)(36756003)(316002)(91956017)(31686004)(8676002)(76116006)(966005)(71200400001)(64756008)(86362001)(2616005)(478600001)(31696002)(66946007)(6512007)(186003)(5660300002)(6506007)(2906002)(6916009)(53546011)(138113003)(45980500001)(43740500002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?utf-8?B?OVh4VDdFdXhYcmpsZEdPckRRS3JGNHNyNFJuRWRwZ1Vuc21FU1JOWkhodzRi?= =?utf-8?B?eVBHK1dCMXQ0OXJ3NWFKQzFrUmhWMU91eHp0NVI3aDR5TEVQT2RjYVM0Z1ZY?= =?utf-8?B?dHBVd1M0a0JYZHRBVDFXRE0xMy8yRW5yQWIzbURQN2Fwb3dSblgvSHk0ZVVo?= =?utf-8?B?N3RqMGFUQXd2MGY5cXVXTDZScnlIdFMyVHp0b0E5QzJPemdva1FqbTF2c1Bm?= =?utf-8?B?a1VnU0IrVGpqS25IUk5VVThLMHdud09odFpWSWQwSDlJRzBjank5czh6MDZ6?= =?utf-8?B?bnJ2OHVVb1dvZE1XeSticXJhYlRJV1dtbHZEOTRxRW4ycHRNL1lqNHZHbkZE?= =?utf-8?B?YWpaSncyenR0VmpsWVVybHNrV3ZLWTBhQzB2OFhzVXp1WDZ6RmV0eE1PQ3hr?= =?utf-8?B?Q3FrTEpzMktFbHIrRDVUcDF5UGJJK2t2SHkwdVI2YlBOMUpLYUcxQ2I0eE5j?= =?utf-8?B?U09SdkMvQVZlWURsNFpsWGUyRlI2cmU4aWdhQzAwNEF6V3lQNFlIdFZ0eWZt?= =?utf-8?B?VHhOU0RiS2l6eWpyc29nQytrYlVJcXI4elpUS0xyTS9aWCt3UDJmUmNyZElt?= =?utf-8?B?RUFxdWhKanIreVpGMEd5MEdPeW1xQTdSSk1SQlphczd4cldwZnlJMHR0ZU5r?= =?utf-8?B?b3cvZmJ2ZnByRjQ2cmNubU1QNkJORmhMbHdoYUlmZjEzUnpPNTZ6SXpvMFYx?= =?utf-8?B?cWZYbkF5MktSbVBzTW9mTURRWHVXZWljNngxeGpWTWdQckRHeGZTU0hFUEQ2?= =?utf-8?B?OXZnSDdvNFM4VU4yZFJmekJFT214TE4xUGMycTVVSDZ2a0c2d1lwUGhPMG1n?= =?utf-8?B?YUYxK3daZy9KdGcyMzVLNEx4dFRaSjduUzlncm5EaHJDZG51MmxKdlBBYmxl?= =?utf-8?B?OHRjNEVCa0JQd251VTR2YTVRbmQwcFJIcVE3N05YOXl3MWcwYzNVamk5ZzFh?= =?utf-8?B?SVgwallnaHNUSEM2djJlNlBvZERtcTkvQjVhelljdGFwV2Mrb3UxbkN5RWpX?= =?utf-8?B?V3o4Y3JPOGRDZDVhc3p0YXJiOS9tSTUxcmR1eGo0MDNZTlBJTU1iRGFaV2RS?= =?utf-8?B?OE5KN3hOYk1mQmdWNHBtNUcyRlBqcUpPU2RvRi82dzRBbmM4UldZekZSYkxh?= =?utf-8?B?ZWx1dy9tWGNaL2pHNFNlRkZSVjVNSlVZU042VkJvRkp6WENMZ0MrVC9TaDgv?= =?utf-8?B?dTQwYWtxN3NGNWc3Zzh6eTJVZllsQUp1aHgvNDEwTk9zTXREVFB2VFZ0NENa?= =?utf-8?B?eW9NRmJiMzhpYVI0cmphU0ZXQ3UyZ2ZVZ0JmS3dZRnFNYXRMelJpdVo3dXhG?= =?utf-8?Q?QiErvPZVR9I+4Hp+mchrX6JjUixZflK37n?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3420.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fb8dc35-15c7-41d9-ad31-08d8a1ccaf5c X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Dec 2020 14:12:55.8922 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tA3shO5W5MvgNXMrvv4C8UoNOpmZobd8WRiZMhBP3/XOPmWsmVotmyUWBIiBMgQ0+SgNI3mYKGwYwgzHhjIvwaA5guH/MWNCUNvGgJYP9qU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4722 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201216_091259_071305_A9CF3E9D X-CRM114-Status: GOOD ( 23.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, sre@kernel.org, Ludovic.Desroches@microchip.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16.12.2020 15:45, Alexandre Belloni wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 16/12/2020 14:57:33+0200, Claudiu Beznea wrote: >> Add support for SAMA7G5 by adding proper struct reg_config structure >> and since SAMA7G5 is not currently on LPDDR setups the commit also >> avoid the mapping of DDR controller. >> > > Honestly, I wouldn't leave the LPDDR part out because there is no > guarantee anyone will think about it when they have a design with LPDDR > and as a consequence, their device will behave properly but will be > very short lived. The idea wasn't to leave it out. It has to be handled differently on SAMA7G5 as it embeds a different DDR controller and at the moment we have no setup with LPDDR. Thank you, Claudiu > >> Signed-off-by: Claudiu Beznea >> --- >> drivers/power/reset/at91-sama5d2_shdwc.c | 72 ++++++++++++++++++++++++-------- >> 1 file changed, 54 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/power/reset/at91-sama5d2_shdwc.c b/drivers/power/reset/at91-sama5d2_shdwc.c >> index 3996167f676f..a3342c8c3728 100644 >> --- a/drivers/power/reset/at91-sama5d2_shdwc.c >> +++ b/drivers/power/reset/at91-sama5d2_shdwc.c >> @@ -78,9 +78,15 @@ struct pmc_reg_config { >> u8 mckr; >> }; >> >> +struct ddrc_reg_config { >> + u32 type_offset; >> + u32 type_mask; >> +}; >> + >> struct reg_config { >> struct shdwc_reg_config shdwc; >> struct pmc_reg_config pmc; >> + struct ddrc_reg_config ddrc; >> }; >> >> struct shdwc { >> @@ -262,6 +268,10 @@ static const struct reg_config sama5d2_reg_config = { >> .pmc = { >> .mckr = 0x30, >> }, >> + .ddrc = { >> + .type_offset = AT91_DDRSDRC_MDR, >> + .type_mask = AT91_DDRSDRC_MD >> + }, >> }; >> >> static const struct reg_config sam9x60_reg_config = { >> @@ -275,6 +285,23 @@ static const struct reg_config sam9x60_reg_config = { >> .pmc = { >> .mckr = 0x28, >> }, >> + .ddrc = { >> + .type_offset = AT91_DDRSDRC_MDR, >> + .type_mask = AT91_DDRSDRC_MD >> + }, >> +}; >> + >> +static const struct reg_config sama7g5_reg_config = { >> + .shdwc = { >> + .wkup_pin_input = 0, >> + .mr_rtcwk_shift = 17, >> + .mr_rttwk_shift = 16, >> + .sr_rtcwk_shift = 5, >> + .sr_rttwk_shift = 4, >> + }, >> + .pmc = { >> + .mckr = 0x28, >> + }, >> }; >> >> static const struct of_device_id at91_shdwc_of_match[] = { >> @@ -285,6 +312,10 @@ static const struct of_device_id at91_shdwc_of_match[] = { >> { >> .compatible = "microchip,sam9x60-shdwc", >> .data = &sam9x60_reg_config, >> + }, >> + { >> + .compatible = "microchip,sama7g5-shdwc", >> + .data = &sama7g5_reg_config, >> }, { >> /*sentinel*/ >> } >> @@ -294,6 +325,7 @@ MODULE_DEVICE_TABLE(of, at91_shdwc_of_match); >> static const struct of_device_id at91_pmc_ids[] = { >> { .compatible = "atmel,sama5d2-pmc" }, >> { .compatible = "microchip,sam9x60-pmc" }, >> + { .compatible = "microchip,sama7g5-pmc" }, >> { /* Sentinel. */ } >> }; >> >> @@ -355,30 +387,34 @@ static int __init at91_shdwc_probe(struct platform_device *pdev) >> goto clk_disable; >> } >> >> - np = of_find_compatible_node(NULL, NULL, "atmel,sama5d3-ddramc"); >> - if (!np) { >> - ret = -ENODEV; >> - goto unmap; >> - } >> + if (at91_shdwc->rcfg->ddrc.type_mask) { >> + np = of_find_compatible_node(NULL, NULL, >> + "atmel,sama5d3-ddramc"); >> + if (!np) { >> + ret = -ENODEV; >> + goto unmap; >> + } >> >> - at91_shdwc->mpddrc_base = of_iomap(np, 0); >> - of_node_put(np); >> + at91_shdwc->mpddrc_base = of_iomap(np, 0); >> + of_node_put(np); >> >> - if (!at91_shdwc->mpddrc_base) { >> - ret = -ENOMEM; >> - goto unmap; >> + if (!at91_shdwc->mpddrc_base) { >> + ret = -ENOMEM; >> + goto unmap; >> + } >> + >> + ddr_type = readl(at91_shdwc->mpddrc_base + >> + at91_shdwc->rcfg->ddrc.type_offset) & >> + at91_shdwc->rcfg->ddrc.type_mask; >> + if (ddr_type != AT91_DDRSDRC_MD_LPDDR2 && >> + ddr_type != AT91_DDRSDRC_MD_LPDDR3) { >> + iounmap(at91_shdwc->mpddrc_base); >> + at91_shdwc->mpddrc_base = NULL; >> + } >> } >> >> pm_power_off = at91_poweroff; >> >> - ddr_type = readl(at91_shdwc->mpddrc_base + AT91_DDRSDRC_MDR) & >> - AT91_DDRSDRC_MD; >> - if (ddr_type != AT91_DDRSDRC_MD_LPDDR2 && >> - ddr_type != AT91_DDRSDRC_MD_LPDDR3) { >> - iounmap(at91_shdwc->mpddrc_base); >> - at91_shdwc->mpddrc_base = NULL; >> - } >> - >> return 0; >> >> unmap: >> -- >> 2.7.4 >> > > -- > Alexandre Belloni, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel