From: Hanjun Guo <guohanjun@huawei.com>
To: John Garry <john.garry@huawei.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Pankaj Bansal <pankaj.bansal@nxp.com>,
"Erik Schmauss" <erik.schmauss@intel.com>
Cc: linux-acpi@vger.kernel.org, linuxarm@huawei.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 1/2] ACPICA/IORT: Correct the comment for id_count
Date: Tue, 24 Dec 2019 09:10:33 +0800 [thread overview]
Message-ID: <02a5dc75-d1f1-9df5-3ce2-482fbf86075b@huawei.com> (raw)
In-Reply-To: <efd1d3fd-0e7c-64af-f226-5f263e48d88c@huawei.com>
On 2019/12/23 18:35, John Garry wrote:
> On 23/12/2019 09:23, Hanjun Guo wrote:
>> In IORT spec
>> (http://infocenter.arm.com/help/topic/com.arm.doc.den0049d/DEN0049D_IO_Remapping_Table.pdf),
>> id_num means Number of IDs minus one, update the comment.
>>
>> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
>> ---
>>
>> This patch just for comments, needs to be upstream in ACPICA first.
>>
>> include/acpi/actbl2.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/acpi/actbl2.h b/include/acpi/actbl2.h
>> index e45ced2..382642f 100644
>> --- a/include/acpi/actbl2.h
>> +++ b/include/acpi/actbl2.h
>> @@ -104,7 +104,7 @@ enum acpi_iort_node_type {
>> struct acpi_iort_id_mapping {
>> u32 input_base; /* Lowest value in input range */
>> - u32 id_count; /* Number of IDs */
>> + u32 id_count; /* Number of IDs in the range minus one */
>
> The IORT spec also uses the term "Length" in the examples...
More confusing...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-12-24 1:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 9:23 [RFC PATCH 1/2] ACPICA/IORT: Correct the comment for id_count Hanjun Guo
2019-12-23 9:23 ` [RFC PATCH 2/2] ACPI/IORT: Workaround for IORT ID count "minus one" issue Hanjun Guo
2019-12-23 12:17 ` Pankaj Bansal
2019-12-24 1:08 ` Hanjun Guo
2020-01-02 10:20 ` Shameerali Kolothum Thodi
2020-01-03 10:14 ` Hanjun Guo
2019-12-23 10:35 ` [RFC PATCH 1/2] ACPICA/IORT: Correct the comment for id_count John Garry
2019-12-24 1:10 ` Hanjun Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a5dc75-d1f1-9df5-3ce2-482fbf86075b@huawei.com \
--to=guohanjun@huawei.com \
--cc=erik.schmauss@intel.com \
--cc=john.garry@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=pankaj.bansal@nxp.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).