From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 5/6] drivers: soc: exynos-pmu: Add support for Exynos7
Date: Sun, 30 Nov 2014 08:35:26 +0900 [thread overview]
Message-ID: <02b001d00c2d$27410aa0$75c31fe0$@kernel.org> (raw)
In-Reply-To: <1417270508-11174-6-git-send-email-amit.daniel@samsung.com>
Amit Daniel Kachhap wrote:
>
> Add PMU settings for exynos7. This is required for future suspend-to-ram,
> cpuidle and power domain support.
>
> Note: In this patch some static declarations lines are over 80
> characters per line for easy redability.
>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Eunseok Choi <es10.choi@samsung.com>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> ---
> drivers/soc/samsung/exynos-pmu.c | 427 ++++++++++++++++++++++++++-
> include/linux/soc/samsung/exynos-regs-pmu.h | 273 +++++++++++++++++
> 2 files changed, 699 insertions(+), 1 deletion(-)
>
I'm not sure all of the definitions in exynos-regs-pmu are required?...too many,
and I couldn't check the addresses are correct ;)
And how about splitting to each SoC specific file in drivers/soc/samsung/ ?
For example, exynos-pmu.c and exynos7-pmu.c like cpufreq...? Just considering.
- Kukjin
next prev parent reply other threads:[~2014-11-29 23:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 14:15 [PATCH v5 0/6] exynos: Move pmu driver to driver/soc folder and add exynos7 support Amit Daniel Kachhap
2014-11-29 14:15 ` [PATCH v5 1/6] ARM: EXYNOS: Move pmu specific headers under "linux/soc/samsung" Amit Daniel Kachhap
2014-11-29 14:15 ` [PATCH v5 2/6] drivers: soc: Add support for Exynos PMU driver Amit Daniel Kachhap
2014-11-29 23:24 ` Kukjin Kim
2014-12-01 4:23 ` amit daniel kachhap
2014-11-29 14:15 ` [PATCH v5 3/6] driver: soc: exynos-pmu: Add an API to be called after wakeup Amit Daniel Kachhap
2014-11-29 23:26 ` Kukjin Kim
2014-12-01 4:24 ` amit daniel kachhap
2014-11-29 14:15 ` [PATCH v5 4/6] driver: soc: exynos-pmu: Add a new structure to allow u32 conf data Amit Daniel Kachhap
2014-11-29 14:15 ` [PATCH v5 5/6] drivers: soc: exynos-pmu: Add support for Exynos7 Amit Daniel Kachhap
2014-11-29 23:35 ` Kukjin Kim [this message]
2014-12-01 4:29 ` amit daniel kachhap
2014-12-01 7:13 ` Pankaj Dubey
2014-11-29 14:15 ` [PATCH v5 6/6] arm: exynos: Select SOC_SAMSUNG config option Amit Daniel Kachhap
2014-11-30 11:49 ` [PATCH v5 0/6] exynos: Move pmu driver to driver/soc folder and add exynos7 support Arnd Bergmann
2014-12-01 4:30 ` Chanwoo Choi
2014-12-01 4:33 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='02b001d00c2d$27410aa0$75c31fe0$@kernel.org' \
--to=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).