linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: 손신 <shin.son@samsung.com>
To: "'Krzysztof Kozlowski'" <krzk@kernel.org>,
	"'Sylwester Nawrocki'" <s.nawrocki@samsung.com>,
	"'Chanwoo Choi'" <cw00.choi@samsung.com>,
	"'Alim Akhtar'" <alim.akhtar@samsung.com>,
	"'Michael Turquette'" <mturquette@baylibre.com>,
	"'Stephen Boyd'" <sboyd@kernel.org>,
	"'Rob Herring'" <robh@kernel.org>,
	"'Conor Dooley'" <conor+dt@kernel.org>,
	"'Sunyeal Hong'" <sunyeal.hong@samsung.com>
Cc: <linux-samsung-soc@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 2/3] clk: samsung: exynosautov920: add cpucl0 clock support
Date: Mon, 28 Apr 2025 17:26:46 +0900	[thread overview]
Message-ID: <02b401dbb817$47c67a70$d7536f50$@samsung.com> (raw)
In-Reply-To: <cdbc8c9b-ecfb-4969-997c-52e873a3abf0@kernel.org>

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzk@kernel.org]
> Sent: Monday, April 28, 2025 4:23 AM
> To: Shin Son <shin.son@samsung.com>; Sylwester Nawrocki
> <s.nawrocki@samsung.com>; Chanwoo Choi <cw00.choi@samsung.com>; Alim
> Akhtar <alim.akhtar@samsung.com>; Michael Turquette
> <mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; Rob Herring
> <robh@kernel.org>; Conor Dooley <conor+dt@kernel.org>; Sunyeal Hong
> <sunyeal.hong@samsung.com>
> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v2 2/3] clk: samsung: exynosautov920: add cpucl0 clock
> support
> 
> On 23/04/2025 06:41, Shin Son wrote:
> > Register compatible and cmu_info data to support clock CPUCL0(CPU
> > Cluster 0), this provides clock for CPUCL0_SWTICH/DBG/CLUSTER.
> > These clocks are required early during boot for the CPUs, so they are
> > declared using CLK_OF_DECLARE instead of being registered through a
> platform driver.
> >
> > Signed-off-by: Shin Son <shin.son@samsung.com>
> 
> Applied, but remember to use proper wrapping and run checkpatch.
> 
> [Checkpatch]
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit
> description?)
> 
> 
> Best regards,
> Krzysztof

Hello, Krzysztof Kozlowski.

Ack, thanks for your feedback. 
I will make sure to thoroughly review my patches next time.

Best regards,
Shin Son



  reply	other threads:[~2025-04-28  8:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20250423044159epcas2p2a064b6cd52806f765f830240adaf69a5@epcas2p2.samsung.com>
2025-04-23  4:41 ` [PATCH v2 0/3] add CPUCL0 clock support for exynosauto v920 SoC Shin Son
     [not found]   ` <CGME20250423044159epcas2p26a4d07552b5646c7e076f3989d8ea354@epcas2p2.samsung.com>
2025-04-23  4:41     ` [PATCH v2 1/3] dt-bindings: clock: exynosautov920: add cpucl0 clock definitions Shin Son
2025-04-27 19:25       ` (subset) " Krzysztof Kozlowski
     [not found]   ` <CGME20250423044159epcas2p3476aede31ffc8de8a9169584ec8a3d78@epcas2p3.samsung.com>
2025-04-23  4:41     ` [PATCH v2 2/3] clk: samsung: exynosautov920: add cpucl0 clock support Shin Son
2025-04-27 19:23       ` Krzysztof Kozlowski
2025-04-28  8:26         ` 손신 [this message]
2025-04-27 19:25       ` (subset) " Krzysztof Kozlowski
     [not found]   ` <CGME20250423044159epcas2p4a2e844c6ab502d7d5e6e6c18ecc7ee97@epcas2p4.samsung.com>
2025-04-23  4:41     ` [PATCH v2 3/3] arm64: dts: exynosautov920: add cpucl0 clock DT nodes Shin Son
2025-04-27 19:25       ` (subset) " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='02b401dbb817$47c67a70$d7536f50$@samsung.com' \
    --to=shin.son@samsung.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=sunyeal.hong@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).