From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C2E7C433F5 for ; Mon, 9 May 2022 10:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j/tMh8HqUAdH58r/HTRVmvFCxjJ+/+P0iIasLM5Jt6A=; b=xwN/nqmocml/Mj 7yWdUtynQlgDn95yV4u/NRWOa53To2mxR89QrPsaTA8TFkC+w4f24LjrvCPUGw9cUZdU7t1pcobKr JOmZDTTfxkrokHoOlo736FXasWiSo+y69v+cH3qtosGPYFyK4j5bemv7SPpEMDWt3urECkxYa/+rq 3SKbl86dA0kJXk4cBRKQdyZ06sF533P9PB66J8VykbmzxeDvv5gGc9SzLhXQ/IWznPhmjaJ2B47al idlyf9KG2cnju7exJzvl8wqXbmeGqRZ91xEeMqa7YcB4cYD931hnMl4uyRAd6ORt49qzTV5EBQS5N Vg6buC2Dhuka6trZ+4BQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1no0zo-00DtQd-QF; Mon, 09 May 2022 10:52:08 +0000 Received: from mout.kundenserver.de ([212.227.126.130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1no0zk-00DtNU-PI; Mon, 09 May 2022 10:52:06 +0000 Received: from [192.168.1.107] ([37.4.249.94]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.167]) with ESMTPSA (Nemesis) id 1N3sye-1nwZfH1eoi-00zmO3; Mon, 09 May 2022 12:51:55 +0200 Message-ID: <02be1caf-1f17-7c81-4167-ade690cb6e41@i2se.com> Date: Mon, 9 May 2022 12:51:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 2/3] staging: vchiq_arm: get rid of global device structure Content-Language: en-US To: Adrien Thierry Cc: Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220502183045.206519-1-athierry@redhat.com> <20220502183045.206519-3-athierry@redhat.com> <8483a250-da97-1875-4ea3-598f46ae96ce@i2se.com> From: Stefan Wahren In-Reply-To: X-Provags-ID: V03:K1:cQEfP+WKAagTTaWNIYaA0g3+6RiwmN+CXbxpj5WFv4ukO5e8j/8 QBg9Sxtl08kbLIDV0Wx4CbYFlb/XKvLmUYhg7Rvm8hnGE9MCOja9dMGYxlAB8N9EveBEgAO njy/wlFPalpOIvDf58BpdqjCFSwMmqxD173W69Gqm5XwZllNYdShSxFvR7QkLl5qV0tcxxV JOlgGBVaNJs+TD6qLkiDQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:gps63oi8aLU=:BsZvN1PVCYlPgjPdjjM602 I5eoAMluwhN/WTIz1ZTaf82mdnz3Cje/dp0hF4OyeWUZuTgJxlAlHTAWTIGu6LM1SM79IcUS6 zFNLvVQFfWGvyJ4ZDAUiOT3OugiDDj7LQpdLOQRu3n7v9eB0HRdTalPWa8FS7fZF0I91lla3N RQoGxuvoaDRLwAx8z/UGuShLZU5eYf5vcCBPC7cjd8/LaWtAefgH2OdVYUbiu1b285VlegiGk O3X2RUgBRl14xZDR0mZ/pwwbxxQmPHRMy70wkiTeYsDnSRaYbDATjdIC1Zu0fd8GA1c73kdyQ TNh8FUcNgas36DTqbC9Ar5/+gVhIJW0aeWn5Fk/UWQ435MYpPP/kdk1mc4U5N0JCPM9NJDU6E R3i7t8QohuWu9nWq57QqTS1oTw3X8fbpmjagxuh0G1K5n3UKu0TMO1mnom4GaiVf+FFAbeRgH vZ7wj7S8CRdVgJ3GkDmclGyGerM9ZkoFml1TynrInnuGZ92OxMgAbV28aCuCh1sRjb3W6UqYA we6VQZdsSBapIcIaMXGDwssawUoxyQRAvQpqIzhdnKXD8srdy0rnAZ6qD9DpX/tLblFX3sdOB iRvpusrIg150lp1yRKaOjXGEcNOkw7eTJNj5K0aJICnJciEhMdUajo8xVeVWIN37KZtf6c4Y+ eqJtPTsZHeTa7CbMjGy0TTJQBEwIHPBs7TcejBCKpBOCRjps5uD7eS3QVxRWXmC2VAJAI2rMh 4CRIovzFmhTSVJiw X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220509_035205_168310_47C29FFF X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Adrien, Am 05.05.22 um 20:11 schrieb Adrien Thierry: > Hi Stefan, > > Thanks for your feedback. > >> i understand the motivation, but could you please explain more in detail >> why you decided to add vchiq_instance instead of device reference? I >> think vchiq_instance is a more internal structure which should be >> avoided in kernel consumers like bcm2835-audio or mmal. > I used the vchiq_instance instead of the device reference because in order > to get rid of the vchiq_states array (patch 3/3 [1]), I needed another way > to access the vchiq_state in the 'handle_to_service' function. So I passed > the vchiq_instance to it (I could also have passed the state directly > instead of the instance), and this propagated in the caller chain all the > way up to 'vchiq_bulk_transmit' and friends which are used in the > bcm2835-audio consumer. Okay, in this case please add this explanation to the commit message. Best regards > Please let me know if you see a better way of > doing this :) > > Thanks, > > Adrien > > [1] https://lore.kernel.org/all/20220502183045.206519-4-athierry@redhat.com/ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel