From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 065ADC433EF for ; Tue, 19 Jul 2022 00:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject:MIME-Version: Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CPHEuHZBl+TlmRHMUfrCeyRFVLKKDBnH2VN4Z4Bv/5o=; b=dRL0QZjlkvglFtG02ITi8GsjXS cyIYKYCOy/KV64CKtn6KZMdK5UqsHlEUe0Nu1lMWp778s+KccEW5l2JDIMecvZZUm6FkrEYKG+KyE QqIZ9ut9F6iEHXT6/0rVkK0anD8qXcq3IARN5aA3PqGbNxuZftv6SsKVv6k1YO+H/EutSW+0ug1Mu unk8xFt7AuXhRtSq/DC6zLV3eF8EI/CnvSMTCxGR1EfNpJX8/cKjsMvn4n/qs2dT+ofFwZy5YYu8K hUWmjCv086PugY+2dGOfgMBU9MXfcXJlXdOYMJ5jD/BpQV50jWpdA00qJJEXEtHSxt35RX/J/a58F WxBkwYvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDatg-0034pc-Np; Tue, 19 Jul 2022 00:15:32 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oDatd-0034nz-Uj for linux-arm-kernel@lists.infradead.org; Tue, 19 Jul 2022 00:15:31 +0000 Received: by mail-pj1-x1034.google.com with SMTP id p9so13208634pjd.3 for ; Mon, 18 Jul 2022 17:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=xJfHvsXmNkSvk88Wwg2zcdtJVnrv0ckiagfsbDmYjeY=; b=J+Y9JFPb2k0NYleDm/soOg2MPrqEWf9ivPg5ZgyruJJ6KpCyF+mq+qe3jUqJlCm7wI Legs2mrArZnttzouiw2exEgWZsw10OdykxSHtn3b8/R2GkIWaRDpD2QLOvU6YUW83Iek p3cpfIvMyP8rvWq8JxCVKuIzgcGSiXc5JSQfy7r+zG1aG31usNJiOZ4uzn9vhS94+mSV lc3pxFgxcmZyEGL2SDKKvy4lfS2Oez5p9am2+MduOEMmBrGL/61EG5JRp7zWj8dBGXAQ cK9YqrnaRqkp57Rb/nKzYOAbMZonJowdRbjbOkgBX2PBrzDQXAiqeIOubLegjyOTGLbs 9pJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=xJfHvsXmNkSvk88Wwg2zcdtJVnrv0ckiagfsbDmYjeY=; b=YWpMmJVoFfmbQ7k2sIuJ1T/T9Cq4pnZF21fcR4l3Aq5RKGkmZWdyQtRaMCJBuNm0mo AlmpSkffSFetT3Kja1R0jY5aBT4dhEbYZteywDV/Swxvoz+8+7vX+DXciNy4j3EZdCFb BW/4lnRtMoVOmaI/uEgfr1UooOWVRg/A3nB5Ra86iLY1kUpafoncnRFhoq0uqVWM/u6B 7XO2kNarGfqL/OYRQL2TG2cG4irJheXLvDMenM8JENA1qjVP5c+jo4P/XYqi32nEhFFx NIGjFwoKknL/hWdY78LP6n1wTZ0nR13Ua7yv2T0hl/aksuBYqb66GQ34DISIFJADOgnF RPMg== X-Gm-Message-State: AJIora9FJ6aL5ZL0/qA4qaf20mZvMvzWf8buTzgBFP+dRCi4edWZYAu8 xqUAXDMeJzmtmI3Z7XzKBPU= X-Google-Smtp-Source: AGRyM1u5epR2hRr5yPIxxo7EbLyPEfZ1aFJ7yL26mCRFUr9qf6siYO8IlqAqHlXIm1Lo2Iyy5J0UGA== X-Received: by 2002:a17:903:32c4:b0:16c:3cab:5918 with SMTP id i4-20020a17090332c400b0016c3cab5918mr29950556plr.16.1658189727063; Mon, 18 Jul 2022 17:15:27 -0700 (PDT) Received: from [192.168.1.3] (ip72-194-116-95.oc.oc.cox.net. [72.194.116.95]) by smtp.gmail.com with ESMTPSA id k21-20020aa79735000000b0050dc7628183sm4743444pfg.93.2022.07.18.17.15.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Jul 2022 17:15:26 -0700 (PDT) Message-ID: <03065912-a9f0-6380-6f19-9db2f43be589@gmail.com> Date: Mon, 18 Jul 2022 17:15:25 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.2 Subject: Re: [PATCH] i2c: brcmstb: Fixed adapter named with optional interrupts Content-Language: en-US To: Wolfram Sang , linux-kernel@vger.kernel.org, Kamal Dasu , Broadcom internal kernel review list , "open list:BROADCOM BRCMSTB I2C DRIVER" , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" References: <20220706172115.224240-1-f.fainelli@gmail.com> From: Florian Fainelli In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220718_171530_059772_86B52940 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/16/2022 5:40 AM, Wolfram Sang wrote: > On Wed, Jul 06, 2022 at 10:21:15AM -0700, Florian Fainelli wrote: >> When the adapter is registered without interrupts, we would be showing >> the following: >> >> # i2cdetect -l >> i2c-3 i2c Broadcom STB : I2C adapter > > What about switching to pdev->name here? That way you also get the base > address for free to differentiate if there are multiple instances on the > SoC? I was not sure if we could change the adapter name reported as one could argue this is now ABI, but if we can, then using dev_name() is probably better. You are the maintainer you so know the rules on what is considered stable ABI and what is not :) -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel