* [PATCH v2] mmc: meson-gx: set max block count
@ 2017-01-28 8:25 Heiner Kallweit
2017-01-30 16:58 ` Kevin Hilman
0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2017-01-28 8:25 UTC (permalink / raw)
To: linux-arm-kernel
So far max_blk_count isn't set what results in a default of value 8
to be used (PAGE_SIZE / block size).
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
v2:
- block length field has 9 bits, so set max_blk_count to 2^9-1 = 511
- in addition set max_req_size because max_blk_count is also limited
by max_req_size / block_size
---
drivers/mmc/host/meson-gx-mmc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 83361f1f..d4d174ed 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -810,6 +810,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
goto free_host;
}
+ mmc->max_blk_count = CMD_CFG_LENGTH_MASK;
+ mmc->max_req_size = mmc->max_blk_count * mmc->max_blk_size;
mmc->ops = &meson_mmc_ops;
mmc_add_host(mmc);
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH v2] mmc: meson-gx: set max block count
2017-01-28 8:25 [PATCH v2] mmc: meson-gx: set max block count Heiner Kallweit
@ 2017-01-30 16:58 ` Kevin Hilman
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Hilman @ 2017-01-30 16:58 UTC (permalink / raw)
To: linux-arm-kernel
Heiner Kallweit <hkallweit1@gmail.com> writes:
> So far max_blk_count isn't set what results in a default of value 8
> to be used (PAGE_SIZE / block size).
This describes the problem...
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> v2:
> - block length field has 9 bits, so set max_blk_count to 2^9-1 = 511
> - in addition set max_req_size because max_blk_count is also limited
> by max_req_size / block_size
... and this part describes the fix, so should also be in the changelog.
with an updated changelog, feel free to add:
Acked-by: Kevin Hilman <khilman@baylibre.com>
Kevin
> ---
> drivers/mmc/host/meson-gx-mmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 83361f1f..d4d174ed 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -810,6 +810,8 @@ static int meson_mmc_probe(struct platform_device *pdev)
> goto free_host;
> }
>
> + mmc->max_blk_count = CMD_CFG_LENGTH_MASK;
> + mmc->max_req_size = mmc->max_blk_count * mmc->max_blk_size;
> mmc->ops = &meson_mmc_ops;
> mmc_add_host(mmc);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-30 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-28 8:25 [PATCH v2] mmc: meson-gx: set max block count Heiner Kallweit
2017-01-30 16:58 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).