[PATCH 0/5] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)

[PATCH 0/5] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)

[Kaustabh Chakraborty]

Exynos7870 has a IP subsystem in its architecture dedicated to display
management. Notably, this block includes the Display Enhancement
Controller (DECON), and the DSI Master (DSIM).

The following series and its sub-series implement all components for a
functioning display pipeline. All vital information which helped shaping
up the patches have been retrieved from Exynos7870 vendor kernel sources
as provided by Samsung.

Testing has been done on all three devices available upstream, i.e.
Samsung Galaxy J7 Prime (samsung-on7xelte), Samsung Galaxy A2 Core
(samsung-a2corelte), and Samsung Galaxy J6 (samsung-j6lte). Regrettably,
I've only been able to test the functionality on video mode, as none of
the devices have panels working in command mode.

This series implements changes in the SoC subsystem, which includes
devicetree additions. It depends on all sub-series listed below:
(Legend: [R]eviewed, [A]ccepted)

exynosdrm-decon            - https://lore.kernel.org/r/20250612-exynosdrm-decon-v2-0-d6c1d21c8057@disroot.org
exynos7870-mipi-phy        - https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
exynos7870-dsim            - https://lore.kernel.org/r/20250612-exynos7870-dsim-v1-0-1a330bca89df@disroot.org
panel-samsung-s6e8aa5x01   - https://lore.kernel.org/r/20250612-panel-synaptics-tddi-v1-0-dfb8a425f76c@disroot.org
panel-synaptics-tddi       - https://lore.kernel.org/r/20250612-panel-samsung-s6e8aa5x01-v1-0-06dcba071ea6@disroot.org

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
Kaustabh Chakraborty (5):
      dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs
      arch: arm64: dts: exynos7870: add DSI support
      arch: arm64: dts: exynos7870-on7xelte: enable display panel support
      arch: arm64: dts: exynos7870-a2corelte: enable display panel support
      arch: arm64: dts: exynos7870-j6lte: enable display panel support

 .../soc/samsung/samsung,exynos-sysreg.yaml         |  6 ++
 .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 41 ++++++++++
 arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts    | 38 +++++++++
 arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 +++++++++
 arch/arm64/boot/dts/exynos/exynos7870.dtsi         | 94 ++++++++++++++++++++++
 5 files changed, 219 insertions(+)
---
base-commit: 0bb71d301869446810a0b13d3da290bd455d7c78
change-id: 20250523-exynos7870-drm-dts-87ccab731ba9

Best regards,
-- 
Kaustabh Chakraborty <kauschluss@disroot.org>

[PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs

[Kaustabh Chakraborty]

Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
added, used for the SoC MIPI PHY's CSIS and DSIM blocks.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml      | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644
--- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
+++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
@@ -52,6 +52,12 @@ properties:
               - samsung,exynosautov9-sysreg
           - const: syscon
         deprecated: true
+      - items:
+          - enum:
+              - samsung,exynos7870-cam-sysreg
+              - samsung,exynos7870-disp-sysreg
+          - const: samsung,exynos7870-sysreg
+          - const: syscon
       - items:
           - enum:
               - samsung,exynos850-cmgp-sysreg

-- 
2.49.0

[PATCH 2/5] arch: arm64: dts: exynos7870: add DSI support

[Kaustabh Chakraborty]

Add devicetree nodes for MIPI PHYs, Samsung's DECON and DSIM blocks, and
DECON IOMMU devicetree nodes. Enables SoC support for hardware to be
able to drive a MIPI DSI display.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 arch/arm64/boot/dts/exynos/exynos7870.dtsi | 94 ++++++++++++++++++++++++++++++
 1 file changed, 94 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870.dtsi b/arch/arm64/boot/dts/exynos/exynos7870.dtsi
index 5cba8c9bb403405b2d9721ab8cf9d61e3d5faf95..fac92081fef389fe6084db3043614f0b276d0f19 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870.dtsi
+++ b/arch/arm64/boot/dts/exynos/exynos7870.dtsi
@@ -178,6 +178,14 @@ pmu_system_controller: system-controller@10480000 {
 				     "samsung,exynos7-pmu", "syscon";
 			reg = <0x10480000 0x10000>;
 
+			mipi_phy: mipi-phy {
+				compatible = "samsung,exynos7870-mipi-video-phy";
+				#phy-cells = <1>;
+
+				samsung,disp-sysreg = <&syscon_disp>;
+				samsung,cam-sysreg = <&syscon_cam>;
+			};
+
 			reboot-mode {
 				compatible = "syscon-reboot-mode";
 				offset = <0x080c>;
@@ -674,6 +682,86 @@ cmu_isp: clock-controller@144d0000 {
 				 <&cmu_mif CLK_GOUT_MIF_CMU_ISP_VRA>;
 		};
 
+		syscon_cam: syscon@144f1040 {
+			compatible = "samsung,exynos7870-cam-sysreg",
+				     "samsung,exynos7870-sysreg", "syscon";
+			reg = <0x144f1040 0x04>;
+		};
+
+		dsi: dsi@14800000 {
+			compatible = "samsung,exynos7870-mipi-dsi";
+			reg = <0x14800000 0x100>;
+			interrupts = <GIC_SPI 207 IRQ_TYPE_LEVEL_HIGH>;
+
+			clock-names = "bus_clk", "sclk_mipi",
+				      "phyclk_mipidphy0_rxclkesc0",
+				      "phyclk_mipidphy0_bitclkdiv8";
+			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_BUS_DISP>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_APB_DISP>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_RXCLKESC0_USER>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_MIPIPHY_TXBYTECLKHS_USER>;
+
+			phy-names = "dsim";
+			phys = <&mipi_phy 1>;
+
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+
+					dsi_to_decon: endpoint {
+						remote-endpoint = <&decon_to_dsi>;
+					};
+				};
+			};
+		};
+
+		decon: decon@14830000 {
+			compatible = "samsung,exynos7870-decon";
+			reg = <0x14830000 0x8000>;
+			interrupt-names = "fifo", "vsync", "lcd_sys";
+			interrupts = <GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>;
+
+			clock-names = "pclk_decon0", "aclk_decon0",
+				      "decon0_eclk", "decon0_vclk";
+			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_PLL>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_ECLK>,
+				 <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_DECON_VCLK>;
+
+			iommus = <&sysmmu_decon>;
+
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+
+				port@0 {
+					reg = <0>;
+					decon_to_dsi: endpoint {
+						remote-endpoint = <&dsi_to_decon>;
+					};
+				};
+			};
+		};
+
+		sysmmu_decon: sysmmu@14860000 {
+			compatible = "samsung,exynos-sysmmu";
+			reg = <0x14860000 0x1000>;
+			interrupts = <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
+			#iommu-cells = <0>;
+
+			clock-names = "sysmmu";
+			clocks = <&cmu_dispaud CLK_GOUT_DISPAUD_MUX_BUS_USER>;
+		};
+
 		pinctrl_dispaud: pinctrl@148c0000 {
 			compatible = "samsung,exynos7870-pinctrl";
 			reg = <0x148c0000 0x1000>;
@@ -691,6 +779,12 @@ cmu_dispaud: clock-controller@148d0000 {
 				 <&cmu_mif CLK_GOUT_MIF_CMU_DISPAUD_DECON_ECLK>,
 				 <&cmu_mif CLK_GOUT_MIF_CMU_DISPAUD_DECON_VCLK>;
 		};
+
+		syscon_disp: syscon@148f100c {
+			compatible = "samsung,exynos7870-disp-sysreg",
+				     "samsung,exynos7870-sysreg", "syscon";
+			reg = <0x148f100c 0x04>;
+		};
 	};
 
 	timer {

-- 
2.49.0

[PATCH 3/5] arch: arm64: dts: exynos7870-on7xelte: enable display panel support

[Kaustabh Chakraborty]

Enable DECON and DSI nodes, and add the compatible display panel and
appropriate panel timings for this device. Also, disable the
simple-framebuffer node in favor of the panel.

This device has a 1080x1920 Synaptics TD4300 display panel.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 ++++++++++++++++++++++
 1 file changed, 40 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
index eb97dcc415423f405d7df9b9869b2db3432fb483..86a7fc2554a137752862c37d27cf9813b3ac5514 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
@@ -40,6 +40,8 @@ framebuffer@67000000 {
 			height = <1920>;
 			stride = <(1080 * 4)>;
 			format = "a8r8g8b8";
+
+			status = "disabled";
 		};
 	};
 
@@ -122,6 +124,44 @@ vibrator {
 	};
 };
 
+&decon {
+	status = "okay";
+};
+
+&dsi {
+	status = "okay";
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	samsung,burst-clock-frequency = <1001000000>;
+	samsung,esc-clock-frequency = <16000000>;
+	samsung,pll-clock-frequency = <26000000>;
+
+	panel@0 {
+		compatible = "syna,td4300-panel";
+		reg = <0>;
+
+		backlight-gpios = <&gpd3 5 GPIO_ACTIVE_LOW>;
+
+		width-mm = <68>;
+		height-mm = <121>;
+
+		panel-timing {
+			clock-frequency = <144389520>;
+
+			hactive = <1080>;
+			hsync-len = <4>;
+			hfront-porch = <120>;
+			hback-porch = <32>;
+
+			vactive = <1920>;
+			vsync-len = <2>;
+			vfront-porch = <21>;
+			vback-porch = <4>;
+		};
+	};
+};
+
 &gpu {
 	status = "okay";
 };

-- 
2.49.0

[PATCH 4/5] arch: arm64: dts: exynos7870-a2corelte: enable display panel support

[Kaustabh Chakraborty]

Enable DECON and DSI nodes, and add the compatible display panel and
appropriate panel timings for this device. Also, disable the
simple-framebuffer node in favor of the panel.

This device has a 540x960 Synaptics TD4101 display panel.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 41 ++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
index eb7b48593187409ce6653b7d857b63f6946aa4f7..d7104d42240d408f07d4d94750307e51d34b477c 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
@@ -40,6 +40,8 @@ framebuffer@67000000 {
 			height = <960>;
 			stride = <(540 * 4)>;
 			format = "a8r8g8b8";
+
+			status = "disabled";
 		};
 	};
 
@@ -124,6 +126,45 @@ vibrator {
 	};
 };
 
+&decon {
+	status = "okay";
+};
+
+&dsi {
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	samsung,burst-clock-frequency = <836000000>;
+	samsung,esc-clock-frequency = <16000000>;
+	samsung,pll-clock-frequency = <26000000>;
+
+	status = "okay";
+
+	panel@0 {
+		compatible = "syna,td4101-panel";
+		reg = <0>;
+
+		backlight-gpios = <&gpd3 7 GPIO_ACTIVE_LOW>;
+
+		width-mm = <62>;
+		height-mm = <110>;
+
+		panel-timing {
+			clock-frequency = <69336720>;
+
+			hactive = <540>;
+			hsync-len = <4>;
+			hfront-porch = <364>;
+			hback-porch = <40>;
+
+			vactive = <960>;
+			vsync-len = <2>;
+			vfront-porch = <244>;
+			vback-porch = <13>;
+		};
+	};
+};
+
 &gpu {
 	status = "okay";
 };

-- 
2.49.0

[PATCH 5/5] arch: arm64: dts: exynos7870-j6lte: enable display panel support

[Kaustabh Chakraborty]

Enable DECON and DSI nodes, and add the compatible display panel and
appropriate panel timings for this device. Also, disable the
simple-framebuffer node in favor of the panel.

This device has a 720x1480 AMOLED Samsung S6E8AA5X01 display panel.

Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
---
 arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts | 38 +++++++++++++++++++++++++
 1 file changed, 38 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts b/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
index 61eec1aff32ef397c69ee3f0cba8050755f74fc6..ad0170d52a7773d5f5e59b4dc0e4a35d9111c43d 100644
--- a/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
+++ b/arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts
@@ -40,6 +40,8 @@ framebuffer@67000000 {
 			height = <1480>;
 			stride = <(720 * 4)>;
 			format = "a8r8g8b8";
+
+			status = "disabled";
 		};
 	};
 
@@ -133,6 +135,42 @@ vibrator {
 	};
 };
 
+&decon {
+	status = "okay";
+};
+
+&dsi {
+	status = "okay";
+	#address-cells = <1>;
+	#size-cells = <0>;
+
+	samsung,burst-clock-frequency = <500000000>;
+	samsung,esc-clock-frequency = <16000000>;
+	samsung,pll-clock-frequency = <26000000>;
+
+	panel@0 {
+		compatible = "samsung,s6e8aa5x01";
+		reg = <0>;
+
+		width-mm = <62>;
+		height-mm = <128>;
+
+		panel-timing {
+			clock-frequency = <73094400>;
+
+			hactive = <720>;
+			hsync-len = <2>;
+			hfront-porch = <62>;
+			hback-porch = <26>;
+
+			vactive = <1480>;
+			vsync-len = <2>;
+			vfront-porch = <12>;
+			vback-porch = <10>;
+		};
+	};
+};
+
 &gpu {
 	status = "okay";
 };

-- 
2.49.0

Re: [PATCH 0/5] Support for Exynos7870's display stack (DECON, MIPIPHY, DSIM, etc.)

[Rob Herring (Arm)]

On Thu, 12 Jun 2025 20:53:36 +0530, Kaustabh Chakraborty wrote:
> Exynos7870 has a IP subsystem in its architecture dedicated to display
> management. Notably, this block includes the Display Enhancement
> Controller (DECON), and the DSI Master (DSIM).
> 
> The following series and its sub-series implement all components for a
> functioning display pipeline. All vital information which helped shaping
> up the patches have been retrieved from Exynos7870 vendor kernel sources
> as provided by Samsung.
> 
> Testing has been done on all three devices available upstream, i.e.
> Samsung Galaxy J7 Prime (samsung-on7xelte), Samsung Galaxy A2 Core
> (samsung-a2corelte), and Samsung Galaxy J6 (samsung-j6lte). Regrettably,
> I've only been able to test the functionality on video mode, as none of
> the devices have panels working in command mode.
> 
> This series implements changes in the SoC subsystem, which includes
> devicetree additions. It depends on all sub-series listed below:
> (Legend: [R]eviewed, [A]ccepted)
> 
> exynosdrm-decon            - https://lore.kernel.org/r/20250612-exynosdrm-decon-v2-0-d6c1d21c8057@disroot.org
> exynos7870-mipi-phy        - https://lore.kernel.org/r/20250612-exynos7870-mipi-phy-v1-0-3fff0b62d9d3@disroot.org
> exynos7870-dsim            - https://lore.kernel.org/r/20250612-exynos7870-dsim-v1-0-1a330bca89df@disroot.org
> panel-samsung-s6e8aa5x01   - https://lore.kernel.org/r/20250612-panel-synaptics-tddi-v1-0-dfb8a425f76c@disroot.org
> panel-synaptics-tddi       - https://lore.kernel.org/r/20250612-panel-samsung-s6e8aa5x01-v1-0-06dcba071ea6@disroot.org
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
> Kaustabh Chakraborty (5):
>       dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs
>       arch: arm64: dts: exynos7870: add DSI support
>       arch: arm64: dts: exynos7870-on7xelte: enable display panel support
>       arch: arm64: dts: exynos7870-a2corelte: enable display panel support
>       arch: arm64: dts: exynos7870-j6lte: enable display panel support
> 
>  .../soc/samsung/samsung,exynos-sysreg.yaml         |  6 ++
>  .../arm64/boot/dts/exynos/exynos7870-a2corelte.dts | 41 ++++++++++
>  arch/arm64/boot/dts/exynos/exynos7870-j6lte.dts    | 38 +++++++++
>  arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 +++++++++
>  arch/arm64/boot/dts/exynos/exynos7870.dtsi         | 94 ++++++++++++++++++++++
>  5 files changed, 219 insertions(+)
> ---
> base-commit: 0bb71d301869446810a0b13d3da290bd455d7c78
> change-id: 20250523-exynos7870-drm-dts-87ccab731ba9
> 
> Best regards,
> --
> Kaustabh Chakraborty <kauschluss@disroot.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit 0bb71d301869446810a0b13d3da290bd455d7c78

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/exynos/' for 20250612-exynos7870-drm-dts-v1-0-88c0779af6cb@disroot.org:

arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: False schema does not allow {'compatible': ['samsung,exynos7870-mipi-video-phy'], '#phy-cells': 1, 'samsung,disp-sysreg': [[12]], 'samsung,cam-sysreg': [13], 'phandle': 73}
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam-sysreg' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam0-sysreg' is a required property
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam1-sysreg' is a required property
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy:compatible:0: 'samsung,exynos7870-mipi-video-phy' is not one of ['samsung,s5pv210-mipi-video-phy', 'samsung,exynos5420-mipi-video-phy', 'samsung,exynos5433-mipi-video-phy']
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: Unevaluated properties are not allowed ('compatible', 'samsung,cam-sysreg' were unexpected)
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: /soc@0/system-controller@10480000/mipi-phy: failed to match any schema with compatible: ['samsung,exynos7870-mipi-video-phy']
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['syna,td4300-panel']
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: False schema does not allow {'compatible': ['samsung,exynos7870-mipi-video-phy'], '#phy-cells': 1, 'samsung,disp-sysreg': [[12]], 'samsung,cam-sysreg': [13], 'phandle': 73}
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam-sysreg' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam0-sysreg' is a required property
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam1-sysreg' is a required property
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy:compatible:0: 'samsung,exynos7870-mipi-video-phy' is not one of ['samsung,s5pv210-mipi-video-phy', 'samsung,exynos5420-mipi-video-phy', 'samsung,exynos5433-mipi-video-phy']
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: Unevaluated properties are not allowed ('compatible', 'samsung,cam-sysreg' were unexpected)
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: /soc@0/system-controller@10480000/mipi-phy: failed to match any schema with compatible: ['samsung,exynos7870-mipi-video-phy']
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: False schema does not allow {'compatible': ['samsung,exynos7870-mipi-video-phy'], '#phy-cells': 1, 'samsung,disp-sysreg': [[12]], 'samsung,cam-sysreg': [13], 'phandle': 72}
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam-sysreg' does not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam0-sysreg' is a required property
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: 'samsung,cam1-sysreg' is a required property
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy:compatible:0: 'samsung,exynos7870-mipi-video-phy' is not one of ['samsung,s5pv210-mipi-video-phy', 'samsung,exynos5420-mipi-video-phy', 'samsung,exynos5433-mipi-video-phy']
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: system-controller@10480000 (samsung,exynos7870-pmu): mipi-phy: Unevaluated properties are not allowed ('compatible', 'samsung,cam-sysreg' were unexpected)
	from schema $id: http://devicetree.org/schemas/soc/samsung/exynos-pmu.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: /soc@0/system-controller@10480000/mipi-phy: failed to match any schema with compatible: ['samsung,exynos7870-mipi-video-phy']
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['syna,td4101-panel']
arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: /soc@0/dsi@14800000: failed to match any schema with compatible: ['samsung,exynos7870-mipi-dsi']
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: /soc@0/dsi@14800000/panel@0: failed to match any schema with compatible: ['samsung,s6e8aa5x01']
arch/arm64/boot/dts/exynos/exynos7870-j6lte.dtb: decon@14830000 (samsung,exynos7870-decon): 'iommus', 'ports' do not match any of the regexes: '^pinctrl-[0-9]+$'
	from schema $id: http://devicetree.org/schemas/display/samsung/samsung,exynos7-decon.yaml#

Re: [PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs

[Krzysztof Kozlowski]

On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml      | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644
> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
> @@ -52,6 +52,12 @@ properties:
>                - samsung,exynosautov9-sysreg
>            - const: syscon
>          deprecated: true
> +      - items:
> +          - enum:
> +              - samsung,exynos7870-cam-sysreg
> +              - samsung,exynos7870-disp-sysreg
> +          - const: samsung,exynos7870-sysreg


Drop. These are not really compatible or your commit msg is incomplete.
Don't use deprecated syntax and backwards compatible solutions for new
hardware.

Best regards,
Krzysztof

Re: [PATCH 3/5] arch: arm64: dts: exynos7870-on7xelte: enable display panel support

[Krzysztof Kozlowski]

On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
> Enable DECON and DSI nodes, and add the compatible display panel and
> appropriate panel timings for this device. Also, disable the
> simple-framebuffer node in favor of the panel.
> 
> This device has a 1080x1920 Synaptics TD4300 display panel.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 ++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
> index eb97dcc415423f405d7df9b9869b2db3432fb483..86a7fc2554a137752862c37d27cf9813b3ac5514 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
> +++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
> @@ -40,6 +40,8 @@ framebuffer@67000000 {
>  			height = <1920>;
>  			stride = <(1080 * 4)>;
>  			format = "a8r8g8b8";
> +
> +			status = "disabled";

This should be rather removed. What is the idea behind keeping disabled
node?


Best regards,
Krzysztof

Re: [PATCH 2/5] arch: arm64: dts: exynos7870: add DSI support

[Krzysztof Kozlowski]

On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
> Add devicetree nodes for MIPI PHYs, Samsung's DECON and DSIM blocks, and
> DECON IOMMU devicetree nodes. Enables SoC support for hardware to be
> able to drive a MIPI DSI display.
> 
> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
> ---
>  arch/arm64/boot/dts/exynos/exynos7870.dtsi | 94 ++++++++++++++++++++++++++++++
>  1 file changed, 94 insertions(+)

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters

It is never arch.



Best regards,
Krzysztof

Re: [PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs

[Kaustabh Chakraborty]

On 2025-06-18 09:46, Krzysztof Kozlowski wrote:
> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml      | 6 ++++++
>>  1 file changed, 6 insertions(+)
>> 
>> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644
>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>> @@ -52,6 +52,12 @@ properties:
>>                - samsung,exynosautov9-sysreg
>>            - const: syscon
>>          deprecated: true
>> +      - items:
>> +          - enum:
>> +              - samsung,exynos7870-cam-sysreg
>> +              - samsung,exynos7870-disp-sysreg
>> +          - const: samsung,exynos7870-sysreg
> 
> 
> Drop. These are not really compatible or your commit msg is incomplete.
> Don't use deprecated syntax and backwards compatible solutions for new
> hardware.

Are you sure? The deprecated one is actually the item above. From what I
understand, those are generic sysregs and don't mention their functions.

      - items:
          - enum:
              - samsung,exynos5433-sysreg
              - samsung,exynos850-sysreg
              - samsung,exynosautov9-sysreg
          - const: syscon
        deprecated: true

> 
> Best regards,
> Krzysztof

Re: [PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs

[Krzysztof Kozlowski]

On 18/06/2025 16:32, Kaustabh Chakraborty wrote:
> On 2025-06-18 09:46, Krzysztof Kozlowski wrote:
>> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs are
>>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
>>>
>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>> ---
>>>  .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml      | 6 ++++++
>>>  1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>> index d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 100644
>>> --- a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>> +++ b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>> @@ -52,6 +52,12 @@ properties:
>>>                - samsung,exynosautov9-sysreg
>>>            - const: syscon
>>>          deprecated: true
>>> +      - items:
>>> +          - enum:
>>> +              - samsung,exynos7870-cam-sysreg
>>> +              - samsung,exynos7870-disp-sysreg
>>> +          - const: samsung,exynos7870-sysreg
>>
>>
>> Drop. These are not really compatible or your commit msg is incomplete.
>> Don't use deprecated syntax and backwards compatible solutions for new
>> hardware.
> 
> Are you sure? The deprecated one is actually the item above. From what I

Yes. Think why were they added.

> understand, those are generic sysregs and don't mention their functions.

And what is a generic sysreg?

Best regards,
Krzysztof

Re: [PATCH 3/5] arch: arm64: dts: exynos7870-on7xelte: enable display panel support

[Kaustabh Chakraborty]

On 2025-06-18 09:57, Krzysztof Kozlowski wrote:
> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>> Enable DECON and DSI nodes, and add the compatible display panel and
>> appropriate panel timings for this device. Also, disable the
>> simple-framebuffer node in favor of the panel.
>> 
>> This device has a 1080x1920 Synaptics TD4300 display panel.
>> 
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>> ---
>>  arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts | 40 
>> ++++++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts 
>> b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> index 
>> eb97dcc415423f405d7df9b9869b2db3432fb483..86a7fc2554a137752862c37d27cf9813b3ac5514 
>> 100644
>> --- a/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> +++ b/arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
>> @@ -40,6 +40,8 @@ framebuffer@67000000 {
>>  			height = <1920>;
>>  			stride = <(1080 * 4)>;
>>  			format = "a8r8g8b8";
>> +
>> +			status = "disabled";
> 
> This should be rather removed. What is the idea behind keeping disabled
> node?

Ideally should be removed, yes. A disabled property was added so that if
required, it can be enabled downstream simply by a patch which removes 
it.

And I also understand that upstream doesn't care what's happening 
downstream.
To upstream, it is effectively a dead node. So I'll remove it.

> 
> 
> Best regards,
> Krzysztof

Re: [PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs

[Kaustabh Chakraborty]

On 2025-06-18 14:37, Krzysztof Kozlowski wrote:
> On 18/06/2025 16:32, Kaustabh Chakraborty wrote:
>> On 2025-06-18 09:46, Krzysztof Kozlowski wrote:
>>> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>>>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs 
>>>> are
>>>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
>>>> 
>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>>> ---
>>>>  .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml      
>>>> | 6 ++++++
>>>>  1 file changed, 6 insertions(+)
>>>> 
>>>> diff --git 
>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml 
>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>> index 
>>>> d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 
>>>> 100644
>>>> --- 
>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>> +++ 
>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>> @@ -52,6 +52,12 @@ properties:
>>>>                - samsung,exynosautov9-sysreg
>>>>            - const: syscon
>>>>          deprecated: true
>>>> +      - items:
>>>> +          - enum:
>>>> +              - samsung,exynos7870-cam-sysreg
>>>> +              - samsung,exynos7870-disp-sysreg
>>>> +          - const: samsung,exynos7870-sysreg
>>> 
>>> 
>>> Drop. These are not really compatible or your commit msg is 
>>> incomplete.
>>> Don't use deprecated syntax and backwards compatible solutions for 
>>> new
>>> hardware.
>> 
>> Are you sure? The deprecated one is actually the item above. From what 
>> I
> 
> Yes. Think why were they added.
> 
>> understand, those are generic sysregs and don't mention their 
>> functions.
> 
> And what is a generic sysreg?

What I meant is, usually compatibles go like this (in order):

"samsung,exynos<soc>-<function>-sysreg", "samsung,exynos<soc>-sysreg", 
"syscon"

But the deprecated item had its compatibles like this:

"samsung,exynos<soc>-sysreg", "syscon"

That is what I meant by "generic". It doesn't mention <function>.

And my additions adhere to the former. So does [1], [2], and [3]. None 
are
deprecated.

[1] 
https://elixir.bootlin.com/linux/v6.15.2/source/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml#L40
[2] 
https://elixir.bootlin.com/linux/v6.15.2/source/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml#L55
[3] 
https://elixir.bootlin.com/linux/v6.15.2/source/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml#L61

> 
> Best regards,
> Krzysztof

Re: [PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs

[Krzysztof Kozlowski]

On 18/06/2025 16:49, Kaustabh Chakraborty wrote:
> On 2025-06-18 14:37, Krzysztof Kozlowski wrote:
>> On 18/06/2025 16:32, Kaustabh Chakraborty wrote:
>>> On 2025-06-18 09:46, Krzysztof Kozlowski wrote:
>>>> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>>>>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs 
>>>>> are
>>>>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
>>>>>
>>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>>>> ---
>>>>>  .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml      
>>>>> | 6 ++++++
>>>>>  1 file changed, 6 insertions(+)
>>>>>
>>>>> diff --git 
>>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml 
>>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>>> index 
>>>>> d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3 
>>>>> 100644
>>>>> --- 
>>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>>> +++ 
>>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>>> @@ -52,6 +52,12 @@ properties:
>>>>>                - samsung,exynosautov9-sysreg
>>>>>            - const: syscon
>>>>>          deprecated: true
>>>>> +      - items:
>>>>> +          - enum:
>>>>> +              - samsung,exynos7870-cam-sysreg
>>>>> +              - samsung,exynos7870-disp-sysreg
>>>>> +          - const: samsung,exynos7870-sysreg
>>>>
>>>>
>>>> Drop. These are not really compatible or your commit msg is 
>>>> incomplete.
>>>> Don't use deprecated syntax and backwards compatible solutions for 
>>>> new
>>>> hardware.
>>>
>>> Are you sure? The deprecated one is actually the item above. From what 
>>> I
>>
>> Yes. Think why were they added.
>>
>>> understand, those are generic sysregs and don't mention their 
>>> functions.
>>
>> And what is a generic sysreg?
> 
> What I meant is, usually compatibles go like this (in order):

No, they don't. So you checked why they were added?

Best regards,
Krzysztof

Re: [PATCH 1/5] dt-bindings: samsung: exynos-sysreg: add exynos7870 sysregs

[Kaustabh Chakraborty]

On 2025-06-18 15:40, Krzysztof Kozlowski wrote:
> On 18/06/2025 16:49, Kaustabh Chakraborty wrote:
>> On 2025-06-18 14:37, Krzysztof Kozlowski wrote:
>>> On 18/06/2025 16:32, Kaustabh Chakraborty wrote:
>>>> On 2025-06-18 09:46, Krzysztof Kozlowski wrote:
>>>>> On 12/06/2025 17:23, Kaustabh Chakraborty wrote:
>>>>>> Add sysreg compatible strings for the Exynos7870 SoC. Two sysregs
>>>>>> are
>>>>>> added, used for the SoC MIPI PHY's CSIS and DSIM blocks.
>>>>>> 
>>>>>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>>>>>> ---
>>>>>>  .../devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>>>> | 6 ++++++
>>>>>>  1 file changed, 6 insertions(+)
>>>>>> 
>>>>>> diff --git
>>>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>>>> index
>>>>>> d27ed6c9d61ea9db77229eca60b6b9a0abc5d305..174bdb8ee932ff965de6fc17aef004a3cedffeb3
>>>>>> 100644
>>>>>> ---
>>>>>> a/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>>>> +++
>>>>>> b/Documentation/devicetree/bindings/soc/samsung/samsung,exynos-sysreg.yaml
>>>>>> @@ -52,6 +52,12 @@ properties:
>>>>>>                - samsung,exynosautov9-sysreg
>>>>>>            - const: syscon
>>>>>>          deprecated: true
>>>>>> +      - items:
>>>>>> +          - enum:
>>>>>> +              - samsung,exynos7870-cam-sysreg
>>>>>> +              - samsung,exynos7870-disp-sysreg
>>>>>> +          - const: samsung,exynos7870-sysreg
>>>>> 
>>>>> 
>>>>> Drop. These are not really compatible or your commit msg is
>>>>> incomplete.
>>>>> Don't use deprecated syntax and backwards compatible solutions for
>>>>> new
>>>>> hardware.
>>>> 
>>>> Are you sure? The deprecated one is actually the item above. From 
>>>> what
>>>> I
>>> 
>>> Yes. Think why were they added.
>>> 
>>>> understand, those are generic sysregs and don't mention their
>>>> functions.
>>> 
>>> And what is a generic sysreg?
>> 
>> What I meant is, usually compatibles go like this (in order):
> 
> No, they don't. So you checked why they were added?

Checked it, understood. It's meant to be:
"samsung,exynos<soc>-<function>-sysreg", "syscon"

> 
> Best regards,
> Krzysztof