From: m.szyprowski@samsung.com (Marek Szyprowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] Move FIMD register headers to include/video/
Date: Tue, 31 Jul 2012 08:28:13 +0200 [thread overview]
Message-ID: <032201cd6ee5$ad4a0d50$07de27f0$%szyprowski@samsung.com> (raw)
In-Reply-To: <000a01cd6eb6$2113a050$633ae0f0$%han@samsung.com>
Hello,
On Tuesday, July 31, 2012 2:48 AM Jingoo Han wrote:
> On Monday, July 30, 2012 8:16 PM, Leela Krishna Amudala wrote:
> >
> > Hello Jingoo Han,
> >
> > On Mon, Jul 30, 2012 at 2:23 PM, Jingoo Han <jg1.han@samsung.com> wrote:
> > > On Monday, July 30, 2012 5:45 PM, Leela Krishna Amudala wrote:
> > >>
> > >> Moved the contents of regs-fb-v4.h and regs-fb.h from arch side
> > >> to include/video/samsung_fimd.h
> > >>
> > >> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> > >> ---
> > >> arch/arm/plat-samsung/include/plat/regs-fb-v4.h | 159 -------
> > >> arch/arm/plat-samsung/include/plat/regs-fb.h | 403 -----------------
> > >> include/video/samsung_fimd.h | 533 +++++++++++++++++++++++
> > >> 3 files changed, 533 insertions(+), 562 deletions(-)
> > >> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb-v4.h
> > >> delete mode 100644 arch/arm/plat-samsung/include/plat/regs-fb.h
> > >> create mode 100644 include/video/samsung_fimd.h
> > >>
> > >> +*/
> > >> +
> > >> +/*FIMD V8 REG OFFSET */
> > >> +#define FIMD_V8_VIDTCON0 (0x20010)
> > >> +#define FIMD_V8_VIDTCON1 (0x20014)
> > >> +#define FIMD_V8_VIDTCON2 (0x20018)
> > >> +#define FIMD_V8_VIDTCON3 (0x2001C)
> > >> +#define FIMD_V8_VIDCON1 (0x20004)
>
>
> How about using soc_is_exynos5250()?
>
> +#define VIDTCON0 (soc_is_exynos5250() ? \
> + (0x20010) : (0x10))
>
> In this case, the FIMD driver does not need to change.
> Also, one binary is available.
Please don't mix two methods of runtime detection. FIMD driver (s3c-fb) already
has runtime hw detection based on platform device id. Adding such detection for
exynos5 to DRM FIMD driver should not be a big issue too.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2012-07-31 6:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 8:45 [PATCH 0/3] ARM: SAMSUNG: Move FIMD headers to include/video/ Leela Krishna Amudala
2012-07-30 8:45 ` [PATCH 1/3] Move FIMD register " Leela Krishna Amudala
2012-07-30 8:47 ` Leela Krishna Amudala
2012-07-30 8:49 ` Sylwester Nawrocki
2012-07-30 11:05 ` Leela Krishna Amudala
2012-07-30 8:53 ` Jingoo Han
2012-07-30 9:09 ` Sylwester Nawrocki
2012-07-30 11:16 ` Leela Krishna Amudala
2012-07-30 14:32 ` Tomasz Figa
2012-07-31 0:47 ` Jingoo Han
2012-07-31 6:28 ` Marek Szyprowski [this message]
2012-07-31 7:12 ` Leela Krishna Amudala
2012-07-31 8:19 ` Jingoo Han
2012-07-31 8:32 ` Marek Szyprowski
2012-08-01 1:56 ` Kukjin Kim
2012-07-31 6:37 ` Tomasz Figa
2012-07-31 8:09 ` Jingoo Han
2012-08-01 1:50 ` Kukjin Kim
2012-08-01 1:46 ` Kukjin Kim
2012-07-30 8:45 ` [PATCH 2/3] arm: samsung: Include the modified FIMD header file Leela Krishna Amudala
2012-07-30 8:47 ` Leela Krishna Amudala
2012-07-30 8:45 ` [PATCH 3/3] driver: " Leela Krishna Amudala
2012-07-30 8:48 ` Leela Krishna Amudala
2012-07-30 8:46 ` [PATCH 0/3] ARM: SAMSUNG: Move FIMD headers to include/video/ Leela Krishna Amudala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='032201cd6ee5$ad4a0d50$07de27f0$%szyprowski@samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).