From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E57C8C433FE for ; Mon, 28 Nov 2022 07:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Xvi7W6XScU/Vw+LVw1hP7Hw9GnWywNk4Yu4w9kf2in4=; b=yp3JhA5w615uCz BCxqN9mrixfpRLdWjy6H79HFjuKAPgxcrYtPRXPjUXxUU6+QlamaRyg8f7qRQlXo7LIayrtaWvinS WLlb2DTmpholH5pzW62KzaMsLYSyvF2wMGyBnFo0dSAhKREsaI8NL+4oQAmadPZYYfm+YJiJ/ujbn wGxm1K7pCXIH4X9HEbviA0FT/t8RWIxlssubY5eQbAXNku0DWVw0gVdvjWkfRqnnBUz8R+sv11tjQ 0XDZS3KpKMlIhH/oPPoSE2w53MjOp2KZ1Y1xMXlpHoSt2Bux/iv/LHdNKq/uRSGr5LaI7Gjp0j/4S PBpnYSq58g0ArSVBSt3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozYRv-00HELX-SL; Mon, 28 Nov 2022 07:21:08 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozYRs-00HEIM-4Z; Mon, 28 Nov 2022 07:21:05 +0000 X-UUID: 21d5178119c34a3cb748149f48a72c7a-20221128 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=6D1mUzaxP0QwqL+ByQM1WUT+FsSZ6OuGyyFL/63soR4=; b=nRboxZPJ8nq4Z9INZ99KxfYu+K12YwwpmjmlTL+keyQG+5TBTgQr+eLDwpIB8qrwqpwcD5367LTGrohnaNgoIfVREpt5HPKqo3OJELriijSb4Sph4tb/OpC+4BOB1Whme9djG0UH7COX/MbCp2ydmKlgKlk1rja+MOMcbhEmDjE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.14,REQID:41fec7c3-1880-41c6-90e5-e4ac7e4a4563,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:dcaaed0,CLOUDID:c9287c1e-5e1d-4ab5-ab8e-3e04efc02b30,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:11|1,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 21d5178119c34a3cb748149f48a72c7a-20221128 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1024411694; Mon, 28 Nov 2022 00:20:56 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Mon, 28 Nov 2022 15:00:53 +0800 Received: from APC01-SG2-obe.outbound.protection.outlook.com (172.21.101.239) by mtkmbs10n1.mediatek.com (172.21.101.34) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Mon, 28 Nov 2022 15:00:53 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Of4MGdB/1oYGDrgx7CIucNprm47Sf8QCh+bi3jQpL1tKpvdrYXpr8F55ouMCMr/kipZOvDhaT5IflUWfzy8rMnjhGMOvlajhOJ0vZV00XSWrisKB8bLd7EwryE1CbFXqWiooYVjG2jbkT7dyJbccP0FLWjolFy+0y4KOOUrq6rlU6UdXYc7Yw/4TWm20X+SFqbHMIYx3RkxycqZBrD06jYe9dIkCPHRycpsOu+qntGhSC6LTpBRW99BA0TuAWne2BBEPUzXeH9ZFwB0012DZPJwFbMqEgxMcHuxIgynqhZ+i7gLXAtSHQ2nxol76cRiCdl195qaF0uHMmyBrdQrhPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6D1mUzaxP0QwqL+ByQM1WUT+FsSZ6OuGyyFL/63soR4=; b=IXqveTByJ/Gaw0MIztpKzizEoezhKXAF555LcGxf6lx7d6isZm70G9uqZWwDReNNxDL6HIrcE7tNrreMzfF86dZxDDVBxHAi2fe+4xxuPT4CwxHwYysSjiSGyL+x90ythewbk0i2n/QF5WkyrTFnVomYOGgR7leaDxPHYzpFT80Inpm14ec7uOSJa6YVUWyr45v5vUSLpsZXL+wlOlna0FAMwSvjiYT3jnF9m2jDifkWPT3b1n6iWly3lyF88KyDK9tAm6vWFjdrKdq5IFBO/ypjvundhA7Mg3dGKFM6py6/JnGrZaz0cg60RkNy2OXfV1iwHCpnbTIaWxbk6zMnxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6D1mUzaxP0QwqL+ByQM1WUT+FsSZ6OuGyyFL/63soR4=; b=j9vkUdCqwCVHqC6DnqIiIskkVnDZv5T6QwAUk09Lh+sVV89Xm24NYGigjEnODdzN73+/S+bbl6pOQkZoW5dau3+36lU6Of3Co1p+VEO+0cgsDpPUmET739oDcpoXouoXoVII8vEZXx67lblUWgJdfO7fNbR43W9hluR90z5j6OM= Received: from KL1PR03MB5062.apcprd03.prod.outlook.com (2603:1096:820:1a::22) by PUZPR03MB6855.apcprd03.prod.outlook.com (2603:1096:301:e5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Mon, 28 Nov 2022 07:00:51 +0000 Received: from KL1PR03MB5062.apcprd03.prod.outlook.com ([fe80::9585:3a04:b796:b696]) by KL1PR03MB5062.apcprd03.prod.outlook.com ([fe80::9585:3a04:b796:b696%5]) with mapi id 15.20.5857.020; Mon, 28 Nov 2022 07:00:50 +0000 From: =?utf-8?B?Q2h1bmZlbmcgWXVuICjkupHmmKXls7Ap?= To: "vkoul@kernel.org" CC: "llvm@lists.linux.dev" , "linux-mediatek@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "nathan@kernel.org" , "kishon@ti.com" , =?utf-8?B?RWRkaWUgSHVuZyAo5rSq5q2j6ZGrKQ==?= , =?utf-8?B?VGlhbnBpbmcgRmFuZyAo5pa55aSp5bmzKQ==?= , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "linux-phy@lists.infradead.org" , "trix@redhat.com" , "angelogioacchino.delregno@collabora.com" , "ndesaulniers@google.com" Subject: Re: [PATCH v4 2/3] phy: core: add debugfs root Thread-Topic: [PATCH v4 2/3] phy: core: add debugfs root Thread-Index: AQHY9QgpVRJM2vxsIUeK39IN/xwo7q5ObUSAgAWW9oA= Date: Mon, 28 Nov 2022 07:00:50 +0000 Message-ID: <0326f3314c47853876c0a7e3a2cd32c5a4f21427.camel@mediatek.com> References: <20221110132716.12294-1-chunfeng.yun@mediatek.com> <20221110132716.12294-2-chunfeng.yun@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: KL1PR03MB5062:EE_|PUZPR03MB6855:EE_ x-ms-office365-filtering-correlation-id: 1910a596-d14b-4557-a5bb-08dad10e4887 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SvFPiLozxkGuL6/xaNtjcSFXwB3z/ZyDo2CORTUQP9MODxJNa1JQmNXNi+HUR8VdWylDD7oMH3t9VTyz3P3sJAH+1LE8EEhgzC6+SVBaamrhEOYruSO5jUIIZ8eRE5O0u4YhKLbWyaD0M1QKTg/nUY5yQ3TDifKc71Eoyw9BB596R9fHkI8AQQTetP7ic9kKVDzOIK0QsNxByz7pA5Z6iwx8ytC65A0xKq/TuMXhw5/eBCsLJqAU9rIz26Zhc6qeKtzhIkKlHwc1nSVSFxKBvLE65IUKIAgzSm6rvIJ3mUo8OO6CA2PqXKZwTobyVUgF3WwRDg5BVyXh2NwcQJ985G4sTruL8Jwp8SAaZ8H7rczWL6tapFdD3OQ5mQgKQ27W7Z7HL5XpZOoXq81Imp05Bd5rRZeJ8cs7M3OxYJcByF5Ym2q5aC9vp4mNZ5ZSzqgTL/67w1cSx/fZMq8B/U/UyrcKyCVFZ4NkGtb6YgBRG3b2Kn+XcIu+4dgxaUSWN0iaz/RXi5gN9qgVX/11R7mJh+0tVCs3R36FFzwtr39vb9969Ik9QGWxduY8F96TdAB19dGuU3UcS6inao3Gdvq3MzmIyhnMBddceguu02B2O7oufxlpCxJbDJqkGqg9MDJzVA3R3xJa8RI27U7vMO2HMQ5cV/G5LCCFZL/9d6uCWUixHPThFHXbt20qkBSbQ/++PHeAAHaC4zTczYzIx+wHrMm+t+Tuq7gr0aY536Fbag7gGUwI3+l3I+ZmYduyTFYzZrFMcj4xTOgE20phVQFWfA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:KL1PR03MB5062.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(366004)(39860400002)(396003)(376002)(136003)(346002)(451199015)(8936002)(71200400001)(5660300002)(76116006)(91956017)(66446008)(4326008)(66946007)(64756008)(8676002)(66556008)(36756003)(85182001)(6916009)(186003)(66476007)(54906003)(41300700001)(316002)(122000001)(38070700005)(38100700002)(478600001)(6486002)(26005)(86362001)(6512007)(2616005)(53546011)(6506007)(7416002)(2906002)(4001150100001)(99106002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?NXBCS0hBaEZmR0c3aG55a1p6cEJsdzFFeHR5ZGd0TjhQRTFjWnBKaCs1bWV1?= =?utf-8?B?M09RcG1ucm5SUXhkanh1SUxXUXREcFJ4VGRoQWFpM2dGYzZoSjhES0lQeGM0?= =?utf-8?B?V2xnYVZxaWwxVzYvVDM1RFhqcWd5NjIyd2FMdU5BY1hwcjM1L3c1VUNpS1d4?= =?utf-8?B?a01ER2tFYmdOY0JrUk1vSHJNbW9mSG1FNnhzdmdwbHQxVmptOHJXNHYvWmV2?= =?utf-8?B?djNQSDhFR09PWlZhRThqbE52Rk1PWTFRVDdTTjdOdGVQREY2R1BYWE1pS21L?= =?utf-8?B?clR3OHA0SGgwUVNWazlSUlBDU2dZRjdMaThPbUhBMUwraWw3WEpIdzB0Q3V1?= =?utf-8?B?RElidko0T3lhemhoREs1eFh6cWtkWG15ZDl1cFVxM3RIUHZURGdFNE9KbWRn?= =?utf-8?B?cGVhek9FRCtkWnpYOTcvNlE4MnRqbWUrZmY0WUZyWU0rZXM2K2lleTBhR1Mv?= =?utf-8?B?OVVKZkwrMTdOcFJpTm5KQW5kdFRTcFZyU3lob2ZxdmVRVzA5RkxJUTdja3lD?= =?utf-8?B?Mmd5K25xSHo3Y0hoOVN3Zjc4dXpxWUJScTFFUFhmMUlDNy9HMnJkaWhmTE9P?= =?utf-8?B?Ym1odnJJRUtvd0ZhRC91VEdHd2Y0OFBBVXRTaytiZzlPWVRIb2VwZjg4bGdX?= =?utf-8?B?bTAxcldDS0lUK0l2MVFoY2x6NmZWbVJOV3lpVEVkTW5HaEc4UWRGTUdsZW91?= =?utf-8?B?eWh3djhUUXBrbjY4VnhZc3JxUWNHTXhkK2x3Vm9ZMTlsMXl3RFk5bm13bEs1?= =?utf-8?B?ZVZ3ZGNML1dNRmE3bVNmTnptZUVpblNCYUF1MmdsNWZsb1NCOUFKNytFbWpE?= =?utf-8?B?SEcwOWV3TmJ6cFNOcTVLYXphaStDd3hKc2p5empMam9Mb09YL3AyQXphcWhK?= =?utf-8?B?OGY3UVJMNERvVklHa2RDU0R0UkRDR2d2TzB5ZzJUK2dha3llem9tUXIxV1E5?= =?utf-8?B?aU5IVytQMjVMUVFPMnJlaFl1WFFuRWV2dStGSm5aMjl3elNpR0JtSzY3SUUz?= =?utf-8?B?cm02c1kwcVVFWnF0dUtYcTlkeGFnS1JPL0tsRm52dUpuN3lEeWF2QWdPRkZV?= =?utf-8?B?ZXh1N2s4RjJQMTNCbnBoMDVodWs4cGJXWlJUa3pXU3hKTmF4ZStzMHl5SE9U?= =?utf-8?B?cWp1b1M3cmNBeUtrSGpQVVpuRUpSZGdJYUhtUThpSHRscXdaTzhWemlMM09i?= =?utf-8?B?ZHdaQkJwSUlqeVdQUWtYRERzaXVKV2Q2dlFsY1BJZm8zZnFEQUZpcXA2M2Rj?= =?utf-8?B?WTVDL0VXcmJ2alp0amxwQmRucUsyR3Vsb0VERHlQZENNbHlxSENxdHBndGRF?= =?utf-8?B?SzdsWk1rSTBESjVQNnVNaHVjYWpmTzNDR01kMk1Ebk1qUVU3L2xmS0hHRGRy?= =?utf-8?B?cjMxUEVlR05ERTFRTGgzb21iditLeUI0dXdaUkE1QkNUNnd1UytsZjUrL3p6?= =?utf-8?B?Y3B6TEdUaUJISWp3bU1iMmxXQXhmUjhkbWtJbFg2SmU2YmpZVWh1TzM0em9W?= =?utf-8?B?a1FDbjFtRk5oZDZ2YXZHdFppODA4WXFhaExFTThsWEtUZzlUcUFTOGJUZ0FY?= =?utf-8?B?dFREN0Rqb01qZGNtS1BNTFB1ZkRMSUtZUElUbnZGemtDUTRQR1JQdWRDWU8r?= =?utf-8?B?a01ObTlPRnBoOStrdGFLblZ4RHpXL0ZXc2ExeDJzM1RHTjU2RUtFTVR1MUw4?= =?utf-8?B?NklzQW1xd2dSVi9GQ1hlQUJrbklUYTN6WHRiY3gxbUZObHpldnlKZXVxdWlP?= =?utf-8?B?dGlDSFVtaHdnSFI4Y0swbzNWUmw5ckR1ZGdNRDh5NlFnTE13cHJ1cFZHcVVD?= =?utf-8?B?am1oVUZBbTZkUytEM0ZVVkpyRjhhbHRoUTBUN2pSZFZKNlIrS1RRa3RubGF2?= =?utf-8?B?L1V1WDFWMlM5UjFPM2dhallDbTJGR0tFKy9RTWprcWRFZm8zMDlJOUovZlJ5?= =?utf-8?B?cVJ6aHY0dkFZa1E4R0ErUU9jRVNsUHBlSmI4MEVzRFdML0VNemVEOGh0RHRR?= =?utf-8?B?VEtWSmpZdDhLeSsrL2FvcVprOUxCRnEwWnRseHRncTBHOHVGUE1GNVZSVGxJ?= =?utf-8?B?bXU1QVl3VlNzOVhMdHdnMnJuOWJWblphOUhQaVRlalE2bFFXNTlQYlhIWXVT?= =?utf-8?B?blBQeFFDN3BiVHlWTFB5V3ZGU21IY0o1TlVNSDdxZ3l3MnNNSWJJcVo3bDEx?= =?utf-8?B?anc9PQ==?= Content-ID: <191F212D591B6A48A1ED075B3BBB6E5D@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: KL1PR03MB5062.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1910a596-d14b-4557-a5bb-08dad10e4887 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Nov 2022 07:00:50.2318 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oTMxc/9m9rF9m84mznWQRiwkFPTOTw2k3le8fjIuUZGm8OReRNtuQ119eLNmvjzbx3kuxuQIemnYH0WiJ+2q0eWGkeNCet1UCrXObXl9hRk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR03MB6855 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221127_232104_231495_1D679221 X-CRM114-Status: GOOD ( 19.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2022-11-24 at 23:09 +0530, Vinod Koul wrote: > On 10-11-22, 21:27, Chunfeng Yun wrote: > > Add a debugfs root for phy class, then phy drivers can add debugfs > > files > > under this folder. > > > > Signed-off-by: Chunfeng Yun > > --- > > v2~v4: no changes > > --- > > drivers/phy/phy-core.c | 6 ++++++ > > include/linux/phy/phy.h | 2 ++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c > > index d93ddf1262c5..2f9f69190519 100644 > > --- a/drivers/phy/phy-core.c > > +++ b/drivers/phy/phy-core.c > > @@ -11,6 +11,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -1204,6 +1205,9 @@ void devm_of_phy_provider_unregister(struct > > device *dev, > > } > > EXPORT_SYMBOL_GPL(devm_of_phy_provider_unregister); > > > > +struct dentry *phy_debug_root; > > +EXPORT_SYMBOL_GPL(phy_debug_root); > > Why expose this to whole world? Alternate approach would be to add > this > in struct phy If only add it in struct phy, many phy folders will be created under /sys/kernel/debug/, and create them under /sys/kernel/debug/phy seems more clearer, this also follows other class, such as usb > > > + > > /** > > * phy_release() - release the phy > > * @dev: the dev member within phy > > @@ -1233,6 +1237,8 @@ static int __init phy_core_init(void) > > > > phy_class->dev_release = phy_release; > > > > + phy_debug_root = debugfs_create_dir("phy", NULL); > > + > > return 0; > > } > > device_initcall(phy_core_init); > > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > index b1413757fcc3..c398749d49b9 100644 > > --- a/include/linux/phy/phy.h > > +++ b/include/linux/phy/phy.h > > @@ -205,6 +205,8 @@ struct phy_lookup { > > #define devm_of_phy_provider_register_full(dev, children, xlate) \ > > __devm_of_phy_provider_register(dev, children, THIS_MODULE, > > xlate) > > > > +extern struct dentry *phy_debug_root; > > + > > static inline void phy_set_drvdata(struct phy *phy, void *data) > > { > > dev_set_drvdata(&phy->dev, data); > > -- > > 2.18.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel