From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86DD7C282C1 for ; Fri, 28 Feb 2025 16:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=luIE0Lf4JAHBS8LhKxuyQef8bCGyud3N4ZNDHk+iEL8=; b=w+luieDFTt2J1KG8SMgIRCApSo uR8gpJ5gimD17DRt5eVS52sHvX9WowJp2e3m6Toim0BhrWuOuwDjzPcX9ww87P3OWu8AODpunDFR6 YDj6zYWy/7sR8C4xWUe6AyWJPdihIYGJ9ZDkGf0+Zhl/O7f1eTYYUrNdI8rbO7GdpQO6r361gLRL+ +JB1QHqKxWVP04pERNEpp63sjg29lKkONRr4kRdTA/wwVZJ2qxHWEm1QLg/v+IGMqSLdNNAiXEP8r LaVwJE/RkS45z8UnJxdLda+x6HJhWy0J1MPp+gn+pOmLYgLFHPuq5zPjsXC7S0CsX3XEwsyZBnGwX BkKGrdGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1to2oM-0000000BaSV-1PYw; Fri, 28 Feb 2025 16:02:02 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1to2Z7-0000000BWlr-2GwK; Fri, 28 Feb 2025 15:46:19 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1740757575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=luIE0Lf4JAHBS8LhKxuyQef8bCGyud3N4ZNDHk+iEL8=; b=Jvz7yJ452lR8t9YC1wIIxBp7ro7I7QTTxUlXDF7Oox+l6ZnknysKkZpnv7UnuJeiGoDQz8 gkH3gqeNzEBGoIa78J7NYQi5Y3bW+sYOl+EUvtzo+BsbBQ50iuINXLKEeztXQRPDCDOf0w 9WL/Mi7yluhc1X5awOdpq2CsCQqI+yEI5ykdtyzUie01AY7O62Grd2XFGSKPrdu4HO/Eo/ N8SMvn73edg3RWBySKjupI+YBBcGkmS0WiODzMiYvunvy7WO+lLBWC0iS1uDbvYjHjSBAC J38ps6i8mBWDAVMuLu0b7WQoQ6QIaaiNseLdw721m133y0tqGLRzl8/av8TeVA== Date: Fri, 28 Feb 2025 16:46:15 +0100 From: Dragan Simic To: Olivier Benjamin Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Thomas Petazzoni , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, oren@taumoda.com, Ondrej Jirman Subject: Re: [PATCH 0/2] Describe the cameras in the PinePhone Pro dts In-Reply-To: <20250228-camera-v1-0-c51869f94e97@bootlin.com> References: <20250228-camera-v1-0-c51869f94e97@bootlin.com> Message-ID: <0338826971bfdd5b771bc1c6ada795eb@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250228_074617_733328_ABFC46E5 X-CRM114-Status: GOOD ( 14.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Olivier, On 2025-02-28 16:19, Olivier Benjamin wrote: > This series adds support for the Pine64 PinePhone Pro's rear and front > cameras in Device Tree. > This is based on some of Ondrej Jirman's patches hosted in his tree at > https://codeberg.org/megi/linux, but I have also fully reviewed and > re-written the code from the RK3399 datasheet, the PinePhone Pro > schematic, and the IMX258-0AQH5 software reference manual. > > I have tested these changes on my PinePhone Pro and am able to take > photos from both cameras using libcamera's cam. > > Signed-off-by: Olivier Benjamin I'm afraid that you haven't addressed the notes from the feedback you received earlier? [*] Also, this should be the v2 of the series, which should contain "PATCH v2" in the patch subjects, and provide a summary of changes in the cover letter. Or, did you just resend the v1 by mistake? [*] https://lore.kernel.org/linux-rockchip/5127541.31r3eYUQgx@phil/ > --- > Olivier Benjamin (2): > arm64: dts: PinePhone Pro: describe I2c Bus 1 and IMX258 world > camera > arm64: dts: PinePhone Pro: describe the OV8858 user camera > > .../boot/dts/rockchip/rk3399-pinephone-pro.dts | 138 > +++++++++++++++++++++ > 1 file changed, 138 insertions(+) > ---