From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5B2AC3DA63 for ; Thu, 25 Jul 2024 01:24:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:References:Content-Type: Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:In-Reply-To:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lcWowJqwataLcGPqJpSkB8xS8AWW/FBVdgQ4G5S6bgs=; b=gelIuIJYqmLX+FPZkUKucaOu5f 1zKc1CSEZTurRbK3R0LXAE5FxqieecKKJSoz89NzJA7ATllHMmoHN36DZFdYExApcczFBX7FBIDSh P/cYzrVkXDtKYP1MD1/gHkCAyTZtY2G6BdkGuVLvTE5nM/XCkmgEJYSZIA4id5cW0rnoPFwhAnQF5 WNs5JFXqlWfd5vTbU/gcoMaPZ1rAuMo6iFoX01g2QmyJOhcIzImSFTgdACEPEk2cj1qpMPTfhgIs5 /xK2vlKyoNGp20OvQZq0Pjl2kIZleR3d5FYKc8dUx75RNSTGkGiglBHt5jg6BOPfD4bDRZE/KtQ8E H5AaR9uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWnDi-0000000Gz81-1Qwp; Thu, 25 Jul 2024 01:24:38 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sWnDJ-0000000Gz4h-2S8F for linux-arm-kernel@lists.infradead.org; Thu, 25 Jul 2024 01:24:16 +0000 Received: from epcas2p4.samsung.com (unknown [182.195.41.56]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20240725012405epoutp04c23d71f370adf2332da54cc60145a6b9~lUDq53wBn1575015750epoutp04a for ; Thu, 25 Jul 2024 01:24:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20240725012405epoutp04c23d71f370adf2332da54cc60145a6b9~lUDq53wBn1575015750epoutp04a DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1721870645; bh=lcWowJqwataLcGPqJpSkB8xS8AWW/FBVdgQ4G5S6bgs=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=Py9flYZpNA2wWZJZXSbpWG6b2KzlY0cJ1zAGY3g8HCHghahJXA9yEVscJx4fyjghR 00Vy2LEcnmlhC8Uq7wBFbz91vHJUDK9HKQ/rl+A6RVpp62oYCh1JX+RIKzQTFVw7sK ln6fIKBBmN0dkt2T5EVEfHoL6Rw3dM6sBZtwwkMU= Received: from epsnrtp3.localdomain (unknown [182.195.42.164]) by epcas2p4.samsung.com (KnoxPortal) with ESMTP id 20240725012405epcas2p45f051bcea24f3df053b8b7ec54206e06~lUDqbGwTx1893918939epcas2p4a; Thu, 25 Jul 2024 01:24:05 +0000 (GMT) Received: from epsmges2p2.samsung.com (unknown [182.195.36.70]) by epsnrtp3.localdomain (Postfix) with ESMTP id 4WTtT04Hxfz4x9QB; Thu, 25 Jul 2024 01:24:04 +0000 (GMT) Received: from epcas2p2.samsung.com ( [182.195.41.54]) by epsmges2p2.samsung.com (Symantec Messaging Gateway) with SMTP id 36.08.10066.439A1A66; Thu, 25 Jul 2024 10:24:04 +0900 (KST) Received: from epsmtrp2.samsung.com (unknown [182.195.40.14]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPA id 20240725012404epcas2p1b6d7c9f8813400a5b18c985699ab6450~lUDpXhTkU2864428644epcas2p14; Thu, 25 Jul 2024 01:24:04 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp2.samsung.com (KnoxPortal) with ESMTP id 20240725012403epsmtrp2e992e48f3a24828aaa384136d19390a4~lUDpPYAHJ1657516575epsmtrp2A; Thu, 25 Jul 2024 01:24:03 +0000 (GMT) X-AuditID: b6c32a46-ae0cca8000002752-7c-66a1a934fcb6 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 6E.77.08964.339A1A66; Thu, 25 Jul 2024 10:24:03 +0900 (KST) Received: from KORCO118965 (unknown [10.229.18.201]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20240725012403epsmtip2ef95cdc89e8bd2586fdd092d6311c1b0~lUDpAeOxE2622826228epsmtip2e; Thu, 25 Jul 2024 01:24:03 +0000 (GMT) From: "sunyeal.hong" To: "'Rob Herring'" Cc: "'Krzysztof Kozlowski'" , "'Sylwester Nawrocki'" , "'Chanwoo Choi'" , "'Alim Akhtar'" , "'Michael Turquette'" , "'Stephen Boyd'" , "'Conor Dooley'" , , , , , In-Reply-To: <20240723205714.GA1093352-robh@kernel.org> Subject: RE: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings Date: Thu, 25 Jul 2024 10:24:03 +0900 Message-ID: <035501dade31$55cc7f40$01657dc0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKlY5hu3bVCnsOExtpi/jJA6pOgwAIfj46DASLmYXQCkOemkbBC/cjA Content-Language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIJsWRmVeSWpSXmKPExsWy7bCmma7JyoVpBkuWylk8mLeNzWLN3nNM Fte/PGe1mH/kHKvF+fMb2C02Pb7GavGx5x6rxeVdc9gsZpzfx2Rx8ZSrxf89O9gtDr9pZ7X4 d20jiwOvx/sbrewem1Z1snlsXlLv0bdlFaPH501yAaxR2TYZqYkpqUUKqXnJ+SmZeem2St7B 8c7xpmYGhrqGlhbmSgp5ibmptkouPgG6bpk5QCcqKZQl5pQChQISi4uV9O1sivJLS1IVMvKL S2yVUgtScgrMC/SKE3OLS/PS9fJSS6wMDQyMTIEKE7IzDkxfx1JwX6Hi3YdexgbGZ1JdjJwc EgImEvsO/mEBsYUEdjBK3LlV1sXIBWR/YpTovTiXHcL5xihxpeMfK1zHpDfMEIm9jBJPTs9k hHBeMkq0tjQwgVSxCehLrO6+zQZiiwioSjTNesACUsQs8JRZYsP+80Bz2Tk4Bcwl/vCAlAgL hElsndHBCGKzAJWvWrCAHcTmFbCUmHP5FxuELShxcuYTsFOZBeQltr+dwwxxkILEz6fLWCFW uUmsn/6FCaJGRGJ2ZxvYoRICRzgkNnzoAnI4gBwXidn7BCB6hSVeHd/CDmFLSXx+t5cNws6X mHz9LRNEbwOjxLV/3VDL7CUWnfnJDjKHWUBTYv0ufYiRyhJHbkGdxifRcfgvO0SYV6KjTQii UU3i05XLUENkJI6deMY8gVFpFpLHZiF5bBaSB2Yh7FrAyLKKUSy1oDg3PbXYqMAIHtXJ+bmb GMFpV8ttB+OUtx/0DjEycTAeYpTgYFYS4X3yam6aEG9KYmVValF+fFFpTmrxIUZTYFBPZJYS Tc4HJv68knhDE0sDEzMzQ3MjUwNzJXHee61zU4QE0hNLUrNTUwtSi2D6mDg4pRqY2HZ+Klhh dvFi46ETG1z8jx9IsFG113zrHP7eObRF9cU6awmbi1OXHJyyWaZWibe9xP5aOddnfodmG6bs n+ueaG08/V50jlHD5GlZd64aeZ1Mse6a8tLTnO+PyZNrp1+Xct37f0pew/rQ1D5GvSWKb/Ln vHov1z7RmyGfKyL4Z9ml0keTDFl/sC47/WR98b7X7Tunem6t6MuUjbj5fO1XUTmZ+qeJHg33 tkxaIp6zxN10w6Jfs2fpeUo2hXJ+3/7esehAqY7r0Tq+r+kOXXMn+y45OU8451urTMn25/+V yqPdi1tmdqxaJe0uPiOz2q+c0YNpzpILT0xiRZ3XZdXIfvKNE0t2LbnVHrxL6IeSEktxRqKh FnNRcSIAkkoNY0QEAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprLIsWRmVeSWpSXmKPExsWy7bCSvK7xyoVpBst+6ls8mLeNzWLN3nNM Fte/PGe1mH/kHKvF+fMb2C02Pb7GavGx5x6rxeVdc9gsZpzfx2Rx8ZSrxf89O9gtDr9pZ7X4 d20jiwOvx/sbrewem1Z1snlsXlLv0bdlFaPH501yAaxRXDYpqTmZZalF+nYJXBkHpq9jKbiv UPHuQy9jA+MzqS5GTg4JAROJfZPeMHcxcnEICexmlHgzYyYrREJGYmPDf3YIW1jifssRVoii 54wSr34vZgRJsAnoS6zuvs0GYosIqEo0zXrAAlLELPCeWWLmr0PsEB0fGCV+ztoBlGHn4BQw l/jDA1IvLBAiMXlRKxOIzQLUu2rBArBlvAKWEnMu/2KDsAUlTs58AtTJATRTT6JtI9haZgF5 ie1v5zBD3KYg8fPpMlaIE9wk1k//wgRRIyIxu7ONeQKj8Cwkk2YhTJqFZNIsJB0LGFlWMUqm FhTnpucWGxYY5qWW6xUn5haX5qXrJefnbmIEx6CW5g7G7as+6B1iZOJgPMQowcGsJML75NXc NCHelMTKqtSi/Pii0pzU4kOM0hwsSuK84i96U4QE0hNLUrNTUwtSi2CyTBycUg1MLqs+W19g Pv7qdYed0rmO8ln8RUebL5iY3NI98/F06scFXoIfVc1uX82fusdlXmOcoWRVRua+P+YtZU2X /i5fl/xf2nrn/22r3KwOOHheV73JEq8WslxdLIX9vTRPzOQj06+tsY46p1T1U+Ly6ij2BZ+d Q3qrSzffM/D89uBdRs0tx4k1nSFXrOS4Zy5Z+SdSyLLcNKXVjSkvIu/4rJXz9qbHC6eVFm/u awo4rFF44a1yqMQGSd0f6tPKFh486b6370FggWQm46MEhnNMkbsLW3p2pphlBJvZGMj7n5n6 /+7tv3+t57/dKv/fySNxtYPxmoOTQg4EnvBQ/bX7hLuizZt5H/J/zbtSHzt9AfMzJZbijERD Leai4kQA7i7zMjADAAA= X-CMS-MailID: 20240725012404epcas2p1b6d7c9f8813400a5b18c985699ab6450 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20240722223340epcas2p4ab83b1e8dbc64eaaf32f4f8b7e3f015d References: <20240722223333.1137947-1-sunyeal.hong@samsung.com> <20240722223333.1137947-2-sunyeal.hong@samsung.com> <20240723205714.GA1093352-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240724_182414_329896_0F7D9147 X-CRM114-Status: GOOD ( 28.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Rob, > -----Original Message----- > From: Rob Herring > Sent: Wednesday, July 24, 2024 5:57 AM > To: Sunyeal Hong > Cc: Krzysztof Kozlowski ; Sylwester Nawrocki > ; Chanwoo Choi ; Alim > Akhtar ; Michael Turquette > ; Stephen Boyd ; Conor Dooley > ; linux-samsung-soc@vger.kernel.org; linux- > clk@vger.kernel.org; devicetree@vger.kernel.org; linux-arm- > kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC > CMU bindings > > On Tue, Jul 23, 2024 at 07:33:30AM +0900, Sunyeal Hong wrote: > > Add dt-schema for ExynosAuto v920 SoC clock controller. > > Add device tree clock binding definitions for below CMU blocks. > > > > - CMU_TOP > > - CMU_PERIC0 > > > > Signed-off-by: Sunyeal Hong > > --- > > .../clock/samsung,exynosautov920-clock.yaml | 115 +++++++++++ > > .../clock/samsung,exynosautov920.h | 191 ++++++++++++++++++ > > 2 files changed, 306 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.y > > aml create mode 100644 > > include/dt-bindings/clock/samsung,exynosautov920.h > > > > diff --git > > a/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock > > .yaml > > b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock > > .yaml > > new file mode 100644 > > index 000000000000..90f9f17da959 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/samsung,exynosautov920-c > > +++ lock.yaml > > @@ -0,0 +1,115 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://protect2.fireeye.com/v1/url?k=9932a88e-c6ae81a4-993323c1-000b > > +abe598f7-779f1e959ac8eab9&q=1&e=539edfa4-b4e4-460a-93f4-1e6f17030945& > > +u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Fsamsung%2Cexynosaut > > +ov920-clock.yaml%23 > > +$schema: > > +https://protect2.fireeye.com/v1/url?k=4dbf6fb9-12234693-4dbee4f6-000b > > +abe598f7-363a2f64c69b9542&q=1&e=539edfa4-b4e4-460a-93f4-1e6f17030945& > > +u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > > + > > +title: Samsung ExynosAuto v920 SoC clock controller > > + > > +maintainers: > > + - Sunyeal Hong > > + - Chanwoo Choi > > + - Krzysztof Kozlowski > > + - Sylwester Nawrocki > > + > > +description: | > > + ExynosAuto v920 clock controller is comprised of several CMU units, > > +generating > > + clocks for different domains. Those CMU units are modeled as > > +separate device > > + tree nodes, and might depend on each other. Root clocks in that > > +clock tree are > > + two external clocks:: OSCCLK/XTCXO (38.4 MHz) and RTCCLK/XrtcXTI > (32768 Hz). > > + The external OSCCLK must be defined as fixed-rate clock in dts. > > + > > + CMU_TOP is a top-level CMU, where all base clocks are prepared > > + using PLLs and dividers; all other clocks of function blocks (other > > + CMUs) are usually derived from CMU_TOP. > > + > > + Each clock is assigned an identifier and client nodes can use this > > + identifier to specify the clock which they consume. All clocks > > + available for usage in clock consumer nodes are defined as > > + preprocessor macros in 'include/dt- > bindings/clock/samsung,exynosautov920.h' header. > > + > > +properties: > > + compatible: > > + enum: > > + - samsung,exynosautov920-cmu-top > > + - samsung,exynosautov920-cmu-peric0 > > + > > + clocks: > > + minItems: 1 > > + maxItems: 3 > > + > > + clock-names: > > + minItems: 1 > > + maxItems: 3 > > Move the descriptions and names here. Then in the if/then schemas just set > the number of items to 1 or 3 as appropriate. > > Rob Thank you for your review. I will update by reflecting the fixes. Thanks, Sunyeal Hong