From: Marc Zyngier <maz@kernel.org>
To: Qian Cai <cai@lca.pw>
Cc: drjones@redhat.com, suzuki.poulose@arm.com,
linux-kernel@vger.kernel.org, james.morse@arm.com,
christoffer.dall@linaro.org, julien.thierry.kdev@gmail.com,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64/kvm: fix -Wimplicit-fallthrough warnings
Date: Fri, 2 Aug 2019 15:32:26 +0100 [thread overview]
Message-ID: <0361d2e8-e57c-5cac-f0ff-5e56675ba71d@kernel.org> (raw)
In-Reply-To: <1564755788-28485-1-git-send-email-cai@lca.pw>
On 02/08/2019 15:23, Qian Cai wrote:
> The commit a892819560c4 ("KVM: arm64: Prepare to handle deferred
> save/restore of 32-bit registers") introduced vcpu_write_spsr32() but
> seems forgot to add "break" between the switch statements and generates
> compilation warnings below. Also, adding a default statement as in
> vcpu_read_spsr32().
See
https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git/commit/?id=3d584a3c85d6fe2cf878f220d4ad7145e7f89218
The default statement is pretty pointless by construction.
Thanks,
M.
--
Jazz is not dead, it just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-02 14:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 14:23 [PATCH] arm64/kvm: fix -Wimplicit-fallthrough warnings Qian Cai
2019-08-02 14:32 ` Marc Zyngier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0361d2e8-e57c-5cac-f0ff-5e56675ba71d@kernel.org \
--to=maz@kernel.org \
--cc=cai@lca.pw \
--cc=christoffer.dall@linaro.org \
--cc=drjones@redhat.com \
--cc=james.morse@arm.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).