* [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline @ 2017-05-24 11:17 Icenowy Zheng 2017-05-24 11:17 ` [PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC Icenowy Zheng 2017-05-25 8:37 ` [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline Chen-Yu Tsai 0 siblings, 2 replies; 10+ messages in thread From: Icenowy Zheng @ 2017-05-24 11:17 UTC (permalink / raw) To: linux-arm-kernel Allwinner V3s SoC features a "Display Engine 2.0" with only one mixer and only one TCON connected to this mixer, which have RGB LCD output. Add device nodes for this display pipeline. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> --- arch/arm/boot/dts/sun8i-v3s.dtsi | 83 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 83 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi index a49ebef53c91..3a06dc5b3746 100644 --- a/arch/arm/boot/dts/sun8i-v3s.dtsi +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi @@ -61,6 +61,12 @@ }; }; + de: display-engine { + compatible = "allwinner,sun8i-v3s-display-engine"; + allwinner,pipelines = <&mixer0>; + status = "disabled"; + }; + timer { compatible = "arm,armv7-timer"; interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, @@ -95,6 +101,83 @@ #size-cells = <1>; ranges; + display_clocks: clock at 1000000 { + compatible = "allwinner,sun8i-v3s-de2-clk"; + reg = <0x01000000 0x100000>; + clocks = <&ccu CLK_DE>, + <&ccu CLK_BUS_DE>; + clock-names = "mod", + "bus"; + resets = <&ccu RST_BUS_DE>; + #clock-cells = <1>; + #reset-cells = <1>; + }; + + mixer0: mixer at 1100000 { + compatible = "allwinner,sun8i-v3s-de2-mixer"; + reg = <0x01100000 0x100000>; + clocks = <&display_clocks 0>, + <&display_clocks 6>; + clock-names = "bus", + "mod"; + resets = <&display_clocks 0>; + assigned-clocks = <&display_clocks 6>; + assigned-clock-rates = <150000000>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + mixer0_out: port at 1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + mixer0_out_tcon0: endpoint at 0 { + reg = <0>; + remote-endpoint = <&tcon0_in_mixer0>; + }; + }; + }; + }; + + tcon0: lcd-controller at 1c0c000 { + compatible = "allwinner,sun8i-v3s-tcon"; + reg = <0x01c0c000 0x1000>; + interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&ccu CLK_BUS_TCON0>, + <&ccu CLK_TCON0>; + clock-names = "ahb", + "tcon-ch0"; + clock-output-names = "tcon-pixel-clock"; + resets = <&ccu RST_BUS_TCON0>; + reset-names = "lcd"; + status = "disabled"; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + tcon0_in: port at 0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + tcon0_in_mixer0: endpoint at 0 { + reg = <0>; + remote-endpoint = <&mixer0_out_tcon0>; + }; + }; + + tcon0_out: port at 1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + }; + }; + }; + + mmc0: mmc at 01c0f000 { compatible = "allwinner,sun7i-a20-mmc"; reg = <0x01c0f000 0x1000>; -- 2.12.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC 2017-05-24 11:17 [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline Icenowy Zheng @ 2017-05-24 11:17 ` Icenowy Zheng 2017-05-25 8:39 ` [linux-sunxi] " Chen-Yu Tsai 2017-05-25 8:37 ` [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline Chen-Yu Tsai 1 sibling, 1 reply; 10+ messages in thread From: Icenowy Zheng @ 2017-05-24 11:17 UTC (permalink / raw) To: linux-arm-kernel Allwinner V3s SoC features a set of pins that have functionality of RGB LCD, the pins are at different pin ban than other SoCs. Add pinctrl node for them. Signed-off-by: Icenowy Zheng <icenowy@aosc.io> Acked-by: Chen-Yu Tsai <wens@csie.org> --- arch/arm/boot/dts/sun8i-v3s.dtsi | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi index 3a06dc5b3746..81e5406661b4 100644 --- a/arch/arm/boot/dts/sun8i-v3s.dtsi +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi @@ -297,6 +297,15 @@ function = "i2c0"; }; + lcd_rgb666_pins: lcd_rgb666 { + pins = "PE0", "PE1", "PE2", "PE3", "PE4", + "PE5", "PE6", "PE7", "PE8", "PE9", + "PE10", "PE11", "PE12", "PE13", "PE14", + "PE15", "PE16", "PE17", "PE18", "PE19", + "PE23", "PE24"; + function = "lcd"; + }; + uart0_pins_a: uart0 at 0 { pins = "PB8", "PB9"; function = "uart0"; -- 2.12.2 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [linux-sunxi] [PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC 2017-05-24 11:17 ` [PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC Icenowy Zheng @ 2017-05-25 8:39 ` Chen-Yu Tsai 0 siblings, 0 replies; 10+ messages in thread From: Chen-Yu Tsai @ 2017-05-25 8:39 UTC (permalink / raw) To: linux-arm-kernel Hi, On Wed, May 24, 2017 at 7:17 PM, Icenowy Zheng <icenowy@aosc.io> wrote: > Allwinner V3s SoC features a set of pins that have functionality of RGB > LCD, the pins are at different pin ban than other SoCs. > > Add pinctrl node for them. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > Acked-by: Chen-Yu Tsai <wens@csie.org> > --- > arch/arm/boot/dts/sun8i-v3s.dtsi | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi > index 3a06dc5b3746..81e5406661b4 100644 > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > @@ -297,6 +297,15 @@ > function = "i2c0"; > }; > > + lcd_rgb666_pins: lcd_rgb666 { Please don't use underscores in the node name. Also, Please end the name with -pins. The node name should at least have that to indicate what it is. ChenYu > + pins = "PE0", "PE1", "PE2", "PE3", "PE4", > + "PE5", "PE6", "PE7", "PE8", "PE9", > + "PE10", "PE11", "PE12", "PE13", "PE14", > + "PE15", "PE16", "PE17", "PE18", "PE19", > + "PE23", "PE24"; > + function = "lcd"; > + }; > + > uart0_pins_a: uart0 at 0 { > pins = "PB8", "PB9"; > function = "uart0"; > -- > 2.12.2 > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe at googlegroups.com. > For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline 2017-05-24 11:17 [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline Icenowy Zheng 2017-05-24 11:17 ` [PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC Icenowy Zheng @ 2017-05-25 8:37 ` Chen-Yu Tsai 2017-05-25 13:54 ` Icenowy Zheng 1 sibling, 1 reply; 10+ messages in thread From: Chen-Yu Tsai @ 2017-05-25 8:37 UTC (permalink / raw) To: linux-arm-kernel On Wed, May 24, 2017 at 7:17 PM, Icenowy Zheng <icenowy@aosc.io> wrote: > Allwinner V3s SoC features a "Display Engine 2.0" with only one mixer > and only one TCON connected to this mixer, which have RGB LCD output. > > Add device nodes for this display pipeline. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.io> > --- > arch/arm/boot/dts/sun8i-v3s.dtsi | 83 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 83 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi b/arch/arm/boot/dts/sun8i-v3s.dtsi > index a49ebef53c91..3a06dc5b3746 100644 > --- a/arch/arm/boot/dts/sun8i-v3s.dtsi > +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi > @@ -61,6 +61,12 @@ > }; > }; > > + de: display-engine { > + compatible = "allwinner,sun8i-v3s-display-engine"; > + allwinner,pipelines = <&mixer0>; > + status = "disabled"; > + }; > + > timer { > compatible = "arm,armv7-timer"; > interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>, > @@ -95,6 +101,83 @@ > #size-cells = <1>; > ranges; > > + display_clocks: clock at 1000000 { > + compatible = "allwinner,sun8i-v3s-de2-clk"; > + reg = <0x01000000 0x100000>; > + clocks = <&ccu CLK_DE>, > + <&ccu CLK_BUS_DE>; > + clock-names = "mod", > + "bus"; > + resets = <&ccu RST_BUS_DE>; > + #clock-cells = <1>; > + #reset-cells = <1>; > + }; > + > + mixer0: mixer at 1100000 { Since there's only one, can you drop the numbering suffix? Same with the TCON. > + compatible = "allwinner,sun8i-v3s-de2-mixer"; > + reg = <0x01100000 0x100000>; The display engine also has an interrupt. Please list it. ChenYu ^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline 2017-05-25 8:37 ` [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline Chen-Yu Tsai @ 2017-05-25 13:54 ` Icenowy Zheng 2017-05-25 14:20 ` Chen-Yu Tsai 0 siblings, 1 reply; 10+ messages in thread From: Icenowy Zheng @ 2017-05-25 13:54 UTC (permalink / raw) To: linux-arm-kernel ? 2017?5?25? GMT+08:00 ??4:37:31, Chen-Yu Tsai <wens@csie.org> ??: >On Wed, May 24, 2017 at 7:17 PM, Icenowy Zheng <icenowy@aosc.io> wrote: >> Allwinner V3s SoC features a "Display Engine 2.0" with only one mixer >> and only one TCON connected to this mixer, which have RGB LCD output. >> >> Add device nodes for this display pipeline. >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >> --- >> arch/arm/boot/dts/sun8i-v3s.dtsi | 83 >++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 83 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi >b/arch/arm/boot/dts/sun8i-v3s.dtsi >> index a49ebef53c91..3a06dc5b3746 100644 >> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi >> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi >> @@ -61,6 +61,12 @@ >> }; >> }; >> >> + de: display-engine { >> + compatible = "allwinner,sun8i-v3s-display-engine"; >> + allwinner,pipelines = <&mixer0>; >> + status = "disabled"; >> + }; >> + >> timer { >> compatible = "arm,armv7-timer"; >> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | >IRQ_TYPE_LEVEL_LOW)>, >> @@ -95,6 +101,83 @@ >> #size-cells = <1>; >> ranges; >> >> + display_clocks: clock at 1000000 { >> + compatible = "allwinner,sun8i-v3s-de2-clk"; >> + reg = <0x01000000 0x100000>; >> + clocks = <&ccu CLK_DE>, >> + <&ccu CLK_BUS_DE>; >> + clock-names = "mod", >> + "bus"; >> + resets = <&ccu RST_BUS_DE>; >> + #clock-cells = <1>; >> + #reset-cells = <1>; >> + }; >> + >> + mixer0: mixer at 1100000 { > >Since there's only one, can you drop the numbering suffix? >Same with the TCON. I just want to keep the consistency with dual-pipeline SoCs. (H3, A64, H5, etc) However, if dropping it is better, I will drop it -- I think usually for things that is available for multiple on some SoCs and single on others, we keep the 0 in node name... > >> + compatible = "allwinner,sun8i-v3s-de2-mixer"; >> + reg = <0x01100000 0x100000>; > >The display engine also has an interrupt. Please list it It's a overall interrupt for DE2, not mixer interrupt. I will add it after we have proper interrupt chaining facility for DE2. It cannot fit here in mixer node. > >ChenYu ^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline 2017-05-25 13:54 ` Icenowy Zheng @ 2017-05-25 14:20 ` Chen-Yu Tsai 2017-05-25 14:28 ` Icenowy Zheng 0 siblings, 1 reply; 10+ messages in thread From: Chen-Yu Tsai @ 2017-05-25 14:20 UTC (permalink / raw) To: linux-arm-kernel On Thu, May 25, 2017 at 9:54 PM, Icenowy Zheng <icenowy@aosc.io> wrote: > > > ? 2017?5?25? GMT+08:00 ??4:37:31, Chen-Yu Tsai <wens@csie.org> ??: >>On Wed, May 24, 2017 at 7:17 PM, Icenowy Zheng <icenowy@aosc.io> wrote: >>> Allwinner V3s SoC features a "Display Engine 2.0" with only one mixer >>> and only one TCON connected to this mixer, which have RGB LCD output. >>> >>> Add device nodes for this display pipeline. >>> >>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >>> --- >>> arch/arm/boot/dts/sun8i-v3s.dtsi | 83 >>++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 83 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi >>b/arch/arm/boot/dts/sun8i-v3s.dtsi >>> index a49ebef53c91..3a06dc5b3746 100644 >>> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi >>> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi >>> @@ -61,6 +61,12 @@ >>> }; >>> }; >>> >>> + de: display-engine { >>> + compatible = "allwinner,sun8i-v3s-display-engine"; >>> + allwinner,pipelines = <&mixer0>; >>> + status = "disabled"; >>> + }; >>> + >>> timer { >>> compatible = "arm,armv7-timer"; >>> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | >>IRQ_TYPE_LEVEL_LOW)>, >>> @@ -95,6 +101,83 @@ >>> #size-cells = <1>; >>> ranges; >>> >>> + display_clocks: clock at 1000000 { >>> + compatible = "allwinner,sun8i-v3s-de2-clk"; >>> + reg = <0x01000000 0x100000>; >>> + clocks = <&ccu CLK_DE>, >>> + <&ccu CLK_BUS_DE>; >>> + clock-names = "mod", >>> + "bus"; >>> + resets = <&ccu RST_BUS_DE>; >>> + #clock-cells = <1>; >>> + #reset-cells = <1>; >>> + }; >>> + >>> + mixer0: mixer at 1100000 { >> >>Since there's only one, can you drop the numbering suffix? >>Same with the TCON. > > I just want to keep the consistency with dual-pipeline SoCs. (H3, A64, H5, etc) > > However, if dropping it is better, I will drop it -- I think usually for things > that is available for multiple on some SoCs and single on others, > we keep the 0 in node name... You might want that if you were going to include it in another SoC's dtsi file, such as the situation with A23/A33. However that is not the case here. Moreover, the datasheet lists them without the number. > >> >>> + compatible = "allwinner,sun8i-v3s-de2-mixer"; >>> + reg = <0x01100000 0x100000>; >> >>The display engine also has an interrupt. Please list it > > It's a overall interrupt for DE2, not mixer interrupt. > > I will add it after we have proper interrupt chaining facility for DE2. > > It cannot fit here in mixer node. Could you elaborate? If it is just shared, then listing it several times is OK. If the interrupt registers are not in this address space, then I agree, it needs to be dealt with separately and not added here. However some thought should be given about how the device tree binding should be. ChenYu > >> >>ChenYu > > -- > You received this message because you are subscribed to the Google Groups "linux-sunxi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe at googlegroups.com. > For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline 2017-05-25 14:20 ` Chen-Yu Tsai @ 2017-05-25 14:28 ` Icenowy Zheng 2017-05-29 8:59 ` Maxime Ripard 0 siblings, 1 reply; 10+ messages in thread From: Icenowy Zheng @ 2017-05-25 14:28 UTC (permalink / raw) To: linux-arm-kernel ? 2017?5?25? GMT+08:00 ??10:20:33, Chen-Yu Tsai <wens@csie.org> ??: >On Thu, May 25, 2017 at 9:54 PM, Icenowy Zheng <icenowy@aosc.io> wrote: >> >> >> ? 2017?5?25? GMT+08:00 ??4:37:31, Chen-Yu Tsai <wens@csie.org> ??: >>>On Wed, May 24, 2017 at 7:17 PM, Icenowy Zheng <icenowy@aosc.io> >wrote: >>>> Allwinner V3s SoC features a "Display Engine 2.0" with only one >mixer >>>> and only one TCON connected to this mixer, which have RGB LCD >output. >>>> >>>> Add device nodes for this display pipeline. >>>> >>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >>>> --- >>>> arch/arm/boot/dts/sun8i-v3s.dtsi | 83 >>>++++++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 83 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-v3s.dtsi >>>b/arch/arm/boot/dts/sun8i-v3s.dtsi >>>> index a49ebef53c91..3a06dc5b3746 100644 >>>> --- a/arch/arm/boot/dts/sun8i-v3s.dtsi >>>> +++ b/arch/arm/boot/dts/sun8i-v3s.dtsi >>>> @@ -61,6 +61,12 @@ >>>> }; >>>> }; >>>> >>>> + de: display-engine { >>>> + compatible = "allwinner,sun8i-v3s-display-engine"; >>>> + allwinner,pipelines = <&mixer0>; >>>> + status = "disabled"; >>>> + }; >>>> + >>>> timer { >>>> compatible = "arm,armv7-timer"; >>>> interrupts = <GIC_PPI 13 (GIC_CPU_MASK_SIMPLE(4) | >>>IRQ_TYPE_LEVEL_LOW)>, >>>> @@ -95,6 +101,83 @@ >>>> #size-cells = <1>; >>>> ranges; >>>> >>>> + display_clocks: clock at 1000000 { >>>> + compatible = "allwinner,sun8i-v3s-de2-clk"; >>>> + reg = <0x01000000 0x100000>; >>>> + clocks = <&ccu CLK_DE>, >>>> + <&ccu CLK_BUS_DE>; >>>> + clock-names = "mod", >>>> + "bus"; >>>> + resets = <&ccu RST_BUS_DE>; >>>> + #clock-cells = <1>; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>>> + mixer0: mixer at 1100000 { >>> >>>Since there's only one, can you drop the numbering suffix? >>>Same with the TCON. >> >> I just want to keep the consistency with dual-pipeline SoCs. (H3, >A64, H5, etc) >> >> However, if dropping it is better, I will drop it -- I think usually >for things >> that is available for multiple on some SoCs and single on others, >> we keep the 0 in node name... > >You might want that if you were going to include it in another SoC's >dtsi >file, such as the situation with A23/A33. However that is not the case >here. >Moreover, the datasheet lists them without the number. OK... > >> >>> >>>> + compatible = >"allwinner,sun8i-v3s-de2-mixer"; >>>> + reg = <0x01100000 0x100000>; >>> >>>The display engine also has an interrupt. Please list it >> >> It's a overall interrupt for DE2, not mixer interrupt. >> >> I will add it after we have proper interrupt chaining facility for >DE2. >> >> It cannot fit here in mixer node. > >Could you elaborate? If it is just shared, then listing it several >times >is OK. If the interrupt registers are not in this address space, then The interrupt dealing code is still not so clear, and totally not present in BSP DE2 code (the BSP just didn't use the interrupt). We doesn't even know where the interrupt register is, and we cannot promise it's not broken (as their is even no application of it in BSP). So it couldn't be added now. >I agree, it needs to be dealt with separately and not added here. >However >some thought should be given about how the device tree binding should >be. > >ChenYu > >> >>> >>>ChenYu >> >> -- >> You received this message because you are subscribed to the Google >Groups "linux-sunxi" group. >> To unsubscribe from this group and stop receiving emails from it, >send an email to linux-sunxi+unsubscribe at googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. ^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline 2017-05-25 14:28 ` Icenowy Zheng @ 2017-05-29 8:59 ` Maxime Ripard 2017-05-29 13:01 ` icenowy at aosc.io 0 siblings, 1 reply; 10+ messages in thread From: Maxime Ripard @ 2017-05-29 8:59 UTC (permalink / raw) To: linux-arm-kernel On Thu, May 25, 2017 at 10:28:24PM +0800, Icenowy Zheng wrote: > >>>> + compatible = "allwinner,sun8i-v3s-de2-mixer"; > >>>> + reg = <0x01100000 0x100000>; > >>> > >>>The display engine also has an interrupt. Please list it > >> > >> It's a overall interrupt for DE2, not mixer interrupt. > >> > >> I will add it after we have proper interrupt chaining facility > >> for DE2. > >> > >> It cannot fit here in mixer node. > > > > Could you elaborate? If it is just shared, then listing it several > > times is OK. If the interrupt registers are not in this address > > space, then > > The interrupt dealing code is still not so clear, and totally not > present in BSP DE2 code (the BSP just didn't use the interrupt). > > We doesn't even know where the interrupt register is, and we cannot > promise it's not broken (as their is even no application of it in BSP). Whether it's broken or not is out of the question here. Adding it later would either break the DT compatibility, or introduce a crippled driver for users that do not have a recent enough DT. None of the two are really acceptable. Especially if your plan is to add support for these. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170529/9163d8e5/attachment.sig> ^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline 2017-05-29 8:59 ` Maxime Ripard @ 2017-05-29 13:01 ` icenowy at aosc.io 2017-06-02 22:10 ` Maxime Ripard 0 siblings, 1 reply; 10+ messages in thread From: icenowy at aosc.io @ 2017-05-29 13:01 UTC (permalink / raw) To: linux-arm-kernel ? 2017-05-29 16:59?Maxime Ripard ??? > On Thu, May 25, 2017 at 10:28:24PM +0800, Icenowy Zheng wrote: >> >>>> + compatible = "allwinner,sun8i-v3s-de2-mixer"; >> >>>> + reg = <0x01100000 0x100000>; >> >>> >> >>>The display engine also has an interrupt. Please list it >> >> >> >> It's a overall interrupt for DE2, not mixer interrupt. >> >> >> >> I will add it after we have proper interrupt chaining facility >> >> for DE2. >> >> >> >> It cannot fit here in mixer node. >> > >> > Could you elaborate? If it is just shared, then listing it several >> > times is OK. If the interrupt registers are not in this address >> > space, then >> >> The interrupt dealing code is still not so clear, and totally not >> present in BSP DE2 code (the BSP just didn't use the interrupt). >> >> We doesn't even know where the interrupt register is, and we cannot >> promise it's not broken (as their is even no application of it in >> BSP). > > Whether it's broken or not is out of the question here. Adding it > later would either break the DT compatibility, or introduce a crippled > driver for users that do not have a recent enough DT. None of the two > are really acceptable. > > Especially if your plan is to add support for these. I have no such plan -- even the BSP driver doesn't use the IRQ at all. > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com ^ permalink raw reply [flat|nested] 10+ messages in thread
* [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline 2017-05-29 13:01 ` icenowy at aosc.io @ 2017-06-02 22:10 ` Maxime Ripard 0 siblings, 0 replies; 10+ messages in thread From: Maxime Ripard @ 2017-06-02 22:10 UTC (permalink / raw) To: linux-arm-kernel On Mon, May 29, 2017 at 09:01:59PM +0800, icenowy at aosc.io wrote: > ? 2017-05-29 16:59?Maxime Ripard ??? > > On Thu, May 25, 2017 at 10:28:24PM +0800, Icenowy Zheng wrote: > > > >>>> + compatible = "allwinner,sun8i-v3s-de2-mixer"; > > > >>>> + reg = <0x01100000 0x100000>; > > > >>> > > > >>>The display engine also has an interrupt. Please list it > > > >> > > > >> It's a overall interrupt for DE2, not mixer interrupt. > > > >> > > > >> I will add it after we have proper interrupt chaining facility > > > >> for DE2. > > > >> > > > >> It cannot fit here in mixer node. > > > > > > > > Could you elaborate? If it is just shared, then listing it several > > > > times is OK. If the interrupt registers are not in this address > > > > space, then > > > > > > The interrupt dealing code is still not so clear, and totally not > > > present in BSP DE2 code (the BSP just didn't use the interrupt). > > > > > > We doesn't even know where the interrupt register is, and we cannot > > > promise it's not broken (as their is even no application of it in > > > BSP). > > > > Whether it's broken or not is out of the question here. Adding it > > later would either break the DT compatibility, or introduce a crippled > > driver for users that do not have a recent enough DT. None of the two > > are really acceptable. > > > > Especially if your plan is to add support for these. > > I have no such plan -- even the BSP driver doesn't use the IRQ at all. We'll see how it turns out.. I applied that patch. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 801 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170603/5423ddac/attachment.sig> ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-06-02 22:10 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-05-24 11:17 [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline Icenowy Zheng 2017-05-24 11:17 ` [PATCH 2/2] ARM: sun8i: v3s: add pinmux for LCD pins of V3s SoC Icenowy Zheng 2017-05-25 8:39 ` [linux-sunxi] " Chen-Yu Tsai 2017-05-25 8:37 ` [linux-sunxi] [PATCH 1/2] ARM: sun8i: v3s: add device nodes for DE2 display pipeline Chen-Yu Tsai 2017-05-25 13:54 ` Icenowy Zheng 2017-05-25 14:20 ` Chen-Yu Tsai 2017-05-25 14:28 ` Icenowy Zheng 2017-05-29 8:59 ` Maxime Ripard 2017-05-29 13:01 ` icenowy at aosc.io 2017-06-02 22:10 ` Maxime Ripard
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).