From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62866CA101F for ; Fri, 12 Sep 2025 11:11:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IUNlJgUtKlThWVuegzMCgno/3rScWO4fdbH39TrSDAw=; b=sOOirwk1mRmoLr2/ca4R+hRZoJ 4brgOBrLu2/IkESSuPOJ6jtjNEABn9rQ7BDax+pgkinmkCfrMLSkNMkLjLy5rgfCCWb6k9oC1pA0+ Un17uTNfW8wsrNP0WHCpLLdkWIl/29NM7LGhLTzS6iPSTIUEZW66hpJ+xNw0I1Nu5EPKMVXK/71oQ 5CLKVEelprscnB0gwDYq5P6iM1Htt4yqtrZiXi3PnK1aFfDUHIhQ8dI2rJFwyDbf/pOBwZbs9SdPU FE4GSr/eCdyDs740S5SpX7yoNL6c0cv/R1LL5ukT0nGDo+jDZPDOh0wFlbKvnGOzNcaO07C+Qlyfy m4+4gDwA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ux1gQ-00000008naR-21N4; Fri, 12 Sep 2025 11:11:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ux1gM-00000008nZ8-3vrD for linux-arm-kernel@lists.infradead.org; Fri, 12 Sep 2025 11:11:13 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A04BE1515; Fri, 12 Sep 2025 04:11:01 -0700 (PDT) Received: from [10.1.196.46] (e134344.arm.com [10.1.196.46]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D0A353F63F; Fri, 12 Sep 2025 04:11:04 -0700 (PDT) Message-ID: <0382ea8a-8f15-4983-8659-0471f9090012@arm.com> Date: Fri, 12 Sep 2025 12:11:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/29] arm_mpam: Probe hardware to find the supported partid/pmg values To: James Morse , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-12-james.morse@arm.com> From: Ben Horgan Content-Language: en-US In-Reply-To: <20250910204309.20751-12-james.morse@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250912_041111_015060_20E51235 X-CRM114-Status: GOOD ( 14.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, On 9/10/25 21:42, James Morse wrote: > CPUs can generate traffic with a range of PARTID and PMG values, > but each MSC may also have its own maximum size for these fields. > Before MPAM can be used, the driver needs to probe each RIS on > each MSC, to find the system-wide smallest value that can be used. > The limits from requestors (e.g. CPUs) also need taking into account. > > While doing this, RIS entries that firmware didn't describe are created > under MPAM_CLASS_UNKNOWN. > > While we're here, implement the mpam_register_requestor() call > for the arch code to register the CPU limits. Future callers of this > will tell us about the SMMU and ITS. > > Signed-off-by: James Morse > --- > Changes since v1: > * Change to lock ordering now that the list-lock mutex isn't held from > the cpuhp call. > * Removed irq-unmaksed assert in requestor register. > * Changed captialisation in print message. > --- > drivers/resctrl/mpam_devices.c | 150 +++++++++++++++++++++++++++++++- > drivers/resctrl/mpam_internal.h | 6 ++ > include/linux/arm_mpam.h | 14 +++ > 3 files changed, 169 insertions(+), 1 deletion(-) Looks good to me. I think Jonathan's comment on getting rid of the local variable, 'found', is worthwhile. Reviewed-by: Ben Horgan Thanks, Ben