From: kgene@kernel.org (kgene at kernel.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c
Date: Tue, 09 Sep 2014 12:39:36 +0900 [thread overview]
Message-ID: <03a501cfcbdf$ad9f5680$08de0380$@kernel.org> (raw)
In-Reply-To: <1409920495-16533-1-git-send-email-k.kozlowski@samsung.com>
Krzysztof Kozlowski wrote:
>
> Cleanup a little the SMP/hotplug code for Exynos by:
> 1. Moving completely all functions from hotplug.c into the platsmp.c;
> 2. Deleting the hotplug.c file.
>
> After recent cleanups (e.g. 75ad2ab28f0f "ARM: EXYNOS: use
> v7_exit_coherency_flush macro for cache disabling") there was only CPU
> power down related code in hotplug.c file.
>
> Rationale behind the code movement and benefits:
> 1. The file platsmp.c is the only user of code located in hotplug.c.
> Keeping code in hotplug.c required declaring exynos_cpu_die() in common.h.
> Such dependencies and mentioned exynos_cpu_die() declaration can be
> removed.
> 2. In next patches exynos_set_delayed_reset_assertion() will be
> introduced. This function will be called by:
> - cpu_leave_power (hotplug.c),
> - platform_do_lowpower (hotplug.c),
> - exynos_boot_secondary (platsmp.c).
>
> Merging hotplug.c into platsmp.c leads to simpler and cleaner code with
> less dependencies between files.
>
> The commit only moves code around with one additional observable change:
> the hotplug.c was compiled with custom CFLAGS (-march=armv7-a). These
> CFLAGS are not necessary any more.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
> ---
> Changes since v4:
> 1. Rebase on linux-next-20140804.
> 2. Add Reviewed-by Tomasz Figa.
> ---
> arch/arm/mach-exynos/Makefile | 3 --
> arch/arm/mach-exynos/common.h | 2 -
> arch/arm/mach-exynos/hotplug.c | 91 ------------------------------------------
> arch/arm/mach-exynos/platsmp.c | 74 ++++++++++++++++++++++++++++++++++
> 4 files changed, 74 insertions(+), 96 deletions(-)
> delete mode 100644 arch/arm/mach-exynos/hotplug.c
[...]
OK, I will take this series but I'm not sure what conflicts will be happened
with other pm related patches. If anything, I'll let you know ;)
Thanks,
Kukjin
next prev parent reply other threads:[~2014-09-09 3:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 12:34 [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c Krzysztof Kozlowski
2014-09-05 12:34 ` [PATCH v5 RESEND 2/3] ARM: EXYNOS: Remove unneeded __ref annotation for cpu_die function Krzysztof Kozlowski
2014-09-05 12:34 ` [PATCH v5 RESEND 3/3] ARM: exynos4: hotplug: Fix CPU idle clock down after CPU off Krzysztof Kozlowski
2014-09-09 3:39 ` kgene at kernel.org [this message]
2014-09-26 21:13 ` [PATCH v5 RESEND 1/3] ARM: EXYNOS: Move code from hotplug.c to platsmp.c Arnd Bergmann
2014-09-27 8:39 ` Krzysztof Kozlowski
2014-09-28 4:42 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='03a501cfcbdf$ad9f5680$08de0380$@kernel.org' \
--to=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).