From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: 'Wei Yongjun <weiyongjun1@huawei.com>,
Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Frank Li <frank.li@nxp.com>
Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH -next] usb: cdns3: imx: mark cdns_imx_resume as __maybe_unused
Date: Tue, 9 Mar 2021 18:26:45 +0300 [thread overview]
Message-ID: <03c23018-f26d-0aa2-e319-efb2683d633d@gmail.com> (raw)
In-Reply-To: <20210309131457.1884112-1-weiyongjun1@huawei.com>
Hello!
On 3/9/21 4:14 PM, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> The function cdns_imx_resume() may have no callers depending
> on configuration, so it must be marked __maybe_unused to avoid
> harmless warning:
>
> drivers/usb/cdns3/cdns3-imx.c:378:12: warning:
> 'cdns_imx_system_resume' defined but not used [-Wunused-function]
> 378 | static int cdns_imx_system_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~
Looks like that warning was copied from another kernel, where this function
was named differently?
>
> Fixes: 67982dfa59de ("usb: cdns3: imx: add power lost support for system resume")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/usb/cdns3/cdns3-imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/cdns3/cdns3-imx.c b/drivers/usb/cdns3/cdns3-imx.c
> index 708b51cc5844..96fff823a594 100644
> --- a/drivers/usb/cdns3/cdns3-imx.c
> +++ b/drivers/usb/cdns3/cdns3-imx.c
> @@ -346,7 +346,7 @@ static int cdns_imx_platform_suspend(struct device *dev,
>
> }
>
> -static int cdns_imx_resume(struct device *dev)
> +static int __maybe_unused cdns_imx_resume(struct device *dev)
> {
> struct cdns_imx *data = dev_get_drvdata(dev);
>
MBR, Sergei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-09 15:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 13:14 [PATCH -next] usb: cdns3: imx: mark cdns_imx_resume as __maybe_unused 'Wei Yongjun
2021-03-09 15:26 ` Sergei Shtylyov [this message]
2021-03-09 15:47 ` weiyongjun (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03c23018-f26d-0aa2-e319-efb2683d633d@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=frank.li@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox