From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8EF3C433E0 for ; Tue, 9 Mar 2021 15:28:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 491B06521D for ; Tue, 9 Mar 2021 15:28:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 491B06521D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+bkSxepiEUYJwtnS0GC+LDAOmmYbZErlwwWgMm0EyL8=; b=Dpa66KX0goQxGXr1U8mgS9eKL cn4ApJxluWWfvphc7S+XWyvTrkxqbZg9Ivj0bp3Lle5XGAnQnyPoUucMC5/KoDRAsLdwfCUfuNtkb G9/6uCcyuisl9yUdfRBYZXNYutbkeZ0uk5cCnySzkQlrEK3/wgNbuhgXoUud56S/ILnId/Sn4lozb yzYX39I/2DhK3bDCmf13SSkbS7JsqNP5A0qjzCzW/HOFFivnSV1PYHIAH+c+9RCOMR0gvaHPptnTW Ij2gpXYigMieMCrDINPmKhqJKaiu8NzwA5fBTLGpEIhRWfvQJ7jJf3jkzVqWUHpMMT2o9jnLtPNdp zgiiZKtgw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJeG6-004xxk-AK; Tue, 09 Mar 2021 15:26:54 +0000 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJeG1-004xwb-PJ for linux-arm-kernel@lists.infradead.org; Tue, 09 Mar 2021 15:26:51 +0000 Received: by mail-lj1-x22d.google.com with SMTP id e2so21139940ljo.7 for ; Tue, 09 Mar 2021 07:26:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=rFC6JX2geeI70fyZtdsl3qpdPvdXkbuAh4i2jTWjv1s=; b=r5n2LJiAeojyOblPJVf02Wc3nAGV4oBPT5YVDFyVwrLoCwAmsX2M5JT2Fj5FXqGyHO 49rdQ7ddXulHm/VIR26i40uECtW9dkHi5pN0ygPhAHSiImm1BKNzSKJCphm4aXJYk+/A OU+Ce4qFg0ZeyGgOTno65vs4Z32vipU9yUGPE1oxvkkjCeAo7bb/jUoAU74f1RD8dCw4 XvufXizwmbg2mfNsPrIJerKaONy7L4OwIG/yWgnq8eA25Ig/GJynwMz5ZXZH3inOUNYv Lxjmps1xWSDp1iCLcsxC3iRWN9zLUE33LwBZVPOxu/2qnYcVZUGkoSQ3OH7EqsVSLiPO tvyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rFC6JX2geeI70fyZtdsl3qpdPvdXkbuAh4i2jTWjv1s=; b=NCdGWjv3IirXdXDSIzXIThQQqXLamg9qkKgHZ01vRCh5uyc46N2CoHQHQYzkrM3NBu RYkhjfWn2SZ1lLO5LfJswucOuZ3jJOqpMPCankJOB1It0cWpYpA1+8bezbebmmQ8AOHB TdZrQDNvp5I4PyeiD7aHUtePnxgIt+/xH4RDzL62dNK7N88H0tSFZSQoTCiGsxE5rzVH XsyPAIot91+M3dA/lPom3aOOG9ryK49hlShfWJoxKD3PmgrZpf8jBziv3NcEjF52yBfI JyQw+/0pul9zoQBGqURjhWthdu+uGqUaEGZoMkn2qofw8fvwLmYgIPNQni9INSDDR28c Ra8g== X-Gm-Message-State: AOAM530eniFD8JkGIGRGfwOkWO9UQQ7GPdHtXNsXZkoKVgGTN35lPzDj Zg4hpqZ1dpka8bLj0j3W+jE= X-Google-Smtp-Source: ABdhPJzp48kyS6lakDiPeXkABIMcEFvpWehCfF7cx+K8mxcfh7ESPxIO281C8KNqeHZht8CUivIhyA== X-Received: by 2002:a2e:3907:: with SMTP id g7mr17948263lja.159.1615303608630; Tue, 09 Mar 2021 07:26:48 -0800 (PST) Received: from [192.168.1.101] ([178.176.72.196]) by smtp.gmail.com with ESMTPSA id m1sm2043055ljg.111.2021.03.09.07.26.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Mar 2021 07:26:48 -0800 (PST) Subject: Re: [PATCH -next] usb: cdns3: imx: mark cdns_imx_resume as __maybe_unused To: 'Wei Yongjun , Peter Chen , Pawel Laszczak , Greg Kroah-Hartman , Shawn Guo , Sascha Hauer , Frank Li Cc: linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel-janitors@vger.kernel.org, Hulk Robot References: <20210309131457.1884112-1-weiyongjun1@huawei.com> From: Sergei Shtylyov Message-ID: <03c23018-f26d-0aa2-e319-efb2683d633d@gmail.com> Date: Tue, 9 Mar 2021 18:26:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210309131457.1884112-1-weiyongjun1@huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210309_152650_091557_D5E8EE4B X-CRM114-Status: GOOD ( 20.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello! On 3/9/21 4:14 PM, 'Wei Yongjun wrote: > From: Wei Yongjun > > The function cdns_imx_resume() may have no callers depending > on configuration, so it must be marked __maybe_unused to avoid > harmless warning: > > drivers/usb/cdns3/cdns3-imx.c:378:12: warning: > 'cdns_imx_system_resume' defined but not used [-Wunused-function] > 378 | static int cdns_imx_system_resume(struct device *dev) > | ^~~~~~~~~~~~~~~~~~ Looks like that warning was copied from another kernel, where this function was named differently? > > Fixes: 67982dfa59de ("usb: cdns3: imx: add power lost support for system resume") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/usb/cdns3/cdns3-imx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/cdns3/cdns3-imx.c b/drivers/usb/cdns3/cdns3-imx.c > index 708b51cc5844..96fff823a594 100644 > --- a/drivers/usb/cdns3/cdns3-imx.c > +++ b/drivers/usb/cdns3/cdns3-imx.c > @@ -346,7 +346,7 @@ static int cdns_imx_platform_suspend(struct device *dev, > > } > > -static int cdns_imx_resume(struct device *dev) > +static int __maybe_unused cdns_imx_resume(struct device *dev) > { > struct cdns_imx *data = dev_get_drvdata(dev); > MBR, Sergei _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel