From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 374ADC43381 for ; Sat, 30 Mar 2019 19:41:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B6FE20989 for ; Sat, 30 Mar 2019 19:41:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="m9/1KUiT"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="L+NGhLD2"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="TngByBcy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B6FE20989 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eyM5Hx0GNOwPoxOcPuTOrHHoeb5yWuA5GAKR0Wd+AZ4=; b=m9/1KUiTL8WT3j4Y8oaONQodH NIK6D1wKFTT3FCkxwiVCqKj4vwfUvEPo/pKgVqlDHu3ny010pmrsbkkS/NAjo/WHDHj6Z4vXNSVMF iwVse3KdGenMJkNUROF/bhXiUXaobuOBsHtvNMiY4Ml1IfAAbpx05OqKt6ShFc0YTBnqDui8CVYOy 5/yGS9JAlVpkQOOZlaI1IcLARTWnD2oe+BtBAHLAIDqgaO7GO0NMwCP9zLfj794cY5xHZeuP26U7E mYJH1L43SYfBSryVMVKM0rX2sZJzL8uG3mQm1Cy7Cwo4+57rs+RmZ+JmzI2Y/ypyvjYuLz6gExGo1 wtkz5ornQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAJqo-0004RT-5w; Sat, 30 Mar 2019 19:41:10 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hAJqk-0004R2-39 for linux-arm-kernel@lists.infradead.org; Sat, 30 Mar 2019 19:41:07 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1DC29608FC; Sat, 30 Mar 2019 19:41:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553974864; bh=0Zmeq/zPBBJ/BI23WiFWIQT+mEnwWFkYQsnZhLRE44g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=L+NGhLD2Dd5726JD3532f30BCsAqUeiLWhkQJ21MC0mr2woS+91GcwgzcwrE1GnXf ttcjzQoQhG7cmmI2YvbjoGlvxHsVuj4AMfyfrLR/LvTZUN4f6zujZtTaZK9/CiT7up WRTV/y79koSo9Oko/j6mdOn99ceC+fmuHh1jgvrc= Received: from [10.79.169.97] (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mojha@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3637560790; Sat, 30 Mar 2019 19:40:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1553974863; bh=0Zmeq/zPBBJ/BI23WiFWIQT+mEnwWFkYQsnZhLRE44g=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=TngByBcyiksxjRvBdfpXA/kSZdygnCRo4NwrFmhZpO6s24xyfDE01KEBsniv5PHgQ 54B/T2c7KPeLJZgPyecyRl3M4UFVlznYh+8aXAoSsYJ/iJofjg0dTEqKhyAze55hpX SaqC/4sd+cxcU2rlu5ejnhpkVFMDLKT3rUuWM4jA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3637560790 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mojha@codeaurora.org Subject: Re: [PATCH] arm64/vdso: don't leak kernel addresses To: Matteo Croce , linux-arm-kernel@lists.infradead.org References: <20190330184638.16219-1-mcroce@redhat.com> From: Mukesh Ojha Message-ID: <03d00567-2efb-a2e9-e771-bf3bf121a8fa@codeaurora.org> Date: Sun, 31 Mar 2019 01:10:54 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190330184638.16219-1-mcroce@redhat.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190330_124106_155108_7CCD44F6 X-CRM114-Status: GOOD ( 16.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/31/2019 12:16 AM, Matteo Croce wrote: > Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), > two obfuscated kernel pointer are printed at every boot: > > vdso: 2 pages (1 code @ (____ptrval____), 1 data @ (____ptrval____)) > > Remove the addresses from the print, which turns into a more discrete: > > vdso: 2 pages (1 code, 1 data) > > Fixes: ad67b74d2469d9b8 ("printk: hash addresses printed with %p") > Signed-off-by: Matteo Croce Reviewed-by: Mukesh Ojha Cheers, -Mukesh > --- > arch/arm64/kernel/vdso.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/kernel/vdso.c b/arch/arm64/kernel/vdso.c > index 2d419006ad43..fdfee0ef5bc5 100644 > --- a/arch/arm64/kernel/vdso.c > +++ b/arch/arm64/kernel/vdso.c > @@ -146,8 +146,8 @@ static int __init vdso_init(void) > } > > vdso_pages = (vdso_end - vdso_start) >> PAGE_SHIFT; > - pr_info("vdso: %ld pages (%ld code @ %p, %ld data @ %p)\n", > - vdso_pages + 1, vdso_pages, vdso_start, 1L, vdso_data); > + pr_info("vdso: %ld pages (%ld code, %ld data)\n", > + vdso_pages + 1, vdso_pages, 1L); > > /* Allocate the vDSO pagelist, plus a page for the data. */ > vdso_pagelist = kcalloc(vdso_pages + 1, sizeof(struct page *), _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel