From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BBACC4338F for ; Tue, 10 Aug 2021 01:30:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B594A6101E for ; Tue, 10 Aug 2021 01:30:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B594A6101E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=8eic8aOQYDQIUYfNaBoP7XF3PSgEPFhv6MYwWvJvFrw=; b=fNinKYmtBtqUghIjsISY34HTkb gbu8vtSKhTMNLFSegJg5XA4ke5fbFLC1hpbnI1YVS+m+LWxO844dwm/BoQ4+wf2jWi53+pUQCy3QL A0nlPYAmvPPgB+fwOue+97GuRgn+zkOGpiPjPTHiUvSJ5QkvutZgRI5QjK0EppRQ/lqSuz/6LXtCz 0hmtUQMaYbOZT8RAKaWeZ0sLDIdbhRO1P26jgHWPhJRfRwkI/Ul3ry265P5Q9pQw1D0jxT7j0fMJt FdHiDMrjWE9dpMhT5AlIYr3uyVQzGk5OsxNmdyz0tg7pm//ydheDGCK8YDMVc7sv2n7GEgsVo92fn kQ6TtvJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDGYv-002DeW-Ko; Tue, 10 Aug 2021 01:28:13 +0000 Received: from szxga02-in.huawei.com ([45.249.212.188]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mDGYr-002De7-Hd for linux-arm-kernel@lists.infradead.org; Tue, 10 Aug 2021 01:28:11 +0000 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4GkFbx2JylzcmLm; Tue, 10 Aug 2021 09:24:29 +0800 (CST) Received: from dggpemm500006.china.huawei.com (7.185.36.236) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 10 Aug 2021 09:28:07 +0800 Received: from [10.174.179.0] (10.174.179.0) by dggpemm500006.china.huawei.com (7.185.36.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 10 Aug 2021 09:28:06 +0800 Subject: Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART To: Leo Li , Shawn Guo , Rob Herring , Mark Kettenis , devicetree , linux-arm-kernel , linux-kernel References: <20210615131605.616-1-thunder.leizhen@huawei.com> <20210615131605.616-2-thunder.leizhen@huawei.com> From: "Leizhen (ThunderTown)" Message-ID: <03d7c7be-2f19-9fdf-2a4e-f49a62bb82f6@huawei.com> Date: Tue, 10 Aug 2021 09:28:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.174.179.0] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500006.china.huawei.com (7.185.36.236) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210809_182809_989403_2F3E921F X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/8/10 6:52, Leo Li wrote: > > >> -----Original Message----- >> From: Zhen Lei >> Sent: Tuesday, June 15, 2021 8:16 AM >> To: Shawn Guo ; Leo Li ; Rob >> Herring ; Mark Kettenis ; >> devicetree ; linux-arm-kernel > kernel@lists.infradead.org>; linux-kernel >> Cc: Zhen Lei >> Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of >> LX2160A UART >> >> Mark Kettenis told us that: >> According to the NXP documentation, the LX2160A has a real PL011 UART. >> >> Therefore, rewrite it to the compatible string of pl011. The property "current- >> speed" specific to "arm,sbsa-uart" is also deleted. > > Sorry that I missed the discussion on the v1. But looks like this change breaks the LX2160 boot. The AMBA matching doesn't seem to work. And the console is not registered correctly. https://lore.kernel.org/linux-arm-kernel/cba3a29f-92b5-072a-9a27-60240f072dad@huawei.com/ Maybe we should fall back to v1. > > [ 0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000 > [ 0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000 > >> >> Suggested-by: Shawn Guo >> Suggested-by: Mark Kettenis >> Signed-off-by: Zhen Lei >> --- >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++-------- >> 1 file changed, 4 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> index c4b1a59ba424..d2e6f7285674 100644 >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi >> @@ -920,34 +920,30 @@ QORIQ_CLK_PLL_DIV(8)>, >> }; >> >> uart0: serial@21c0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21c0000 0x0 0x1000>; >> interrupts = ; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> uart1: serial@21d0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21d0000 0x0 0x1000>; >> interrupts = ; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> uart2: serial@21e0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21e0000 0x0 0x1000>; >> interrupts = ; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> uart3: serial@21f0000 { >> - compatible = "arm,sbsa-uart","arm,pl011"; >> + compatible = "arm,pl011", "arm,primecell"; >> reg = <0x0 0x21f0000 0x0 0x1000>; >> interrupts = ; >> - current-speed = <115200>; >> status = "disabled"; >> }; >> >> -- >> 2.25.1 >> > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel