From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 15EE3C678D6 for ; Tue, 10 Jan 2023 14:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gvosMX6KGFjbL63paYptfE9m/TTH13wxGlRP1CevTXA=; b=k8lW0OYQO2k2clWjGmIN/F07Fk 5yzC73Y38V9df5ysPkX5/e5UcDsPnhjsTj0/cl/cX0WJDVrqAqxRl2uNw5Q6ZSoyWbWzntvDgVu8f 0O9grucvR3wMK1bG96P4WLWJenZ4MTEGglZnds0Doa+YY5X8l12FQdiv1Xl9F+wv22SsS315VgJCf rWJpiG87eixQUiF7XlLnPuArEGFsHnziqP3I8dLv9QCDaN9cuDWip1Sai145t72dEz/tid7FRTKxB bmOA9qFfAPO3VA17ibme5raXfrJ68iDwPCPwso5IEQT4qMv7pbjUJTf0mdb3wqb87+n8liZ/S0TrN bql8/uSQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFFse-007Nh6-L0; Tue, 10 Jan 2023 14:45:36 +0000 Received: from 0001.3ffe.de ([159.69.201.130] helo=mail.3ffe.de) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFFsb-007Nf2-Ov for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 14:45:35 +0000 Received: from 3ffe.de (0001.3ffe.de [IPv6:2a01:4f8:c0c:9d57::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.3ffe.de (Postfix) with ESMTPSA id 0EB5815E8; Tue, 10 Jan 2023 15:45:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=walle.cc; s=mail2022082101; t=1673361929; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=edcQ3D/tMu50+hRka0QLurv2Lq4o2JMfsyqJUI/Go40=; b=hcWFe7vj7pU1N49GwFe6dFsc1xp+SdnTMQgOOANFgfa0I4j12Yp/pQOlA7jHmork6a4ST8 KwlZdvfzzCMwETYMSuKaQJKiAJV+jBljYWSiu6nq7escZggd1ds68Pt20WbPNNmoqp1QYw FvGINrVlAqv7Hhzk70IwcrU19RjwzkzfFm2A0dRY1FSFTd0uuaRSnpaqAeHMtGKav5aYIj D6ain+JCRltRUwFQv7zlDAynCJJGWKlkDQEEU9gh7lOR/oWOrWSmMHe3Y61U2PTf08/cEy Iezf0/5vYjpyjc9LRq8BYmYtfxqBlzN6HwpAYEMwyt89erR8i/5l7s1xEoEMoA== MIME-Version: 1.0 Date: Tue, 10 Jan 2023 15:45:28 +0100 From: Michael Walle To: Peng Fan , Alexander Stein Cc: Aisheng Dong , linux-arm-kernel@lists.infradead.org, Srinivas Kandagatla , aisheng.dong@nxp.com, linux-arm-kernel@lists.infradead.org, srinivas.kandagatla@linaro.org, Krzysztof Kozlowski , Rob Herring Subject: Re: issue: could not get #nvmem-cell-cells In-Reply-To: References: User-Agent: Roundcube Webmail/1.4.13 Message-ID: <03db256d8cb68344d9e42ae8ee694ec7@walle.cc> X-Sender: michael@walle.cc X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_064534_012657_4423E029 X-CRM114-Status: GOOD ( 11.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, Am 2023-01-10 09:07, schrieb Peng Fan: > I see you have added nvmem-cell-cells support, but with linux-next, I > see error on i.MX8MP-EVK: > [ 0.027518] OF: /soc@0: could not get #nvmem-cell-cells for > /soc@0/bus@30000000/efuse@30350000/unique-id@8 > [ 0.027868] OF: /soc@0/bus@30000000/tmu@30260000: could not get > #nvmem-cell-cells for /soc@0/bus@30000000/efuse@30350000/calib@264 > [ 0.030338] OF: /soc@0/bus@30800000/ethernet@30be0000: could not > get #nvmem-cell-cells for > /soc@0/bus@30000000/efuse@30350000/mac-address@90 > [ 0.030511] OF: /soc@0/bus@30800000/ethernet@30bf0000: could not > get #nvmem-cell-cells for > /soc@0/bus@30000000/efuse@30350000/mac-address@96 > > Do you have ideas? Could you try the following patch: ---snip--- commit 83f1bd351a2194844599ffc08050f5bc61a06086 (HEAD -> master) Author: Michael Walle Date: Tue Jan 10 15:16:48 2023 +0100 of: property: fix #nvmem-cell-cells parsing Commit 67b8497f005 ("of: property: make #.*-cells optional for simple props") claims to make the cells-name property optional for simple properties, but changed the code for the wrong property, i.e. for DEFINE_SUFFIX_PROP(). Fix that. Fixes: 67b8497f005 ("of: property: make #.*-cells optional for simple props") Reported-by: Peng Fan Signed-off-by: Michael Walle diff --git a/drivers/of/property.c b/drivers/of/property.c index 8d9ba20a8f90..95b838185b2f 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1202,8 +1202,8 @@ static struct device_node *parse_prop_cells(struct device_node *np, if (strcmp(prop_name, list_name)) return NULL; - if (of_parse_phandle_with_args(np, list_name, cells_name, index, - &sup_args)) + if (__of_parse_phandle_with_args(np, list_name, cells_name, 0, index, + &sup_args)) return NULL; return sup_args.np; @@ -1256,8 +1256,8 @@ static struct device_node *parse_suffix_prop_cells(struct device_node *np, if (strcmp_suffix(prop_name, suffix)) return NULL; - if (__of_parse_phandle_with_args(np, prop_name, cells_name, 0, index, - &sup_args)) + if (of_parse_phandle_with_args(np, prop_name, cells_name, index, + &sup_args)) return NULL; return sup_args.np; ---snip--- - _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel